`size` API docs throughout `@daffodil/design` is being rendered incorrectly

[xelaint]

Is this a regression?

• Yes, this behavior used to work in the previous version

Description

In tag, size is passed in as DaffButtonSize, and the defaultSize value is "sm", even though it's set to md in the component.

https://next.daff.io/docs/design/components/tag?tab=api-tab

Spinner's size is also set to DaffButtonSize.
https://next.daff.io/docs/design/components/spinner?tab=api-tab

Environment

• Daffodil version: 0.92.0
• Angular version:
• Browser(s):
• Node version: run node --version
• Operating system:

Steps to reproduce

Steps to reproduce:

1. Visit https://next.daff.io/docs/design/components/tag?tab=api-tab or https://next.daff.io/docs/design/components/spinner?tab=api-tab

Expected behavior

size for each component should pass in the correct values instead of DaffButtonSize

Actual behavior

DaffButtonSize is being used throughout design components.

Additional context

No response

[xelaint]

@griest024 Is this because of #3744?

[griest024]

@griest024 Is this because of #3744?

to be honest I'm not sure. Seems likely, even though the types in this case are not identical. I think dgeni just can't infer the generics properly.

[griest024]

@xelaint setting defaultSize in the constructor won't show up in daffio because its a runtime behavior, the typechecker has no idea about it.

[griest024]

DaffButtonSize problem is being caused by passing the parent member size by reference to the child DaffButtonComponent, which adds its own type and inheritance info. Later symbols that inherit this member, like DaffTagComponent, inherit the same member that was inherited by DaffButtonComponent.

The fix is to clone the member when inheriting but that completely breaks dgeni, probably because of the alias map.

[griest024]

actually yes, after deep investigation, this is exactly #3744. defaultSize will never show as 'md' though for the reasons I explained earlier.

Our dgeni code is correctly asking for the type that is assigned to the property size in DaffTagSizableDirective. Coming from DaffSizableDirective, the type is T. Once the code tries to refine the type in the scope of DaffTagSizableDirective, the #3744 bug occurs.

[xelaint]

@griest024 should I keep this issue open anyway to track that size renders correct after #3744 is fixed?

[griest024]

@griest024 should I keep this issue open anyway to track that size renders correct after #3744 is fixed?

Yes, I think there might be another bug here