Summary
client-api has misspelled neighborhood setting keys in G_API_SETTINGS, while adjacent docs/comments and client-api-react use the correctly spelled names.
Evidence
- Misspelled keys in
projects/client-api/src/index.js:
neighbhorhoodHighlight at line 1199
neighbhorhoodHighlightHops at line 1200
- Same file docs/comments use correct spellings:
neighborhoodHighlight and neighborhoodHighlightHops around lines 1247-1248
client-api-react bindings use correct spellings:
projects/client-api-react/src/bindings.js lines 15-16
Why this matters
Consumers calling updateSetting() with correctly spelled keys may fail or behave unexpectedly due to cross-surface naming inconsistency.
Requested fix
- Add correctly spelled keys to
G_API_SETTINGS:
neighborhoodHighlight
neighborhoodHighlightHops
- Keep misspelled keys as temporary aliases for backward compatibility:
neighbhorhoodHighlight
neighbhorhoodHighlightHops
- Emit deprecation warning when misspelled aliases are used.
- Add tests ensuring both spellings resolve to identical model paths.
- Update changelog/docs.
Summary
client-apihas misspelled neighborhood setting keys inG_API_SETTINGS, while adjacent docs/comments andclient-api-reactuse the correctly spelled names.Evidence
projects/client-api/src/index.js:neighbhorhoodHighlightat line 1199neighbhorhoodHighlightHopsat line 1200neighborhoodHighlightandneighborhoodHighlightHopsaround lines 1247-1248client-api-reactbindings use correct spellings:projects/client-api-react/src/bindings.jslines 15-16Why this matters
Consumers calling
updateSetting()with correctly spelled keys may fail or behave unexpectedly due to cross-surface naming inconsistency.Requested fix
G_API_SETTINGS:neighborhoodHighlightneighborhoodHighlightHopsneighbhorhoodHighlightneighbhorhoodHighlightHops