Skip to content

Find edge uses wrong iterator logic #6

@ehein6

Description

@ehein6

This iterator logic looks broken to me. Shouldn't the iterator eit be compared against the end of the list instead of the beginning?

edge_iterator find_in_edge(uint64_t vid, edge_iterator eit)
{
for (;eit!=in_edges.begin();eit++)
{
if (eit->target()==vid)
return eit;
}
}
edge_iterator find_out_edge(uint64_t vid, edge_iterator eit)
{
for (;eit!=out_edges.begin();eit++)
{
if (eit->target()==vid)
return eit;
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions