There are two lines of code in graphIO.c that perform the ternary conditional operator and that produce warnings when building the tar.gz file. A note that comes with the warning indicates that parentheses can be added to indicate that the ternary operator is intended even if it appears to produce some dead code.
The ternary operator in those locations is preferred because the underlying EAPS code supports compile-time switching between 1-based and 0-based array indexing. The planarity Python package only uses the 1-based version.
Find out where the parentheses go and then add them, commit, and ensure that the warnings go away.
Perform the same amendment to graphIO.c in EAPS. Then test compilation on Windows with MSVC and MinGW gcc, release and debug, on MacOS with clang, release and debug, Debian release and debug, and then commit and run all EAPS GitHub actions to ensure no compiler produces a warning or error from the addition of the parentheses.
There are two lines of code in
graphIO.cthat perform the ternary conditional operator and that produce warnings when building the tar.gz file. A note that comes with the warning indicates that parentheses can be added to indicate that the ternary operator is intended even if it appears to produce some dead code.The ternary operator in those locations is preferred because the underlying EAPS code supports compile-time switching between 1-based and 0-based array indexing. The planarity Python package only uses the 1-based version.
Find out where the parentheses go and then add them, commit, and ensure that the warnings go away.
Perform the same amendment to
graphIO.cin EAPS. Then test compilation on Windows with MSVC and MinGW gcc, release and debug, on MacOS with clang, release and debug, Debian release and debug, and then commit and run all EAPS GitHub actions to ensure no compiler produces a warning or error from the addition of the parentheses.