Skip to content

Update language on Site goals breakdown notices #13153

Description

@jimmymadon

Feature Description

The language used in the Custom Dimension Breakdown Setup Notices should be updated to the latest figma mocks. This was raised in the Bug bash: https://app.asana.com/1/8468971550303/project/1215795095553989/task/1216056429395225?focus=true


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • Update the text appropriately within assets/js/modules/analytics-4/components/site-goals/notifications/useSiteGoalsBreakdownNoticeCopy.tsx.

Test Coverage

  • No new tests required.

QA Brief

  • Ensure all custom dimensions are deleted on a connected analytics property to test the "both" requirements in the AC.
  • Then let site kit create all the custom dimensions by enabling breakdown. Now go to the analytics property and delete only the googlesitekit_form_id custom dimension to make the "Only lead" case true. Or simply have a detected event set for the Lead generation widget (i.e. contact or submit_lead_form)
  • To test the "only ecommerce" case, set the detected events in the tester plugin to only be purchase.

Changelog entry

  • Update notice text for Site Goals.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0High priorityTeam SIssues for Squad 1Type: EnhancementImprovement of an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions