policy: Implement Clone() for the PolicyCalculator#434
Open
Foxboron wants to merge 1 commit into
Open
Conversation
josephlr
requested changes
Jun 2, 2026
josephlr
left a comment
josephlr
left a comment
Member
There was a problem hiding this comment.
I like this change, thank you.
Could we add a small test to tpm2/test/policy_test.go to check that Clone works as expected? I can be a very simple test-case.
Contributor
Author
Of course. I didn't spend time on a test because the change was simple and I was not completely sure if this was a good idea to begin with :) |
When implementing nested policies, like systemd-pcrlock, it's practical to clone the current PolicyCalculator to transfer the state of the previous policy without mutation. Signed-off-by: Morten Linderud <morten@linderud.pw>
Foxboron
force-pushed
the
morten/clone-calc
branch
from
2d09d02 to
3883d14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing nested policies, like systemd-pcrlock, it's practical to clone the current PolicyCalculator to transfer the state of the previous policy without mutation.