fix: reject json response mime with function calling#5749
Conversation
51bd3da to
79ac418
Compare
|
Refreshed on current main. Local validation after the refresh: targeted agent-field tests passed (8 passed / 37 deselected), the related llm_flow processor tests passed (19 passed), pyink --check, py_compile, and git diff --check all passed. I installed the missing local �nthropic test dependency in the clean-clone venv; no project files changed for that. |
|
Hi @he-yufeng , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing tests before we can proceed with the review. |
b45c0e9 to
1a9112f
Compare
|
Rebased onto current Validation: I also installed the missing local |
Summary
response_mime_type="application/json"when an agent has tools and function calling is enabledfunction_calling_config.mode="NONE") allowedFixes #5735.
Validation
.\.venv\Scripts\python.exe -m pytest tests\unittests\agents\test_llm_agent_fields.py -q -k "json_response_with_function_calling or validate_generate_content_config".\.venv\Scripts\python.exe -m pytest tests\unittests\flows\llm_flows\test_basic_processor.py tests\unittests\flows\llm_flows\test_output_schema_processor.py -q.\.venv\Scripts\pyink.exe --check src\google\adk\agents\llm_agent.py tests\unittests\agents\test_llm_agent_fields.pygit diff --checkNote: direct single-file
mypy src/google/adk/agents/llm_agent.pystill reports existing strict typing issues elsewhere in that file, outside this change.