fix: address code review feedback on compress command

Author: cocosheng-g

packages/cli/src/ui/AppContainer.test.tsx

@@ -3578,7 +3578,7 @@ describe('AppContainer State Management', () => {
   });
 
   describe('Compression Queuing', () => {
-    it('queues messages during compression instead of handling as steering hints', async () => {
+    beforeEach(async () => {
       const { checkPermissions } = await import(
         './hooks/atCommandProcessor.js'
       );
@@ -3606,9 +3606,14 @@ describe('AppContainer State Management', () => {
           },
         ],
       }));
+    });
 
+    it('queues messages during compression instead of handling as steering hints', async () => {
       const { unmount } = await act(async () => renderAppContainer());
 
+      // Verify state isolation
+      expect(capturedUIState.streamingState).toBe(StreamingState.Idle);
+
       // Submit a message
       await act(async () =>
         capturedUIActions.handleFinalSubmit('follow up message'),
@@ -3619,5 +3624,21 @@ describe('AppContainer State Management', () => {
 
       unmount();
     });
+
+    it('queues slash commands during compression', async () => {
+      const { unmount } = await act(async () => renderAppContainer());
+
+      // Submit a slash command
+      await act(async () => capturedUIActions.handleFinalSubmit('/help'));
+
+      // Verify it was queued
+      expect(capturedUIState.messageQueue).toContain('/help');
+      // Verify handleSlashCommand was NOT called immediately
+      expect(
+        mockedUseSlashCommandProcessor().handleSlashCommand,
+      ).not.toHaveBeenCalled();
+
+      unmount();
+    });
   });
 });

packages/cli/src/ui/AppContainer.tsx

@@ -1426,8 +1426,8 @@ Logging in with Google... Restarting Gemini CLI to continue.
 
       const isMcpOrConfigReady = isConfigInitialized && isMcpReady;
       if (
-        (isSlash && isConfigInitialized) ||
-        (isIdle && !isCompressing && isMcpOrConfigReady)
+        !isCompressing &&
+        ((isSlash && isConfigInitialized) || (isIdle && isMcpOrConfigReady))
       ) {
         if (!isSlash) {
           const permissions = await checkPermissions(submittedValue, config);

packages/cli/src/ui/commands/compressCommand.test.ts

@@ -42,6 +42,7 @@ describe('compressCommand', () => {
       },
     };
     await compressCommand.action!(context, '');
+    await new Promise((r) => setTimeout(r, 0));
     expect(context.ui.addItem).toHaveBeenCalledWith(
       expect.objectContaining({
         type: MessageType.ERROR,
@@ -62,6 +63,7 @@ describe('compressCommand', () => {
     mockTryCompressChat.mockResolvedValue(compressedResult);
 
     await compressCommand.action!(context, '');
+    await new Promise((r) => setTimeout(r, 0));
 
     expect(context.ui.setPendingItem).toHaveBeenNthCalledWith(1, {
       type: MessageType.COMPRESSION,
@@ -98,6 +100,7 @@ describe('compressCommand', () => {
     mockTryCompressChat.mockResolvedValue(null);
 
     await compressCommand.action!(context, '');
+    await new Promise((r) => setTimeout(r, 0));
 
     expect(context.ui.addItem).toHaveBeenCalledWith(
       expect.objectContaining({
@@ -114,6 +117,7 @@ describe('compressCommand', () => {
     mockTryCompressChat.mockRejectedValue(error);
 
     await compressCommand.action!(context, '');
+    await new Promise((r) => setTimeout(r, 0));
 
     expect(context.ui.addItem).toHaveBeenCalledWith(
       expect.objectContaining({
@@ -128,6 +132,7 @@ describe('compressCommand', () => {
   it('should clear the pending item in a finally block', async () => {
     mockTryCompressChat.mockRejectedValue(new Error('some error'));
     await compressCommand.action!(context, '');
+    await new Promise((r) => setTimeout(r, 0));
     expect(context.ui.setPendingItem).toHaveBeenCalledWith(null);
   });