Address review feedback on primitives.py and test_bundler_primitives.py

- Replace ... with pass in _KindManager Protocol method stubs
- Conditionally pass force= keyword only when force=True in _PresetKindManager
- Fix _StepKindManager.refresh() to remove step before re-installing
- Rename test to reflect actual assertion (refresh succeeds + force=True)
- Remove duplicate install_bundle import

Assisted-by: GitHub Copilot (model: claude-sonnet-4.5, autonomous)

Author: Copilot

src/specify_cli/bundler/services/primitives.py

@@ -85,13 +85,17 @@ def _bundled_manifest_version(manifest_path: Path, root_key: str) -> str | None:
 
 
 class _KindManager(Protocol):
-    def is_installed(self, component: ComponentRef) -> bool: ...
+    def is_installed(self, component: ComponentRef) -> bool:
+        pass
 
-    def install(self, component: ComponentRef) -> None: ...
+    def install(self, component: ComponentRef) -> None:
+        pass
 
-    def refresh(self, component: ComponentRef) -> None: ...
+    def refresh(self, component: ComponentRef) -> None:
+        pass
 
-    def remove(self, component: ComponentRef) -> None: ...
+    def remove(self, component: ComponentRef) -> None:
+        pass
 
 
 def primitive_manager(
@@ -176,7 +180,9 @@ def _do_install(self, component: ComponentRef, *, force: bool) -> None:
                 component.version,
                 _bundled_manifest_version(bundled / "preset.yml", "preset"),
             )
-            self._manager.install_from_directory(bundled, speckit_version, priority, force=force)
+            self._manager.install_from_directory(
+                bundled, speckit_version, priority, **({"force": True} if force else {})
+            )
             return
 
         if not self._allow_network:
@@ -202,7 +208,9 @@ def _do_install(self, component: ComponentRef, *, force: bool) -> None:
         )
         zip_path = catalog.download_pack(component.id)
         try:
-            self._manager.install_from_zip(zip_path, speckit_version, priority, force=force)
+            self._manager.install_from_zip(
+                zip_path, speckit_version, priority, **({"force": True} if force else {})
+            )
         finally:
             with contextlib.suppress(Exception):
                 if zip_path.exists():
@@ -398,8 +406,11 @@ def install(self, component: ComponentRef) -> None:
             )
 
     def refresh(self, component: ComponentRef) -> None:
-        # workflow_step_add is idempotent for already-installed steps; delegate
-        # to the standard install path which handles version refresh correctly.
+        # workflow_step_add errors when the step is already installed; remove it
+        # first (when network is permitted so the re-install can follow) before
+        # delegating to install().
+        if self._allow_network and self.is_installed(component):
+            self.remove(component)
         self.install(component)
 
     def remove(self, component: ComponentRef) -> None:

tests/unit/test_bundler_primitives.py

@@ -274,9 +274,9 @@ def test_default_installer_refresh_dispatches_to_kind_manager(tmp_path: Path, mo
     assert force_values == [True], "DefaultPrimitiveInstaller.refresh() must use force=True"
 
 
-def test_no_force_hint_in_bundler_error_on_refresh(tmp_path: Path, monkeypatch):
+def test_refresh_succeeds_and_passes_force_true(tmp_path: Path, monkeypatch):
     """Regression: bundle update (refresh=True) of an already-installed extension
-    must not surface the extension-level '--force' hint inside the BundlerError."""
+    must succeed and pass force=True to install_from_directory."""
     from specify_cli.bundler.services.installer import install_bundle
     from specify_cli.bundler.models.manifest import BundleManifest
     import specify_cli._assets as assets
@@ -299,7 +299,6 @@ def test_no_force_hint_in_bundler_error_on_refresh(tmp_path: Path, monkeypatch):
         "components": [{"kind": "extensions", "id": "my-ext"}],
     }
     manifest = BundleManifest(raw, source_id="test")
-    from specify_cli.bundler.services.installer import install_bundle
     from specify_cli.bundler.services.adapters import DefaultPrimitiveInstaller
 
     installer = DefaultPrimitiveInstaller(allow_network=False)