Typo in submodules, Access Rights etc ...

[ms140569]

Hi Gil,

thanks for your great post at:

https://gil0mendes.io/blog/an-efi-app-a-bit-rusty/

I had a really hard time to get in contact with you. Couldn't find any way to drop you an email or chat ...

The command to download the submodules has a typo and should read:

git submodule update --init

(it's in plural in the README.md file). But when downloading the submodules, access is not granted:

Cloning into '/home/schmidtm/prj/Initium/3rd-party/uefi-rs'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:gil0mendes/uefi-rs.git' into submodule path '/home/schmidtm/prj/Initium/3rd-party/uefi-rs' failed

If i clone this submodule sucessfully from it's original location by hand:

git clone https://github.com/rust-osdev/uefi-rs.git

and try to build the load using:

./build.py build

I am running into another issue with dropped features:

` Compiling x86_64 v0.13.6
error[E0557]: feature has been removed
--> /home/schmidtm/.cargo/registry/src/github.com-1ecc6299db9ec823/x86_64-0.13.6/src/lib.rs:5:43
|
5 | #![cfg_attr(feature = "const_fn", feature(const_fn))] // Needed for generic access to associated consts
| ^^^^^^^^ feature has been removed
|
= note: split into finer-grained feature gates

For more information about this error, try rustc --explain E0557.
e`

I really wann use your loader, but running out of options ...

cheers,

Matthias Schmidt

[gil0mendes]

Sorry, for the really really really late reply on this 🤦 Actually I didn't notice the issue here, and since I didn't have the opportunity to work on the project for so long I completely missed it.

I just got rid of the git submodule and also replaced the Python script with a build system completely written in Rust. So that solves the typo.

Also, upgraded some dependencies to support a more recent Rust's nightly build.