Make HTTP code configurable in http500 rule

[dividedmind]

BTW, I think maybe it should be changed to flag only 500, or made configurable. While a 500 is almost always a sign of a code problem, other 5xx errors are pretty specific and can be expected (ie. 'not implemented', 'insufficient storage').

Originally posted by @dividedmind in #77 (comment)

[kgilpin]

Yeah, I did this (i think)

…

On Fri, Jan 14, 2022 at 2:22 PM Rafał Rzepecki ***@***.***> wrote: BTW, I think maybe it should be changed to flag only 500, or made configurable. While a 500 is almost always a sign of a code problem, other 5xx errors are pretty specific and can be expected (ie. 'not implemented', 'insufficient storage'). *Originally posted by @dividedmind <https://github.com/dividedmind> in #77 (comment) <#77 (comment) — Reply to this email directly, view it on GitHub <#80>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVC63T5OM4PVA3CIY6F5LUWBZYPANCNFSM5L7SKVEQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[dividedmind]

Oh, I hadn't noticed, thanks. Should I leave this issue to make status code configurable though?

EDIT: Actually no, the code still checks for 5xx AFAICT: https://github.com/applandinc/scanner/blob/af2c9fa3e079186c40c8593b97b3d61f236abe42/src/rules/http500.ts

[kgilpin]

I don't think so. Do you think there will be a need to flag other codes?

…

On Fri, Jan 14, 2022 at 2:37 PM Rafał Rzepecki ***@***.***> wrote: Oh, I hadn't noticed, thanks. Should I leave this issue to make status code configurable though? — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVC6YSVTS6C5ODIIR6UBTUWB3PLANCNFSM5L7SKVEQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

[dividedmind]

I don't think so. Do you think there will be a need to flag other codes?

Some people might want that. There are places where some will be expected, others not. Maybe catch all 500 and allow a whitelist? Not sure what's the best approach here.