Fix countries not being actually updated#12
Conversation
Most of the countries have not been updated in months. This is caused by cache not being invalidated in this circumstance: - Github API returns list of users that are fewer than the current cache is holding. This fix will resolve most of (if not most) the issues over in https://github.com/gayanvoice/top-github-users/issues
|
@gayanvoice If you have time to review/accept this PR, it will resolve pretty much all open issues and PRs over at https://github.com/gayanvoice/top-github-users If you're busy, I can maintain it going forward. Just add me as a maintainer/collaborator. |
|
@affix0w @lissy93 @guizzo @tharindudj Thank you all for your attention to this matter. The purpose of the if condition was to ensure that the list contains more than or equal to the existing number of users. By merging this condition, it is possible to create a list with a variable number of users, ranging from 5 to 995. I added a condition more than 750 to the same file. |
|
Came here after looking into issue with Bosnia and Herzegovina not being updated for 9 months. Why can't the list be made in such a way to display top X users (50, 100, whatever)? The way it works at the moment certainly is flawed, there are instances where an update hasn't been done in more than a year. |
Most of the countries have not been updated in months. This is caused by cache not being invalidated in this circumstance:
This fix will resolve most of (if not most) the issues over in https://github.com/gayanvoice/top-github-users/issues