From a1b4ca71995831f240b73a77fd506d6bac44725a Mon Sep 17 00:00:00 2001 From: Wayne Sun Date: Wed, 15 Jul 2026 09:42:28 -0400 Subject: [PATCH] fix(#4718): wire the pre-script skip flags into the reusable workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pre-code.sh and pre-fix.sh (now in fullsend-ai/agents) grew CODE_SKIP_EXISTING_PR_CHECK and FIX_SKIP_TOOL_INSTALL flags so their harness pre_script invocation (inside `fullsend run`) can skip the work already done by these workflows' inline pre-run steps, instead of repeating it. This is the fullsend-ai/fullsend half of that split: - reusable-code.yml: pass GH_TOKEN to the inline "Validate inputs" step. It never had one, so pre-code.sh's existing-human-PR check (GH API search, pr-open label, skip comment) was silently a no-op there — the harness invocation was the only place it ever ran. Once CODE_SKIP_EXISTING_PR_CHECK is set on that harness invocation, the check needs to actually work on this side. - reusable-fix.yml: re-add a lightweight inline "Validate inputs" step with FIX_SKIP_TOOL_INSTALL=true, so PR_NUMBER/instruction/ iteration-cap validation still fails fast before GCP/agent-env setup, without re-running the pre-commit tool auto-install that only the harness invocation needs. Depends on the matching fullsend-ai/agents change for the flags themselves to exist. Assisted-by: Claude Signed-off-by: Wayne Sun --- .github/workflows/reusable-code.yml | 1 + .github/workflows/reusable-fix.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/reusable-code.yml b/.github/workflows/reusable-code.yml index fc504862e..b851bccbe 100644 --- a/.github/workflows/reusable-code.yml +++ b/.github/workflows/reusable-code.yml @@ -160,6 +160,7 @@ jobs: REPO_FULL_NAME: ${{ inputs.source_repo }} GITHUB_ISSUE_URL: ${{ fromJSON(inputs.event_payload).issue.html_url }} COMMENT_BODY: ${{ fromJSON(inputs.event_payload).comment.body }} + GH_TOKEN: ${{ steps.app-token.outputs.token }} FULLSEND_DIR: ${{ inputs.install_mode == 'per-repo' && '.fullsend' || '' }} run: bash "${FULLSEND_DIR:+$FULLSEND_DIR/}scripts/pre-code.sh" diff --git a/.github/workflows/reusable-fix.yml b/.github/workflows/reusable-fix.yml index 6cee2a0a8..9135b1c34 100644 --- a/.github/workflows/reusable-fix.yml +++ b/.github/workflows/reusable-fix.yml @@ -373,6 +373,7 @@ jobs: TRIGGER_SOURCE: ${{ inputs.trigger_source }} FIX_ITERATION: ${{ steps.context.outputs.iteration }} HUMAN_INSTRUCTION: ${{ steps.context.outputs.instruction }} + FIX_SKIP_TOOL_INSTALL: "true" FULLSEND_DIR: ${{ inputs.install_mode == 'per-repo' && '.fullsend' || '' }} run: bash "${FULLSEND_DIR:+$FULLSEND_DIR/}scripts/pre-fix.sh"