Inconsistent behaviour in `rmdir`

[TLCFEM]

This line declares default value recursive=True.

universal_pathlib/upath/core.py

Lines 1883 to 1901 in 8275740

	def rmdir(self, recursive: bool = True) -> None: # fixme: non-standard
	"""
	Remove this directory.
	Warning
	-------
	This method is non-standard compared to pathlib.Path.rmdir(),
	as it supports a `recursive` parameter to remove non-empty
	directories and defaults to recursive deletion.
	This behavior is likely to change in future releases once
	`.delete()` is introduced.
	"""
	if not self.is_dir():
	raise NotADirectoryError(str(self))
	if not recursive and next(self.iterdir()): # type: ignore[arg-type]
	raise OSError(f"Not recursive and directory not empty: {self}")
	self.fs.rm(self.path, recursive=recursive)

However, here the behavior is different.

universal_pathlib/upath/implementations/local.py

Lines 364 to 368 in 8275740

	def rmdir(self, recursive: bool = UNSET_DEFAULT) -> None:
	if recursive is UNSET_DEFAULT or not recursive:
	return super().rmdir()
	else:
	shutil.rmtree(self)

Hence when I call rmdir on a non-empty local folder, it throws.

from upath import UPath
from os import makedirs

makedirs('test/folder', exist_ok=True)
UPath('test').rmdir()

OSError: [Errno 39] Directory not empty: 'test'

[ap--]

Thank you for reporting!

I was hoping pathlib.Path.delete would become public before we make this change, but it doesn't look like it will happen soon.

Would you want to make a PR with changes to UPath.rmdir that will throw a future warning that UPath.rmdir's recursive keyword argument default will change in version 0.4.x ?
This should only throw the warning if no value was provided for recursive and the folder was not empty.

We can then follow-up with a PR exposing _delete https://github.com/python/cpython/blob/1d4e965829eef4cdb089a984fda21ca465a1f534/Lib/pathlib/__init__.py#L1258-L1267 and add a hint to the warning message.

After that a new 0.3.x version will be released and eventually the default value change can land in 0.4.0