Skip to content

Upgrade 0.16#78

Closed
josfeenstra wants to merge 3 commits into
fslabs:mainfrom
josfeenstra:upgrade-0.16
Closed

Upgrade 0.16#78
josfeenstra wants to merge 3 commits into
fslabs:mainfrom
josfeenstra:upgrade-0.16

Conversation

@josfeenstra

Copy link
Copy Markdown

Hey guys! How are you?

I'm doing the ridiculous thing of updating POLDERS to bevy 0.16, and I was using polylines.

I've tried my best to understand what's going on and make the appropriate updates.

Currently, i'm stuck on the changes regarding RenderVisibleEntities and VisibilityClass, the migration guide tells us to change:

visible_entities.get_mut<With<Mesh3d>>();

into

visible_entities.get_mut(TypeId::of::<Mesh3d>());

But this is not the right syntax. Moreover, while I'm using the appropriate new hooks, I can't seem to query the visible polylines. Can you guys see the issue?

@fslabs-bot

fslabs-bot Bot commented Jun 3, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fslabs-bot

fslabs-bot Bot commented Jun 3, 2025

Copy link
Copy Markdown

Welcome @josfeenstra! It looks like this is your first PR to ForesightMiningSoftwareCorporation/bevy_polyline 🎉

@fslabs-bot fslabs-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2025
@mockersf

mockersf commented Jun 3, 2025

Copy link
Copy Markdown

hi @josfeenstra!

Have you looked at #76?

Also, you probably shouldn't update rand at the same time

@josfeenstra

Copy link
Copy Markdown
Author

haha, couldve sworn that was not there yesterday, I think its best to close this :)

@josfeenstra josfeenstra closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants