Upgrade 0.16#78
Closed
josfeenstra wants to merge 3 commits into
Closed
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @josfeenstra! It looks like this is your first PR to ForesightMiningSoftwareCorporation/bevy_polyline 🎉 |
|
hi @josfeenstra! Have you looked at #76? Also, you probably shouldn't update |
Author
|
haha, couldve sworn that was not there yesterday, I think its best to close this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys! How are you?
I'm doing the ridiculous thing of updating POLDERS to bevy 0.16, and I was using polylines.
I've tried my best to understand what's going on and make the appropriate updates.
Currently, i'm stuck on the changes regarding
RenderVisibleEntitiesandVisibilityClass, the migration guide tells us to change:into
But this is not the right syntax. Moreover, while I'm using the appropriate new hooks, I can't seem to query the visible polylines. Can you guys see the issue?