Skip to content

Incorrect handling of passwords in K8s secrets containing characters using special characters #481

Description

@alfaskop

Hello,

I noticed that we got an issue when have a password in a secret for our database using ^.

When trying to find the cause for it, it seems there should be a url.QueryEscape(password) on this line,

core.EnvFromSecret("POSTGRES_PASSWORD", secret, "password"),
.

Compare this with line 27,

core.Env("POSTGRES_PASSWORD", url.QueryEscape(password)),
, where it's being encoded.

/Markus

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions