You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For walks on an OrientedMap, I think it would make sense to have a class Walk. The version of your code at commit 80ed422 introduces a class Walk for quad systems only (in quad_system.py) which has an additional _geodesic attributes.
The advantage of a well named class Walk is that we could then have Walk.geodesic_representative, Walk.self_intersection, Walk.has_simple_lift, etc A little drawback is that concatenation or accessing edges will be slower. But we could make the class so that the underlying data structure of the half-edge list is easily accessed (as we do with OrientedMap._vp).
To construct a walk, the entry point should just be OrientedMap.walk(self, ...).
Your function tree_contraction would better be a class that would return a morphism between the original OrientedMap and the one you obtain by doing some tree/co-tree contraction. A morphism is convenient to pass around objects on the OrientedMap (vertex, edge, walks, homotopy classe, homology classes, etc). In this particular case, you just want morphisms that contracts/deletes edges.
At #10, I introduced a word.pyx to implement at C level some operations on words (including free group elements). The underlying data structure is a Python array.
In #10 I finished the implementation of geometric intersection for OrientedMap with a single vertex and all faces punctured. It is currently in a separate file geometric_intersection.py but will hopefully be a method of Walk in the future. In order to handle the general case, I need to be able to
have a way to contract a spanning tree and a co-forest (in the punctured case)
There is already some works to contract spanning tree and co-tree in #11. We may adapt it.
I agree that it would be nice to have a common interface for all map reductions (Quadsystems and reducing triangulations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.