Shallow clone doesn't work without a tag

[ilya-fedin]

Checklist

• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.4.9

Flatpak version

1.16.6

How to reproduce

The following module results in a ~500 MB download cache:

  - name: tde2e
    buildsystem: cmake-ninja
    builddir: true
    config-opts:
      - -DTD_E2E_ONLY=ON
    sources:
      - type: git
        url: https://github.com/tdlib/td.git
        commit: 51743dfd01dff6179e2d8f7095729caa4e2222e9

Those commands result in a 6 MB folder:

git init tde2e
cd tde2e
git remote add origin https://github.com/tdlib/td.git
git fetch --depth=1 origin 51743dfd01dff6179e2d8f7095729caa4e2222e9

Expected Behavior

A ~6 MB download cache just like when I do it by hand

Actual Behavior

It's 100x times bigger :(

Additional Information

Flathub clears cache (which is both ccache+downloads) when it reaches 6 GB and this makes it way more frequent than it could be :(

[bbhtt]

It's supposed to work with commits too but it needs to point to the tip of a symbolic ref.

[ilya-fedin]

but it needs to point to the tip of a symbolic ref

Why? I'm able to shallow clone with manual commands just fine even though it doesn't point to one

[bbhtt]

Because that's what is implemented right now. I didn't say that the behaviour can't be improved.

Afaik when this was written git or GitHub didn't support pulling arbitrary commits. At least that's what flatpak/flatpak#1133 (comment) is alluding to. Someone would need to look into that.