Hi! I saw your plugin and it's very timely as some users I support are very interested in some of the features you have implemented, like field-by-field browsing, etc. It's very impressive!
One thing though, our Phenix is older, producing Harmony V6 index.xml and you have right now:
|
self.ns = {'ns': '43B2A954-E3C3-47E1-B392-6635266B0DD3/HarmonyV7'} |
So hard-coding Harmony7.
Would you be open to a PR to relax this to Harmony V6 and V7? I've tested with files from our instrument and they work. I also used Claude to parameterize the tests for both.
One other tiny thing:
Our index.xml is generated on Windows and has windows \ in the paths -- maybe a Harmony V6 thing only? I'm not sure! -- while the plugin runs on our HPC or local macOS machines, so POSIX. This causes some issues, so following suggestion from Claude I added use of pathlib PureWindowsPath in the _construct_image_path. Would you want that broken out into its own PR?
If you're open to contributions in general, I have a couple other small things from our users I might look into implementing...
Hi! I saw your plugin and it's very timely as some users I support are very interested in some of the features you have implemented, like field-by-field browsing, etc. It's very impressive!
One thing though, our Phenix is older, producing Harmony V6 index.xml and you have right now:
PyPhenix/src/pyphenix/_reader.py
Line 466 in d216956
So hard-coding Harmony7.
Would you be open to a PR to relax this to Harmony V6 and V7? I've tested with files from our instrument and they work. I also used Claude to parameterize the tests for both.
One other tiny thing:
Our index.xml is generated on Windows and has windows
\in the paths -- maybe a Harmony V6 thing only? I'm not sure! -- while the plugin runs on our HPC or local macOS machines, so POSIX. This causes some issues, so following suggestion from Claude I added use of pathlibPureWindowsPathin the_construct_image_path. Would you want that broken out into its own PR?If you're open to contributions in general, I have a couple other small things from our users I might look into implementing...