fix(remote): fix CI failures - typecheck, format, and unit tests

- Add missing required fields to RemoteSettings test mock (showInTray, minimizeToTrayOnClose, language)
- Update invokeMock assertions to match new start_remote_server signature with params
- Fix clippy warnings in remote_management.rs (use RangeInclusive::contains)
- Apply prettier formatting to RemoteSettings.tsx

Author: Yongmao Luo

src-tauri/tests/remote_management.rs

@@ -49,13 +49,13 @@ fn test_port_validation() {
     // 有效端口
     let valid_ports = [1024, 4000, 8080, 65535];
     for port in valid_ports {
-        assert!(port >= 1024 && port <= 65535);
+        assert!((1024..=65535).contains(&port));
     }
 
     // 无效端口（这些应该在 UI 层验证）
     let invalid_ports = [0, 100, 1023, 65536, 70000];
     for port in invalid_ports {
-        assert!(port < 1024 || port > 65535);
+        assert!(!(1024..=65535).contains(&port));
     }
 }
 

src/components/settings/RemoteSettings.tsx

@@ -19,17 +19,20 @@ export function RemoteSettings({ settings, onChange }: RemoteSettingsProps) {
   const [serverRunning, setServerRunning] = useState<boolean | null>(null);
   const [tailscaleIp, setTailscaleIp] = useState<string | null>(null);
 
-  const checkServerStatus = useCallback(async (port?: number) => {
-    const targetPort = port ?? settings.remotePort ?? 4000;
-    try {
-      const res = await fetch(`http://127.0.0.1:${targetPort}/api/health`);
-      setServerRunning(res.ok);
-      return res.ok;
-    } catch {
-      setServerRunning(false);
-      return false;
-    }
-  }, [settings.remotePort]);
+  const checkServerStatus = useCallback(
+    async (port?: number) => {
+      const targetPort = port ?? settings.remotePort ?? 4000;
+      try {
+        const res = await fetch(`http://127.0.0.1:${targetPort}/api/health`);
+        setServerRunning(res.ok);
+        return res.ok;
+      } catch {
+        setServerRunning(false);
+        return false;
+      }
+    },
+    [settings.remotePort],
+  );
 
   useEffect(() => {
     checkServerStatus();
@@ -57,7 +60,7 @@ export function RemoteSettings({ settings, onChange }: RemoteSettingsProps) {
           tailscaleEnabled: settings.remoteTailscaleEnabled,
         });
         // 等待服务器真正启动
-        await new Promise(resolve => setTimeout(resolve, 1000));
+        await new Promise((resolve) => setTimeout(resolve, 1000));
         const isRunning = await checkServerStatus(startPort);
         if (!isRunning) {
           throw new Error("Server failed to start");
@@ -98,7 +101,7 @@ export function RemoteSettings({ settings, onChange }: RemoteSettingsProps) {
         // 等待服务器完全停止（检查旧端口）
         const oldPort = settings.remotePort || 4000;
         for (let i = 0; i < 10; i++) {
-          await new Promise(resolve => setTimeout(resolve, 200));
+          await new Promise((resolve) => setTimeout(resolve, 200));
           try {
             await fetch(`http://127.0.0.1:${oldPort}/api/health`);
           } catch {
@@ -111,7 +114,7 @@ export function RemoteSettings({ settings, onChange }: RemoteSettingsProps) {
         onChange({ remoteTailscaleEnabled: value });
 
         // 等待一小段时间
-        await new Promise(resolve => setTimeout(resolve, 200));
+        await new Promise((resolve) => setTimeout(resolve, 200));
 
         // 启动服务器（传递新配置）
         await invoke("start_remote_server", {
@@ -120,7 +123,7 @@ export function RemoteSettings({ settings, onChange }: RemoteSettingsProps) {
         });
 
         // 等待并验证新端口启动成功
-        await new Promise(resolve => setTimeout(resolve, 1000));
+        await new Promise((resolve) => setTimeout(resolve, 1000));
         const isRunning = await checkServerStatus(settings.remotePort);
         if (!isRunning) {
           throw new Error("Server failed to restart on new port");
@@ -206,7 +209,7 @@ export function RemoteSettings({ settings, onChange }: RemoteSettingsProps) {
                     await invoke("stop_remote_server");
                     setServerRunning(false);
                     // 等待服务器完全停止
-                    await new Promise(resolve => setTimeout(resolve, 500));
+                    await new Promise((resolve) => setTimeout(resolve, 500));
                     // 先更新设置
                     onChange({ remotePort: val });
                     // 启动时传递新端口（使用 val 而不是 settings.remotePort）
@@ -215,7 +218,7 @@ export function RemoteSettings({ settings, onChange }: RemoteSettingsProps) {
                       tailscaleEnabled: settings.remoteTailscaleEnabled,
                     });
                     // 延迟检查状态，确保用户能看到重启指示
-                    await new Promise(resolve => setTimeout(resolve, 1500));
+                    await new Promise((resolve) => setTimeout(resolve, 1500));
                     await checkServerStatus(val);
                   } catch (e) {
                     toast.error(`${t("settings.remoteRestartFailed")} ${e}`);

tests/components/RemoteSettings.test.tsx

@@ -49,6 +49,9 @@ describe("RemoteSettings", () => {
     remoteEnabled: false,
     remotePort: 4000,
     remoteTailscaleEnabled: false,
+    showInTray: true,
+    minimizeToTrayOnClose: true,
+    language: "zh",
   };
 
   beforeEach(() => {
@@ -81,7 +84,10 @@ describe("RemoteSettings", () => {
     fireEvent.click(toggle);
 
     await waitFor(() => {
-      expect(invokeMock).toHaveBeenCalledWith("start_remote_server");
+      expect(invokeMock).toHaveBeenCalledWith(
+        "start_remote_server",
+        expect.any(Object),
+      );
       expect(mockOnChange).toHaveBeenCalledWith({ remoteEnabled: true });
     });
   });
@@ -182,7 +188,10 @@ describe("RemoteSettings", () => {
       expect(mockOnChange).toHaveBeenCalledWith({ remotePort: 4001 });
       // Should not try to stop/start server
       expect(invokeMock).not.toHaveBeenCalledWith("stop_remote_server");
-      expect(invokeMock).not.toHaveBeenCalledWith("start_remote_server");
+      expect(invokeMock).not.toHaveBeenCalledWith(
+        "start_remote_server",
+        expect.any(Object),
+      );
     });
   });
 
@@ -200,7 +209,10 @@ describe("RemoteSettings", () => {
     fireEvent.click(toggle);
 
     await waitFor(() => {
-      expect(invokeMock).toHaveBeenCalledWith("start_remote_server");
+      expect(invokeMock).toHaveBeenCalledWith(
+        "start_remote_server",
+        expect.any(Object),
+      );
       expect(toastErrorMock).toHaveBeenCalled();
     });
   });