Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Transition Model Type "" behaves differently from "deterministic" #20

Description

@sebimarkgraf

Hi,

I am just raising this issue for others, that will potentially trip over this small detail.
When choosing "" or "deterministic", while this creates the same object type of transition model,
the loss implementation in the bisim agent behaves different:

if self.transition_model_type == '':

This could potentially be fixed by choosing to check for "deterministic" and changing the default to "deterministic" instead of the empty string.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions