Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

question: reader loss #244

Open
Open
question: reader loss#244

Description

@PaulLerner
PaulLerner
opened on Feb 24, 2023

Hi,

I have trouble understanding this line in compute_loss in reader.py:

DPR/dpr/models/reader.py

Line 109 in a31212d

loss_tensor = loss_tensor.view(N, M, -1).max(dim=1)[0]

This keeps the maximum loss over all M passages, why? Why not summing or averaging?

Best regards,

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions