From 11b38631b5526581738d1276cfbd7ef6c1351377 Mon Sep 17 00:00:00 2001 From: AIDocsSourceLearner Bot Date: Wed, 24 Jun 2026 11:58:43 -0700 Subject: [PATCH] Update mt_app_install.md (+1 more) for fbcode/openzl/dev/.llms, www/flib/meta_account/entity/application/install/.llms Reviewed By: daniellerozenblit Differential Revision: D109529450 --- .claude/skills/openzl-codec-design/SKILL.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.claude/skills/openzl-codec-design/SKILL.md b/.claude/skills/openzl-codec-design/SKILL.md index 46c30be35..3e898167c 100644 --- a/.claude/skills/openzl-codec-design/SKILL.md +++ b/.claude/skills/openzl-codec-design/SKILL.md @@ -177,10 +177,11 @@ See `cpp/include/openzl/cpp/codecs/Zigzag.hpp` for a simple example, `cpp/includ 1. Add `#include "openzl/codecs/{codec}/encode_{codec}_binding.h"` 2. Add entry to `ER_standardNodes[]`: ```c -REGISTER_TRANSFORM(ZL_StandardNodeID_{codec}, ZL_StandardTransformID_{codec}, ZL_MAX_FORMAT_VERSION, EI_CODEC), +// REGISTER_TRANSFORM(NodeID, TransformID, minFormatVer, minLibraryVer, EI_MACRO) +REGISTER_TRANSFORM(ZL_StandardNodeID_{codec}, ZL_StandardTransformID_{codec}, 26, 202, EI_CODEC), ``` -NOTE: Do not use the macro `ZL_MAX_FORMAT_VERSION`, use the current value of that macro! This value tells OpenZL the minimum format version that is required to use this codec, which for new codecs is the current maximum format version. +NOTE: Hard-code the **current numeric values** of `ZL_MAX_FORMAT_VERSION` and `ZL_LIBRARY_VERSION_NUMBER` (e.g., `26, 202`) — do NOT pass the macros themselves. These pin the minimum format/library version required to use this codec; using the macros would silently widen support every time they bump (see `ACR_explicit_format_version_in_registrations`). ### Decoder Registry (`src/openzl/codecs/decoder_registry.c`)