Skip to content

Update ergom_zoo.F90#20

Open
harshalchauhan18 wants to merge 1 commit into
fabm-model:masterfrom
harshalchauhan18:patch-7
Open

Update ergom_zoo.F90#20
harshalchauhan18 wants to merge 1 commit into
fabm-model:masterfrom
harshalchauhan18:patch-7

Conversation

@harshalchauhan18

Copy link
Copy Markdown

No description provided.

@harshalchauhan18

Copy link
Copy Markdown
Author

Added DIC release by the zooplankton excretion.

@jornbr

jornbr commented Dec 15, 2021

Copy link
Copy Markdown
Member

Thanks for updating the uhh code. My main comment on this pull requests and the others, however, is that you're reverted preprocessor macros like _ADD_SOURCE_ to their old, deprecated version (in this case, _SET_ODE_). That's not a good idea, as those old macros will be removed in the next FABM version. Similarly, you're still working with namelists in your initialize routines, but the current FABM version does not read those anymore, so there is certainly no need to extend them. Instead, it would be better to remove them altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants