Skip to content
This repository was archived by the owner on Dec 14, 2022. It is now read-only.
This repository was archived by the owner on Dec 14, 2022. It is now read-only.

Expand Base Model Save  #80

@pattisdr

Description

@pattisdr

Is your feature request related to a specific problem?

Add methods that support asynchronous sessions to be used in separate base model get/create/save/update/delete, etc. methods.

class OrmWrappedFidesBase(FidesBase):

Context https://github.com/ethyca/fidesctl-plus/pull/333#discussion_r1029748992

For context, we now have a model, SystemScans in fides that inherits from the OrmWrappedFidesBase - system scans is normally updated via asynchronous sessions so you need to await the session commit and the session flush, for example. The OrmWrappedFidesBase only has methods that work with synchronous sessions.

Traditionally ops tended to use sync sessions and ctl tended to use async sessions.

Describe the solution you'd like

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions