Skip to content
This repository was archived by the owner on Dec 14, 2022. It is now read-only.
This repository was archived by the owner on Dec 14, 2022. It is now read-only.

Consider creating a ServerSettings configuration base class for FastAPI settings #59

@adamsachs

Description

@adamsachs

Is your feature request related to a specific problem?

Per some discussion on this fidesplus PR -- it may make sense to standardize/centralize basic FastAPI server settings that can be used across any different fides FastAPI apps.

Describe the solution you'd like

Similar to our DatabaseSettings and SecuritySettings base config classes currently defined in fideslib, we'd have a ServerSettings (not wedded to the name) that includes FastAPI server config properties. Using the fidesplus implementation referenced above, a starting point for config properties may look like:

class ServerSettings(Settings):
  host: str = Field("localhost")
  hot_reload: bool = Field(False, exclude=True)
  port: int = Field(8080)
  request_rate_limit: str = Field("100/minute")

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions