Add Kaifa MA309M dump from pos-ei-don#10
Merged
Merged
Conversation
forgot to change back from testing
Collaborator
|
Great job. I like this change :) |
There was a problem hiding this comment.
Pull request overview
This PR adds a new Kaifa MA309M M-Bus meter dump fixture (from @pos-ei-don’s ESPHome thread) and registers it in the integration test suite, extending real-world coverage for encrypted General-GLO-Ciphering (0xDB) M-Bus framed payloads.
Changes:
- Add a new expected-fixture header containing the raw frame, decryption key, and expected parsed values for Kaifa MA309M.
- Register a new
SUBCASEin the M-Bus integration tests to exercise the parser against this dump. - Add the corresponding raw dump, key, and decoded XML reference files under
tests/dumps/.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_meter_dumps.cpp | Adds a new M-Bus integration subcase for Kaifa MA309M and sets the decryption key before parsing. |
| tests/expected/mbus_kaifa_ma309m.h | Introduces the Kaifa MA309M raw frame, key, and expected OBIS outputs for the test. |
| tests/dumps/mbus_kaifa_ma309m.log | Adds the raw hex dump used to generate the fixture. |
| tests/dumps/mbus_kaifa_ma309m.key | Adds the (throwaway) AES-GCM decryption key associated with the dump. |
| tests/dumps/mbus_kaifa_ma309m_decoded.xml | Adds a decoded reference view of the payload to aid validation/debugging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds MBUS dump of Kaifa MA309M by @pos-ei-don from this comment