Test.exe: Crash at Avx2::AbsDifferenceSums3x3AutoTest

[nji9nji9]

Hi!
I just started trying the lib.

Building it @Win7-64 with gcc 8.1.0 does fine.

However running the test suite doesn't get very far before it crashes:

D:<user>\develop\Simd-7.0.160\build>test

[000] Info: AbsDifferenceAutoTest is started :
[000] Info: Test Simd::Base::AbsDifference & SimdAbsDifference [1920, 1080].
[000] Info: Test Simd::Base::AbsDifference & SimdAbsDifference [1929, 1071].
[000] Info: Test Simd::Sse41::AbsDifference & SimdAbsDifference [1920, 1080].
[000] Info: Test Simd::Sse41::AbsDifference & SimdAbsDifference [1929, 1071].
[000] Info: Test Simd::Avx2::AbsDifference & SimdAbsDifference [1920, 1080].
[000] Info: Test Simd::Avx2::AbsDifference & SimdAbsDifference [1929, 1071].
[000] Info: AbsDifferenceAutoTest is finished successfully in 1.2 s.

[000] Info: AbsDifferenceSumAutoTest is started :
[000] Info: Test Simd::Base::AbsDifferenceSum & SimdAbsDifferenceSum [1920, 1080].
[000] Info: Test Simd::Base::AbsDifferenceSum & SimdAbsDifferenceSum [1929, 1071].
[000] Info: Test Simd::Sse41::AbsDifferenceSum & SimdAbsDifferenceSum [1920, 1080].
[000] Info: Test Simd::Sse41::AbsDifferenceSum & SimdAbsDifferenceSum [1929, 1071].
[000] Info: Test Simd::Avx2::AbsDifferenceSum & SimdAbsDifferenceSum [1920, 1080].
[000] Info: Test Simd::Avx2::AbsDifferenceSum & SimdAbsDifferenceSum [1929, 1071].
[000] Info: AbsDifferenceSumAutoTest is finished successfully in 1.2 s.

[000] Info: AbsDifferenceSumMaskedAutoTest is started :
[000] Info: Test Simd::Base::AbsDifferenceSumMasked & SimdAbsDifferenceSumMasked [1920, 1080].
[000] Info: Test Simd::Base::AbsDifferenceSumMasked & SimdAbsDifferenceSumMasked [1929, 1071].
[000] Info: Test Simd::Sse41::AbsDifferenceSumMasked & SimdAbsDifferenceSumMasked [1920, 1080].
[000] Info: Test Simd::Sse41::AbsDifferenceSumMasked & SimdAbsDifferenceSumMasked [1929, 1071].
[000] Info: Test Simd::Avx2::AbsDifferenceSumMasked & SimdAbsDifferenceSumMasked [1920, 1080].
[000] Info: Test Simd::Avx2::AbsDifferenceSumMasked & SimdAbsDifferenceSumMasked [1929, 1071].
[000] Info: AbsDifferenceSumMaskedAutoTest is finished successfully in 1.2 s.

[000] Info: AbsDifferenceSums3x3AutoTest is started :
[000] Info: Test Simd::Base::AbsDifferenceSums3x3 & SimdAbsDifferenceSums3x3 [1920, 1080].
[000] Info: Test Simd::Base::AbsDifferenceSums3x3 & SimdAbsDifferenceSums3x3 [1929, 1071].
[000] Info: Test Simd::Sse41::AbsDifferenceSums3x3 & SimdAbsDifferenceSums3x3 [1920, 1080].
[000] Info: Test Simd::Sse41::AbsDifferenceSums3x3 & SimdAbsDifferenceSums3x3 [1929, 1071].
[000] Info: Test Simd::Avx2::AbsDifferenceSums3x3 & SimdAbsDifferenceSums3x3 [1920, 1080].
Crashes. (no further output).

[nji9nji9]

I suspect an alignment issue.

So added option -mstackrealign for targets Release and RelWithDebInfo in CMakeList.txt.
Rebuild, run test, ... still crashed.

More info:
CPU: i7-6700: AVX2 capable.
Made a simple test using
__m256i, _mm256_load_si256(), _mm256_add_epi32 and _mm256_store_si256:
All fine.

Run test suite again:
Test.exe -m=a -fe=AbsDifferenceSums3x3.
Result:
5 blocks (with 6 tests each) run fine.
Then:
[000] Info: SquaredDifferenceSum32fAutoTest is started :
[000] Info: Test Simd::Base::SquaredDifferenceSum32f & SimdSquaredDifferenceSum32f [2073600].
[000] Error:
Fail comparison:
Error at [0] : 6.57242e+12 != 6.57958e+12; (absolute = 7.15653e+09, relative = 0.00108769)!
Stop comparison.

[000] Error: SquaredDifferenceSum32fAutoTest has errors. TEST EXECUTION IS TERMINATED!

[nji9nji9]

OK, traced it down.
The culprit seems to be MinGW-w64 @ Win handling Windows x64 ABI.
Even at most up-to-date gcc 15.x.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412

A workaround is to disable AVX2 by
uncommenting #define SIMD_AVX2_DISABLE
in SimdConfig.h.

Not nice... however.

A suggestion derived from all that:
Maybe the uncommenting could be done automatically by the make process?
(If gcc == mingw... or something like that.)
To prevent more users having that problem.

[ermig1979]

Thank you for bug report!
I will try to fix this errors.

[ermig1979]

I did some fixes in 'dev' branch. I hope that they solve this issue. But I can't check because I can't reproduce this bug on available platforms. Can you check it?

[nji9nji9]

I checked 'dev' branch.

No problems with building.
Then ran test.exe
What's new: It didn't crash (although I did not uncomment #define SIMD_AVX2_DISABLE this time).
However, after performing lots of tests, it interupts:

[000] Info: NeuralAddConvolution2x2SumAutoTest is started :
[000] Info: Test Simd::Base::NeuralAddConvolution2x2Sum & SimdNeuralAddConvolution2x2Sum [1920, 1080].
[000] Error:
Fail comparison:
Error at [2] : 2455.25 != 2458.51; (absolute = 3.26147, relative = 0.0013266)!

[000] Error: NeuralAddConvolution2x2SumAutoTest has errors. TEST EXECUTION IS TERMINATED!

Even bigger eps necessary?

(Please note I made a typo in former post: it was always SIMD_AVX2_DISABLE not ...FMA...)

[ermig1979]

I did some additional fixes. Could you try to check again?

[nji9nji9]

test -m=a -tt=8 -ot=log.txt

Test progress: 19.9%[005] Info: Test Simd::Base::NeuralAddConvolution2x2Sum & SimdNeuralAddConvolution2x2Sum [1920, 1080].
[005] Error:
Fail comparison:
Error at [2] : 2455.25 != 2458.51; (absolute = 3.26147, relative = 0.0013266)!

[005] Error: NeuralAddConvolution2x2SumAutoTest has errors. TEST EXECUTION IS TERMINATED!

[ermig1979]

I did some fixes to resolve this issue. Is there still any errors?

[nji9nji9]

OK then:
Took dev-branch again.
Make failed:

...
OpenCV tests: OFF
Install target: ON
Uninstall target: ON
Python wrapper: ON
Extract project version:
Last project version 'UNKNOWN' is not equal to current version '7.0.160'.
Create or update file 'D:\develop\Simd-dev\prj\cmake\..\..\src\Simd\SimdVersion.h'.
-- Configuring done
-- Generating done
-- Build files have been written to: D:/develop/Simd-dev/build