chore(deps): bump godror v0.50.0 -> v0.51.0 (Oracle driver) with ADB review

[ericfitz]

Summary

During the /deps:bump sweep on dev/1.4.0, the Oracle DB driver
github.com/godror/godror had a minor update available (v0.50.0 → v0.51.0)
that was held rather than shipped. The two other Go bumps from that sweep
(oci-go-sdk/v65 and gorm.io/gorm, both patch) were applied in commit
aacf54d7; godror was deferred.

Why deferred: godror is the production Oracle driver (used under
oracle-samples/gorm-oracle v1.1.2 against Oracle ADB). Per the project's
Oracle compatibility policy, a DB-driver change must pass oracle-db-admin
review before completion, and the oracle-db-admin subagent was unavailable
during that session. It is not a security fix (govulncheck is clean), so
there was no urgency to ship it unreviewed.

Acceptance Criteria

• Apply the bump on dev/1.4.0: go get github.com/godror/godror@v0.51.0 && go mod tidy
• Run the oracle-db-admin subagent review of the v0.50.0 → v0.51.0 change
  (connection/pool handling, bind/type mapping for NUMBER/CLOB/BLOB/TIMESTAMP/BOOLEAN,
  LOB handling, transaction/isolation, ORA-error surfacing). Address any BLOCKING findings.
• Confirm compatibility with the pinned gorm-oracle v1.1.2 and the Oracle Instant
  Client used in the OCI container build.
• Run make test-integration-oci (real ADB) — must pass.
• make build-server, make lint, make test-unit green.

Notes

• Reference: dev/1.4.0 dependency bump commit aacf54d7; main bump PR chore(deps): bump dependencies #500.
• The identical gorm v1.31.1 → v1.31.2 transition already shipped in chore(deps): bump dependencies #500 with an
  oracle-db-admin APPROVED WITH NOTES verdict (watch for slightly more eager
  AutoMigrate column ALTERs).

[ericfitz]

Progress — godror bump applied & merged to dev/1.4.0

Commit 762a2e27 bumps github.com/godror/godror v0.50.0 → v0.51.0.

Completed:

• Applied godror@v0.51.0 + go mod tidy on dev/1.4.0
• oracle-db-admin review → APPROVED WITH NOTES. v0.51.0 embeds ODPI-C v6.0.0 (was 5.6.4) and moves statement/LOB finalizers to runtime.AddCleanup; no exported godror Go API changed. gorm-oracle v1.1.2 (pins godror v0.50.0) is lifted to v0.51.0 safely via MVS — it only uses the unchanged godror.Lob. Error classification (internal/dberrors OraErr/ORA-codes), NUMBER/CLOB/BLOB/TIMESTAMP/boolean type mapping, transactions, and pool semantics are all unaffected. Empty CLOB/BLOB writes are safer. OCI build's Instant Client 23ai satisfies the ODPI-C 6.0 floor.
• make build-server, make lint (0 issues), make test-unit (2374 passed) all green.

Remaining — pre-deploy gate (not a pre-merge blocker, per the review):

• make test-integration-oci against make dev-up DB=oracle — a real-ADB smoke test (CRUD + a forced unique-violation to confirm OraErr.Code() classification + a CLOB round-trip). Required because the ODPI-C major bump links against Instant Client at runtime. Run this before the next production/ADB deploy of 1.4.0.

Keeping this issue open to track that ADB smoke test.

[ericfitz]

✅ ADB smoke test PASSED — closing

Ran the pre-deploy gate against the live tmiadb ADB in us-ashburn-1 (had to start the instance — it had auto-stopped on inactivity; ORA-12514 until it was AVAILABLE again).

• make dev-up DB=oracle → server pod connected to ADB via godror v0.51.0 (ODPI-C 6.0), AutoMigrate clean, db=healthy (~38ms).
• make test-integration-oci → 15 passed, 0 failed, 1 skipped across the api/ integration tests and the oracle-tagged driver-level store tests.
• Tore down the kind env (make dev-down DB=oracle, ADB data preserved).

All acceptance criteria satisfied; godror v0.51.0 is verified end-to-end on real Oracle ADB. (Commit 762a2e27 on dev/1.4.0.)