polish oxlint follow-up tooling

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

Author: cursoragent

.github/DISCUSSION_TEMPLATE/oxlint-suggestion.yml

@@ -0,0 +1,55 @@
+body:
+  - type: markdown
+    attributes:
+      value: |-
+        Thank you for helping to improve `@epic-web/config`!
+
+        Please fill out the details below.
+
+        Keep in mind you can always extend the built-in configuration with your own config.
+  - type: textarea
+    attributes:
+      label: Search Terms Used
+      description: >-
+        Please list the search terms you used to search the discussions, issues,
+        and PRs before submitting this issue.
+    validations:
+      required: true
+  - type: input
+    attributes:
+      label: Rule or Config Docs
+      description: >-
+        Link to the Oxlint rule or configuration docs you're suggesting
+        changing
+      placeholder: https://oxc.rs/docs/guide/usage/linter/rules/
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Suggested Change
+      description: >-
+        Write out the suggested change in configuration. If the rule or config is
+        already present, explain why it should be removed or changed. If it's not
+        present, explain why it should be added. And provide the final
+        configuration for the option.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Issues without the change
+      description: >-
+        Convince me why life is better with this change.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Severity of inaction
+      description: Convince me why not doing anything is bad.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Additional Context
+      description: Any other context that could be helpful.
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/config.yml

@@ -5,6 +5,12 @@ contact_links:
     about:
       If you can't get something to work the way you expect, open a question in
       the discussions.
+  - name: 🐂 Oxlint Rule Suggestion
+    url: https://github.com/epicweb-dev/config/discussions/new?category=oxlint-suggestion
+    about:
+      We appreciate you taking the time to improve `@epic-web/config` with your
+      ideas, but we use Discussions for config suggestions instead of the issues
+      tab.
   - name: 💬 Epic Web Discord Server
     url: https://kcd.im/discord
     about: Interact with other Epic Web developers

lint-rules/oxlint-test-utils.js

@@ -58,8 +58,8 @@ export async function writeOxlintFixture({
 		directory,
 		filePath,
 		typeAware,
-		async cleanup() {
-			await cleanupTemporaryDirectory(directory)
+		[Symbol.asyncDispose]() {
+			return cleanupTemporaryDirectory(directory)
 		},
 	}
 }

lint-rules/prefer-dispose-in-tests.test.js

@@ -5,6 +5,11 @@ import {
 	writeOxlintFixture,
 } from './oxlint-test-utils.js'
 
+async function cleanupFixture(fixture) {
+	// oxlint-disable-next-line epic-web/no-manual-dispose
+	await fixture[Symbol.asyncDispose]()
+}
+
 describe('epic-web/prefer-dispose-in-tests', () => {
 	it('reports lifecycle hooks that can move into a test body', async () => {
 		const fixture = await writeOxlintFixture({
@@ -24,7 +29,6 @@ describe('epic-web/prefer-dispose-in-tests', () => {
 				'epic-web/prefer-dispose-in-tests': 'warn',
 			},
 		})
-
 		try {
 			const result = await runOxlint(fixture)
 			expect(result.diagnostics).toHaveLength(1)
@@ -34,7 +38,7 @@ describe('epic-web/prefer-dispose-in-tests', () => {
 			})
 			expect(result.diagnostics[0].message).toContain('instead of beforeEach')
 		} finally {
-			await fixture.cleanup()
+		await cleanupFixture(fixture)
 		}
 	})
 
@@ -68,12 +72,11 @@ describe('epic-web/prefer-dispose-in-tests', () => {
 				'epic-web/prefer-dispose-in-tests': 'warn',
 			},
 		})
-
 		try {
 			const result = await runOxlint(fixture)
 			expect(result.diagnostics).toHaveLength(0)
 		} finally {
-			await fixture.cleanup()
+		await cleanupFixture(fixture)
 		}
 	})
 
@@ -98,13 +101,12 @@ describe('epic-web/prefer-dispose-in-tests', () => {
 				],
 			},
 		})
-
 		try {
 			const result = await runOxlint(fixture)
 			expect(result.diagnostics).toHaveLength(1)
 			expect(result.diagnostics[0].message).toContain('instead of beforeEach')
 		} finally {
-			await fixture.cleanup()
+		await cleanupFixture(fixture)
 		}
 	})
 })