Skip to content

Commit b5a7a51

Browse files
authored
fix(alerting): restructure pluggable dataformat gradle task (opensearch-project#2167)
Move integTestPluggableDataformat task and cluster config outside the integTest closure to avoid interfering with individual test targeting. Add failOnNoMatchingTests false so the task does not fail when triggered via finalizedBy with specific test filters. Signed-off-by: YashPradeep Gupte <yashprg@amazon.com>
1 parent f897cb5 commit b5a7a51

1 file changed

Lines changed: 29 additions & 34 deletions

File tree

alerting/build.gradle

Lines changed: 29 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -393,48 +393,43 @@ integTest {
393393
}
394394
}
395395

396-
task integTestPluggableDataformat(type: RestIntegTestTask) {
397-
description = "Runs integration tests with pluggable dataformat feature flag enabled"
398-
dependsOn bundlePlugin
399-
testClassesDirs = sourceSets.test.output.classesDirs
400-
classpath = sourceSets.test.runtimeClasspath
401-
402-
systemProperty 'tests.security.manager', 'false'
403-
systemProperty 'java.io.tmpdir', opensearch_tmp_dir.absolutePath
404-
systemProperty 'tests.pluggable_dataformat_enabled', 'true'
405-
406-
filter {
407-
includeTestsMatching "org.opensearch.alerting.transport.PluggableDataFormatMonitorBlockIT"
408-
}
396+
filter {
397+
excludeTestsMatching "org.opensearch.alerting.transport.PluggableDataFormatMonitorBlockIT"
409398
}
399+
}
410400

411-
testClusters.integTestPluggableDataformat {
412-
testDistribution = "ARCHIVE"
413-
systemProperty 'opensearch.experimental.feature.pluggable.dataformat.enabled', 'true'
401+
task integTestPluggableDataformat(type: RestIntegTestTask) {
402+
description = "Runs integration tests with pluggable dataformat feature flag enabled"
403+
dependsOn bundlePlugin
404+
testClassesDirs = sourceSets.test.output.classesDirs
405+
classpath = sourceSets.test.runtimeClasspath
414406

415-
// Include same plugins as main integTest cluster
416-
plugin(provider({ new RegularFile() { @Override File getAsFile() { return configurations.zipArchive.asFileTree.matching { include '**/opensearch-notifications-core*' }.singleFile } } }))
417-
plugin(provider({ new RegularFile() { @Override File getAsFile() { return configurations.zipArchive.asFileTree.matching { include '**/notifications*' }.singleFile } } }))
418-
plugin(provider({ new RegularFile() { @Override File getAsFile() { return configurations.zipArchive.asFileTree.matching { include '**/opensearch-job-scheduler*' }.singleFile } } }))
419-
plugin(provider({ new RegularFile() { @Override File getAsFile() { return configurations.zipArchive.asFileTree.matching { include '**/opensearch-sql-plugin*' }.singleFile } } }))
407+
systemProperty 'tests.security.manager', 'false'
408+
systemProperty 'java.io.tmpdir', opensearch_tmp_dir.absolutePath
409+
systemProperty 'tests.pluggable_dataformat_enabled', 'true'
420410

411+
filter {
412+
includeTestsMatching "org.opensearch.alerting.transport.PluggableDataFormatMonitorBlockIT"
413+
failOnNoMatchingTests false
421414
}
415+
}
422416

423-
// Install alerting plugin on the pluggable dataformat test cluster
424-
integTestPluggableDataformat.dependsOn(bundle)
425-
integTestPluggableDataformat.getClusters().forEach{c -> c.plugin(project.getObjects().fileProperty().value(bundle.getArchiveFile()))}
417+
testClusters.integTestPluggableDataformat {
418+
testDistribution = "ARCHIVE"
419+
systemProperty 'opensearch.experimental.feature.pluggable.dataformat.enabled', 'true'
426420

427-
// Exclude pluggable dataformat tests from the main integTest task
428-
integTest {
429-
filter {
430-
excludeTestsMatching "org.opensearch.alerting.transport.PluggableDataFormatMonitorBlockIT"
431-
}
432-
}
421+
plugin(provider({ new RegularFile() { @Override File getAsFile() { return configurations.zipArchive.asFileTree.matching { include '**/opensearch-notifications-core*' }.singleFile } } }))
422+
plugin(provider({ new RegularFile() { @Override File getAsFile() { return configurations.zipArchive.asFileTree.matching { include '**/notifications*' }.singleFile } } }))
423+
plugin(provider({ new RegularFile() { @Override File getAsFile() { return configurations.zipArchive.asFileTree.matching { include '**/opensearch-job-scheduler*' }.singleFile } } }))
424+
plugin(provider({ new RegularFile() { @Override File getAsFile() { return configurations.zipArchive.asFileTree.matching { include '**/opensearch-sql-plugin*' }.singleFile } } }))
425+
}
433426

434-
check.dependsOn integTestPluggableDataformat
435-
if (!usingRemoteCluster) {
436-
integTest.finalizedBy integTestPluggableDataformat
437-
}
427+
integTestPluggableDataformat.dependsOn(bundle)
428+
integTestPluggableDataformat.getClusters().forEach{c -> c.plugin(project.getObjects().fileProperty().value(bundle.getArchiveFile()))}
429+
430+
check.dependsOn integTestPluggableDataformat
431+
if (!usingRemoteCluster) {
432+
integTest.finalizedBy integTestPluggableDataformat
438433
}
439434

440435
task integTestRemote(type: RestIntegTestTask) {

0 commit comments

Comments
 (0)