Skip to content

DEVEX-1087: fix common bump failing when already up to date#120

Merged
pdodgen-revparts merged 1 commit into
mainfrom
DEVEX-1087-fix-common-bump
May 4, 2026
Merged

DEVEX-1087: fix common bump failing when already up to date#120
pdodgen-revparts merged 1 commit into
mainfrom
DEVEX-1087-fix-common-bump

Conversation

@pdodgen-revparts
Copy link
Copy Markdown
Contributor

Summary

  • Changes composer require to composer update in php-common-bump.yaml
  • composer update exits 0 when the package is already at the latest version
  • The commit step already handles the no-changes case (skips commit/push)
  • Eliminates false-failure red marks in CI when there's nothing to update

Test plan

  • Merge and verify next common bump on a repo that's already current shows green

composer require can fail when revolutionparts/common is already at
the latest version, causing the workflow to show as failed. composer
update handles the already-current case gracefully (exits 0), and the
commit step already skips when there are no changes.
@cursor
Copy link
Copy Markdown

cursor Bot commented May 4, 2026

PR Summary

Low Risk
Low risk workflow tweak: switches the bump step to composer update revolutionparts/common, reducing false CI failures without changing application/runtime code.

Overview
Prevents the PHP Common Bump GitHub Action from failing when revolutionparts/common is already at the latest version by changing the bump step from composer require to composer update.

This aligns with the existing “no changes to commit” logic so the workflow reports success when there’s nothing to update.

Reviewed by Cursor Bugbot for commit 00927e8. Bugbot is set up for automated code reviews on this repo. Configure here.

@pdodgen-revparts pdodgen-revparts marked this pull request as ready for review May 4, 2026 22:30
@pdodgen-revparts pdodgen-revparts requested a review from a team as a code owner May 4, 2026 22:30
@pdodgen-revparts pdodgen-revparts requested a review from aspencer May 4, 2026 22:30
@pdodgen-revparts pdodgen-revparts merged commit 58748db into main May 4, 2026
2 checks passed
@pdodgen-revparts pdodgen-revparts deleted the DEVEX-1087-fix-common-bump branch May 4, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant