Skip to content

Default embedded.provisionprofile doesn't used in signApplication #294

Description

@mahnunchik

Hello,

I've faced with different behavior in @electron/osx-sign v 1.0.5 vs electron-osx-sign v 0.5.0.

If options provisioningProfile and preEmbedProvisioningProfile are not specified (preEmbedProvisioningProfile is true by default) then default embedded.provisionprofile is used here

export async function preEmbedProvisioningProfile (opts: ValidatedSignOptions, profile: ProvisioningProfile | null) {
async function embedProvisioningProfile (profile: ProvisioningProfile) {
debugLog('Looking for existing provisioning profile...');
const embeddedFilePath = path.join(getAppContentsPath(opts), 'embedded.provisionprofile');
and successfully embedded here
await fs.copy(profile.filePath, embeddedFilePath);
after executing https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/sign.ts#L381C11-L381C38

But the following sign application action

await signApplication(validatedOpts, identityInUse);
doesn't use it here

osx-sign/src/sign.ts

Lines 226 to 228 in 06b32b5

provisioningProfile: opts.provisioningProfile
? await getProvisioningProfile(opts.provisioningProfile, opts.keychain)
: undefined
because validatedOpts.provisioningProfile is undefined as it is in original options.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions