Skip to content

Change filtering to treat base Contents directory the same as its subdirectories #247

Description

@rpatrick00

In working through a number of issues trying to get electron-builder to sign/notarize my application (which is packaged as a DMG installer), I ran into issues with text files in the Contents directory. I was hopeful when I found the -ignore option (surfaced in electron-builder as signIgnore). Unfortunately, what I found was:

  1. Files in the root MyApp.app/Contents directory cannot be filtered (i.e., the ignore() function is never called for them).
  2. Files in the subdirectories of MyApp.app/Contents are already being filtered (e.g., the ignore() function is never called for MyApp.app/Contents/tools/weblogic-deploy/LICENSE.txt but code signing is skipping the file automatically).

I don't understand the the rationale for this seemingly inconsistent behavior. You can see more details at electron-userland/electron-builder#6085.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions