[Streams] DLM data phases design review

[MichaelMarcialis]

@SoniaSanzV, @damian-polewski: As usual, this looks amazing. Well done! Per your request, I've reviewed the latest changes on main and have written up the following for my review notes. Please let me know if you have any questions. Thanks!

General

• Modal header font size (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Can we use 20px font size for all flyout headers used in this project for consistency and to better match the designs?
  

• Modal footer button sizes (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Can we make sure that all flyout footers in this project are using the button size="s" for consistency?
  

• Change unit order to ascending (Priority 3) DLM phases design review fixes - Priority 3 #277684
  The current unit selector option order is descending. Can we change to ascending?
  

Streams / Data lifecycle

• Page header retention badge (Priority 3, agreed with O11y design) DLM phases design review fixes - Priority 3 #277684
  Rather than using Retention: Disabled or Indefinite as text for the retention badge when there is no delete phase, could we instead just show an infinity symbol? Also, could we change the icon from clockCounter to clock?
  

• ILM policy selection missing conditional callout for non-time-series streams (Priority 1) — [Streams] DLM phases design review fixes - Priority 1 #277030
  It looks like the callout to explain that downsample steps will be excluded from non-time-series streams is missing when selecting an ILM policy from the edit lifecycle flyout.
  

• ILM policy downsampling callout in non-time-series stream phases (Priority 1) — [Streams] DLM phases design review fixes - Priority 1 #277030
  In the edit phases flyout, could we make a few changes to the callout to better align with the callout in the import flow? Remove the info icon. Change title to "Downsampling requires a time series stream" Change description to "As this stream is not a time series, downsampling steps from this ILM policy will be excluded."
  

• Import from another stream action missing (WIP) - [Streams] Create Import from other stream Flyout #277131 [Streams] Create Import from other Stream flow #275948
  The action to import the data lifecycle settings from another stream doesn't appear to have been implemented. Was this moved or descoped from this project?
  

• Shouldn't be able to open edit lifecycle and edit data phase flyouts simultaneously (Priority 1) — [Streams] DLM phases design review fixes - Priority 1 #277030
  The user can currently open the data phase editor flyout and then open the data lifecycle flyout. This shouldn't be possible, as the data lifecycle flyout button should be disabled when editing data phases.
  

• Edit data phase and data lifecycle flyouts should be the same width (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Is it possible to change it so that they are both 400px wide?

• Read-only checkbox hiding when downsampling active in ILM phases (Priority 3) DLM phases design review fixes - Priority 3 #277684
  Rather than hiding the "read-only" checkbox altogether when "downsampling" is checked, can we instead continue to show the "read-only" checkbox but in a disabled and checked state (with a tooltip explaining why)? Something like: "Read-only access is required for downsampling."
  

• Clicking "Apply" on edit data phase flyouts with no changes shouldn't trigger confirmation modal (Priority 1) — [Streams] DLM phases design review fixes - Priority 1 #277030
  For ILM-based streams, clicking on the "Apply" button when no changes have been made triggers the the confirmation modal that allows users to save as a new policy. This is not necessary in situations when there are no configuration changes detected. Can we omit in this particular case?
  

• ILM policy selectable scroll fade effect (Priority 2) [Streams & Index Management] Migrate RetentionSelector to EUI selector #277642
  The selectable component typically has a gradient fade effect that is visible when scrolling the selectable list. This appears to be absent in the edit data lifecycle flyout when selecting an ILM policy. Would it be possible to restore/add?
  

• Inspect ILM policy chevron alignment (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Possible to align the ILM policy accordion chevrons to the right to better match the designs?
  

• ILM inspect JSON code block scrolling (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Can we use the default pre-wrap style here so there is no horizontal scrolling? Can we also remove the right margin and adjust the right padding so that the scroll bar is aligned to the right of the copy and full-screen buttons?
  

• Change copy for stream in confirmation modal (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  The current stream is not included in the count and the list so the message and the number displayed is missleading. We must change the copy to "(...) is currently used in other X streams"
  

• Reduce lifecycle segment container horizontal padding (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Currently, the lifecycle segment container has a total of 6px horizontal padding (3 elements with 2px padding). Can we reduce to a total of 4px to be consistent with the vertical padding?
  

• Ingestion histogram legend font size (Priority 3) DLM phases design review fixes - Priority 3 #277684
  Are we using the standard Elastic charts legends here? The font size for the header and legend items appear slightly larger than they do in the designs. Can we change both to 12px?

• Enable failure store subtext size and alignment (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Can we adjust the size of the enable failure store subtext to be 12px and aligned with the text that precedes it?
  

• Failure store disabled panel (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Please change the failure store disabled panel title and description to be 14px. Also change the "Enable failure store" button to be size="s". Doing so will better match the designs.
  

Index management / Index and component templates

• Phase subtext font size (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Can we change the phase subtext font size to 12px to better match the designs?
  

• Disabled phase text color (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  For disabled phases, all text within the card should be euiTheme.colors.disabledText. This includes the text in the "Required" badge. This does not include the text in the "Enterprise required" or "Default repository required" badges.
  

Index management / Data streams

• Inspect flyout content spacing (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Can we adjust the content spacing for this flyout's content so that there is only 24px of space below the announcement banner and 16px of space between each group in the description list?
  

• Data phases header font size and margin (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Can we change the data phases header text to 12px and reduce the space under it to 4px?
  

• Allow line breaks for data phase titles and badges (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  To avoid awkward looking situations like this, can we allow the badge to break a line?
  

• Avoid flyout stacking behavior (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  Rather than stacking the data stream inspect and edit flyouts, can we automatically close the inspect flyout when the edit flyout gets opened? Or do ya'll think it's problematic to not return to the inspect flyout after completing your edits?
  Agreement leave at it is but unmount the summary flyout when the edit one is open. Mount it again if the user clicks Cancel/Back.
  

• Frozen phase snapshot font size and color (Priority 2) [Streams & Index Management] DLM phases design review fixes - Priority 2 #277652
  The text under "searchable snapshot" should be 12px. Also, the text color and tooltip icon color should be the default EUI text color.
  

[infra-vault-gh-plugin-prod]

Pinging @elastic/kibana-management (Team:Kibana Management)

[MichaelMarcialis]

Page header retention badge (Under discussion)
Rather than using Retention: Disabled or Indefinite as text for the retention badge when there is no delete phase, could we instead just show an infinity symbol? Also, could we change the icon from clockCounter to clock?

@patpascal: Regarding this review comment, would it be OK with you and your team if we were to make the above change in the page header badge, the streams table page, and anywhere else we're referring to Retention: Disabled or Indefinite? I've always felt they are both a bit of a misnomer as data is always being retained (so retention is technically not something that can be disabled) and "indefinite" feels more like an unknown period, when in fact we know that it is retained forever.

[patpascal]

Sounds good!