Skip to content

test(web): two test-ui specs are CI-fragile (All Chats no-results message; raw ws-probe cold-start) #275

Description

@edspencer

Surfaced by wiring @herdctl/web's test:ui Playwright suite into CI (PR #274). 26/28 pass reliably; two are environment-fragile:

  1. 07-sessions-and-errors.spec.ts "no-results state for an impossible query" — asserts the top-level No matching sessions (AllChatsPage NoSearchResults). On a dev machine with many session groups, an impossible query filters them all out → top-level message. In CI with a single seeded group, the filter renders the per-group No sessions match your search (DirectoryGroup) instead. Worked around by accepting either message; the underlying inconsistency (top-level vs per-group no-results) could be unified.

  2. 00-ws-probe.spec.ts raw browser ping→pong — times out consistently in CI (even at 30s) on the freshly-booted harness server, while every higher-level WS test (chat stream/resume) passes. Looks like a cold-start race specific to the raw probe. Skipped in CI for now (test.skip(!!process.env.CI, …)); real WS coverage is retained via the chat journeys. Worth a proper fix (retry the probe connection / wait for the WS upgrade handler).

Both are test-robustness issues, not product defects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions