Skip to content

summary #4

Description

@darcboykin1

Criteria 1: HTML Structure

  • Score Level: 4
  • Comment(s): Immaculate HTML structure. Your document is well formatted. The indentations clearly mark the beginnings and ending of the different sections. One thing that I would recommend you consider adding in the future is comments, marking where certain sections begin and end. It'll help the document be more readable than it already is.

Criteria 2: Visual Layout for Both Desktop and Mobile Sizes

  • Score Level: 2
  • Comment(s): Your desktop size is very close to the design spec. It should be perfect if you address what I mentioned in the previous issues in regards to sizing the containers. Your mobile layout unfortunately does not meet the expectations provided in the spec. I'm referring specifically to your .cta-box and .main-box sections, which are constrained against the side of the screen when it is shrunken down to the mobile size that your declared in your CSS:

Screen Shot 2019-04-30 at 11 58 17 PM

My advice on fixing this would be to start by increasing the width of those containers to 100% when the screen is 480px wide.

Criteria 3: Responsive Design (Media Queries, Responsive Units, etc.)

  • Score Level: 4
  • Comment(s): Your syntax and conciseness with the responsive design portion of your CSS is great. Good job!

Criteria 4: Visual Design and Accessibility (Color Palette, Typography, Transitions, etc.)

  • Score Level: 2
  • Comment(s): I see that you discovered how to create gradients in CSS, which is not something that many beginners know how to do. That in and of itself is impressive. However, your use of it here is kind of excessive. You used gradients wherever you could at the expense of establishing any sort of color palette or scheme. Things like this, while technically impressive, can negatively impact the professional impression of an otherwise well put together site. As for your typography, I see that you defined all of your fonts in your stylesheet, which is fine, but next time be sure to define your fonts at the top of your CSS, so that fonts will be first to load, and any elements that need them will have an easier time accessing them.

Overall Score: 12/16

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions