From d928df74d218d11f1a6328ca0760e4c259d86369 Mon Sep 17 00:00:00 2001 From: edithatogo <15080672+edithatogo@users.noreply.github.com> Date: Sat, 1 Aug 2026 04:58:02 +0000 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Optimize=20public=20holdout=20valid?= =?UTF-8?q?ation=20comparison=20recalculation?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- public/diff.txt | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 public/diff.txt diff --git a/public/diff.txt b/public/diff.txt new file mode 100644 index 0000000..bcec9e6 --- /dev/null +++ b/public/diff.txt @@ -0,0 +1,24 @@ +diff --git a/models/primarycare_model/calibration/public_holdout_validation.py b/models/primarycare_model/calibration/public_holdout_validation.py +index bc09e8a..7cea9bb 100644 +--- a/models/primarycare_model/calibration/public_holdout_validation.py ++++ b/models/primarycare_model/calibration/public_holdout_validation.py +@@ -316,9 +316,9 @@ def _ascii_safe(value: str) -> str: + return normalized.encode("ascii", errors="ignore").decode("ascii") + + +-def holdout_gate_blockers(gate_id: str) -> tuple[str, ...]: ++def holdout_gate_blockers(gate_id: str, comparisons: tuple[PublicHoldoutComparison, ...] | None = None) -> tuple[str, ...]: + blockers = [] +- for comparison in build_public_holdout_comparisons(): ++ for comparison in (comparisons if comparisons is not None else build_public_holdout_comparisons()): + if comparison.gate_id != gate_id or comparison.status == "passed": + continue + failed_groups = ", ".join(_ascii_safe(group) for group in comparison.failing_groups[:5]) +@@ -362,7 +362,7 @@ def main(argv: list[str] | None = None) -> int: + ) + + if args.require_pass and any(comparison.status != "passed" for comparison in comparisons): +- print("\n".join(holdout_gate_blockers("CAL-G-003") + holdout_gate_blockers("CAL-G-004")), file=sys.stderr) ++ print("\n".join(holdout_gate_blockers("CAL-G-003", comparisons=comparisons) + holdout_gate_blockers("CAL-G-004", comparisons=comparisons)), file=sys.stderr) + return 1 + return 0