Confusing naming of `GroupByParam`

[mpvginde]

In MatchingFieldsFilter the GroupByParam class is used to group all variables needed for the transformation.

However, the naming of the class would suggest the opposite, that you give it a parameter and groups all the data for this parameter(s).

I think a name like GroupParam would be a better fit as it clearly marks that you group the parameters provided.

Regards,
Michiel

[github-actions]

This issue has been marked as inactive due to inactivity. It will be closed if no further activity occurs in the next 10 days.

[aaron-hopkinson]

I am planning to change the way that the matching/grouping is done at some point in the (hopefully near) future. If anyone desperately wants to rename the class, I'd be happy to accept the change, but maybe we can tackle this when the maching/grouping behaviour is refactored in some future work.