JDialog override dispose() causes hang

[igarshep]

Once again, I bring you JDialog issues:

public class Test extends JDialog {

public Test() {
    super(new JFrame());
    final JButton btnNewButton = new JButton("New button");
    btnNewButton.addActionListener(e -> {
        dispose();
    });
    getContentPane().add(btnNewButton, BorderLayout.SOUTH);
    setVisible(true);
}

@Override
public final void dispose() {
    super.dispose();
}
}

If you remove the override method, it works. If you include, it hangs.

[ptziegler]

Sorry for the late response. I tried our your example but I can't reproduce this problem. Are there any additional steps I'm missing? Can your perhaps investigate with a profiler where WindowBuilder is stuck, exactly?

output.webm

[igarshep]

Sorry for my late reply here as well. I just tried it again and mine still hangs, no additional setup needed that I'm aware of.

Seems it gets stuck in some evaluate invoke method.

I'm not sure how to send you a sample output, seems .nps files aren't supported here.

[igarshep]

dispose.nps.zip
how about a zip of it ;)

[igarshep]

or maybe this is what you're looking for?
disposes.csv

[ptziegler]

Thanks! The profiler snapshot is already enough to give me a general idea of what's going on.

WindowBuilder is most likely getting stuck while executing the call to super.dispose(), i.e. while executing Java-internal code.

As for the reasons, I can only speculate, but I believe that this is a deadlock caused by both the SWT UI thread and the Swing UI thread trying to acquire the same lock.

I would assume that this problem not only shows up with the JDialog but also the JFrame. More so, I would also assume that this is problem is not limited to WindowBuilder but a general problem when mixing SWT and Swing, for example when doing something like this (though perhaps with some additional tweaks):

public class Snippet {
	public static void main(String[] args) {
		Shell shell = new Shell();
		Display display = shell.getDisplay();

		shell.setSize(500, 500);
		shell.setText("SWT Shell");
		shell.open();
		display.asyncExec(() -> {
			JFrame frame = new JFrame();
			frame.setSize(500, 500);
			frame.setTitle("Swing JFrame");
			frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
			frame.setVisible(true);
			// ...
			frame.dispose();
		});

		while (!shell.isDisposed()) {
			display.readAndDispatch();
		}
	}
}

Given that this doesn't happen on Windows or Linux (which is notorious for locking the UI thread), I'm leaning towards calling this an issue within the JRE. And given that I don't have access to a Mac, I won't really be able to further investigate this problem.

Meaning that in the current state, your best chances to get this fixed is by investigating this issue yourself and if-possible providing a fix.