From 80af01dbf71ba59bef5d83d250d69d636fa01a88 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Sun, 9 Aug 2026 10:13:22 +0200 Subject: [PATCH] Remove dead NLS message constants and an orphaned key Messages.SpyProcessor_category and Messages.ModelImportPage1_Import1 are declared but have no entry in their messages.properties and are read nowhere, so NLS.initializeMessages logs a "NLS missing message" warning for each of them on class initialization. The key XmiTab_TypeTextToSearch in the tabs messages.properties has no matching field in the sibling Messages class. XmiTab imports org.eclipse.e4.tools.emf.ui.internal.Messages instead and reads the value through its injected instance field, so the entry is never loaded. --- .../emf/ui/internal/common/component/tabs/messages.properties | 3 +-- .../src/org/eclipse/e4/tools/emf/ui/internal/imp/Messages.java | 1 - .../src/org/eclipse/pde/spy/core/Messages.java | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/tabs/messages.properties b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/tabs/messages.properties index a68721386c8..7eb6c39833c 100644 --- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/tabs/messages.properties +++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/tabs/messages.properties @@ -3,5 +3,4 @@ TitleAreaFilterDialogWithEmptyOptions_emptyValueDescription=An empty value is de TitleAreaFilterDialogWithEmptyOptions_excludeEmptyValues=Exclude Empty Values TitleAreaFilterDialogWithEmptyOptions_includeEmptyValues=Include Empty Values TitleAreaFilterDialogWithEmptyOptions_onlyEmptyValues=Only Empty Values -EmfUtil_ex_attribute_not_found=Attribute not found -XmiTab_TypeTextToSearch=Type text to search \ No newline at end of file +EmfUtil_ex_attribute_not_found=Attribute not found \ No newline at end of file diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/imp/Messages.java b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/imp/Messages.java index 06bed42cc6a..443d4c4e505 100644 --- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/imp/Messages.java +++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/imp/Messages.java @@ -8,7 +8,6 @@ public class Messages extends NLS { public static String ModelImportPage1_Description; public static String ModelImportPage1_Go; public static String ModelImportPage1_Import; - public static String ModelImportPage1_Import1; public static String ModelImportPage1_SelectPlugInAndElementsToImport; public static String ModelImportPage1_ToImport; public static String ModelImportPage1_WizardPage; diff --git a/ui/org.eclipse.pde.spy.core/src/org/eclipse/pde/spy/core/Messages.java b/ui/org.eclipse.pde.spy.core/src/org/eclipse/pde/spy/core/Messages.java index b312a420778..cce9f83d6d8 100644 --- a/ui/org.eclipse.pde.spy.core/src/org/eclipse/pde/spy/core/Messages.java +++ b/ui/org.eclipse.pde.spy.core/src/org/eclipse/pde/spy/core/Messages.java @@ -5,7 +5,6 @@ public class Messages extends NLS { private static final String BUNDLE_NAME = Messages.class.getPackageName() + ".messages"; //$NON-NLS-1$ public static String SpyHandler_Open; - public static String SpyProcessor_category; static { // initialize resource bundle NLS.initializeMessages(BUNDLE_NAME, Messages.class);