textDocument/callHierarchy/outgoingCalls not detecting method via method reference

[saideepakb]

When I execute textDocument/callHierarchy/outgoingCalls on the following method which has a method reference :: style invocation, it does not detect it:

public void testCollections() {
    List<String> list = List.of("A");
    list.stream()
            .map(testProjectService::addItem) <-- THIS
            .toList();
}

Call Hierarchy Output:

0 = {CallHierarchyOutgoingCall@6385} "CallHierarchyOutgoingCall [
  to = CallHierarchyItem [
    name = "of(E) <E> : List<E>"
    detail = "java.util.List"
    kind = Method
    tags = null
    uri = "jdt://contents/java.base/java.util/List.class?=test-project/%5C/Library%5C/Java%5C/JavaVirtualMachines%5C/jdk-21.0.2.jdk%5C/Contents%5C/Home%5C/lib%5C/jrt-fs.jar%60java.base=/javadoc_location=/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/21%5C/docs%5C/api%5C/=/=/maven.pomderived=/true=/%3Cjava.util(List.class"
    range = Range [
      start = Position [
        line = 923
        character = 4
      ]
      end = Position [
        line = 937
        character = 5
      ]
    ]
    selectionRange = Range [
      start = Position [
        line = 935
        character = 23
      ]
      end = Position [
        line = 935
        character = 25
      ]
    ]
    data = null
  ]
  fromRanges = ArrayList (
    Range [
      start = Position [
        line = 36
        character = 28
      ]
      end = Position [
  "
1 = {CallHierarchyOutgoingCall@6386} "CallHierarchyOutgoingCall [
  to = CallHierarchyItem [
    name = "stream() : Stream<E>"
    detail = "java.util.Collection"
    kind = Method
    tags = null
    uri = "jdt://contents/java.base/java.util/Collection.class?=test-project/%5C/Library%5C/Java%5C/JavaVirtualMachines%5C/jdk-21.0.2.jdk%5C/Contents%5C/Home%5C/lib%5C/jrt-fs.jar%60java.base=/javadoc_location=/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/21%5C/docs%5C/api%5C/=/=/maven.pomderived=/true=/%3Cjava.util(Collection.class"
    range = Range [
      start = Position [
        line = 733
        character = 4
      ]
      end = Position [
        line = 750
        character = 5
      ]
    ]
    selectionRange = Range [
      start = Position [
        line = 748
        character = 22
      ]
      end = Position [
        line = 748
        character = 28
      ]
    ]
    data = null
  ]
  fromRanges = ArrayList (
    Range [
      start = Position [
        line = 37
        character = 8
      ]
      e"
2 = {CallHierarchyOutgoingCall@6387} "CallHierarchyOutgoingCall [
  to = CallHierarchyItem [
    name = "map(Function<? super T, ? extends R>) <R> : Stream<R>"
    detail = "java.util.stream.Stream"
    kind = Method
    tags = null
    uri = "jdt://contents/java.base/java.util.stream/Stream.class?=test-project/%5C/Library%5C/Java%5C/JavaVirtualMachines%5C/jdk-21.0.2.jdk%5C/Contents%5C/Home%5C/lib%5C/jrt-fs.jar%60java.base=/javadoc_location=/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/21%5C/docs%5C/api%5C/=/=/maven.pomderived=/true=/%3Cjava.util.stream(Stream.class"
    range = Range [
      start = Position [
        line = 180
        character = 4
      ]
      end = Position [
        line = 193
        character = 63
      ]
    ]
    selectionRange = Range [
      start = Position [
        line = 193
        character = 18
      ]
      end = Position [
        line = 193
        character = 21
      ]
    ]
    data = null
  ]
  fromRanges = ArrayList (
    Range [
      start = Position [
        line"
3 = {CallHierarchyOutgoingCall@6388} "CallHierarchyOutgoingCall [
  to = CallHierarchyItem [
    name = "toList() : List<T>"
    detail = "java.util.stream.Stream"
    kind = Method
    tags = null
    uri = "jdt://contents/java.base/java.util.stream/Stream.class?=test-project/%5C/Library%5C/Java%5C/JavaVirtualMachines%5C/jdk-21.0.2.jdk%5C/Contents%5C/Home%5C/lib%5C/jrt-fs.jar%60java.base=/javadoc_location=/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/21%5C/docs%5C/api%5C/=/=/maven.pomderived=/true=/%3Cjava.util.stream(Stream.class"
    range = Range [
      start = Position [
        line = 1166
        character = 4
      ]
      end = Position [
        line = 1198
        character = 5
      ]
    ]
    selectionRange = Range [
      start = Position [
        line = 1196
        character = 20
      ]
      end = Position [
        line = 1196
        character = 26
      ]
    ]
    data = null
  ]
  fromRanges = ArrayList (
    Range [
      start = Position [
        line = 37
        character = 8
    "

When I change the method reference to a lambda, I see the method invocation in the response from callHierarchy.

public void testCollections() {
    List<String> list = List.of("A");
    list.stream()
            .map(item -> testProjectService.addItem(item))  <-- THIS IS NOW USING A LAMBDA
            .toList();
}
0 = {CallHierarchyOutgoingCall@6358} "CallHierarchyOutgoingCall [
...
...
...
4 = {CallHierarchyOutgoingCall@6362} "CallHierarchyOutgoingCall [
  to = CallHierarchyItem [
    name = "addItem(String) : String"
    detail = "com.example.TestProjectService"
    kind = Method
    tags = null
    uri = "file:///Users/deepak/java-monorepo/test-project/src/main/java/com/example/TestProjectService.java"
    range = Range [
      start = Position [
        line = 7
        character = 4
      ]
      end = Position [
        line = 7
        character = 32
      ]
    ]
    selectionRange = Range [
      start = Position [
        line = 7
        character = 11
      ]
      end = Position [
        line = 7
        character = 18
      ]
    ]
    data = null
  ]
  fromRanges = ArrayList (
    Range [
      start = Position [
        line = 38
        character = 29
      ]
      end = Position [
        line = 38
        character = 61
      ]
    ]
  )
]"

Did I miss something that is causing this to happen?

Running on MacOS Ventura 13.3
JDT LS Version: 1.44.0
Java version: jdk-21.0.2
org.eclipse.lsp4j Java client version (via maven): 0.24.0

[saideepakb]

I'm able to reproduce this in VS Code as well by right clicking on method -> Peek -> Peek Call Hierarchy -> Click on the telephone icon on the top right corner of the pop-up (next to the close button) to see the outgoing calls.

I can see it for the lambda version of this method:

    public void doSomething() {
        List<String> a = new ArrayList<>();
        a.forEach(x -> gatewayEndpoint(x));;
    }

But not when I change it to a method reference:

    public void doSomething() {
        List<String> a = new ArrayList<>();
        a.forEach(this::gatewayEndpoint);;
    }

VS Code version: Version: 1.97.2 (Universal)
vscode-java extension version: 1.39.0

[snjeza]

@saideepakb Could you attach a project example reproducing the error?

[saideepakb]

@snjeza Here is the project: https://github.com/saideepakb/simple-java-maven-app

Specifically the main method at https://github.com/saideepakb/simple-java-maven-app/blob/master/src/main/java/com/mycompany/app/App.java#L12

[snjeza]

This is an upstream jdt.ui issue.
@saideepakb Could you create a new issue on https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/new ?

[rgrunber]

Seems like there's a PR to fix for this upstream. Once the development branch is re-opened, it should probably make it's way in, and it'll be adopted.

[jjohnstn]

Closed as fixed by: eclipse-jdt/eclipse.jdt.ui#2035