Outgoing call hierarchy for methods in classes in a jar with attached source doesn't work since 4.40

[datho7561]

Setup to test:

1. Create an Eclipse Java project
2. Add a jar onto the modulepath as a dependency (I did https://github.com/stleary/JSON-java) along with its sourcepath
3. Open up a class from the dependency and navigate to a method that has method invocations in its body (I created an instance of JSONStringer and called stringer.value(null), then Ctrl+Clicked on value)
4. Right click on the method name in the method declaration
5. Open Call Hierarchy
6. Switch to "Show Callee Hierarchy"

Expected: there is a list of all method calls in the method body
Actual: there are zero method calls listed

At some point during 4.40 ibuilds this was working as expected, but after updating to the latest artifacts, it no longer works.

[iloveeclipse]

Could you provide self contained Eclipse project or bisect to the commit?

[datho7561]

Here's a self-contained Eclipse project: cardboard-utils.zip

[datho7561]

I'll try and find the commit too

[iloveeclipse]

Btw, regarding bisect: I assume the bug in jdt.core, not in ui, or why is this bug reported in ui?

[datho7561]

4197f17

[datho7561]

On line 311, JavaCore.isJavaLikeFileName(typeRoot.getElementName()) as added, but .class isn't treated as a Java-like file name by that method I think.

I also noticed eclipse-jdtls/eclipse.jdt.ls#3772, maybe that'll fix the failing test case that caused me to begin this investigation.

[jjohnstn]

On line 311, JavaCore.isJavaLikeFileName(typeRoot.getElementName()) as added, but .class isn't treated as a Java-like file name by that method I think.

I also noticed eclipse-jdtls/eclipse.jdt.ls#3772, maybe that'll fix the failing test case that caused me to begin this investigation.

You are correct. I believe that the line should be:

            if (typeRoot != null && typeRoot.exists() && typeRoot.getBuffer() != null
                    && (typeRoot instanceof IClassFile || JavaCore.isJavaLikeFileName(typeRoot.getElementName()))) {

It is possible that the new jdt.ls logic will accomodate the class file, but there still is a problem with regular java logic not finding the callees.