Invalid URL causes stacktrace to be written

[sschellh]

Describe the bug
Mapping of a String to URL results in StackTrace to be written, in case the URL is malformed.

To Reproduce
public static record MyObject(URL myUrl) { }

@Test
void testInvalidUrl() {
    var jsonString = """
            {"myUrl":"This-Url-Is-Not-Valid"}
            """;
    var result = jsonb.fromJson(jsonString, MyObject.class);
    assertNull(result.myUrl());
    
    // Expected: No StackTrace written, but following StackTrace is written
    /*
    java.net.MalformedURLException: no protocol: This-Url-Is-Not-Valid
    at java.base/java.net.URL.<init>(URL.java:735)
    at java.base/java.net.URL.<init>(URL.java:630)
    at java.base/java.net.URL.<init>(URL.java:566)
    at org.eclipse.yasson.internal.deserializer.types.UrlDeserializer.deserializeStringValue(UrlDeserializer.java:34)
    at org.eclipse.yasson.internal.deserializer.types.TypeDeserializer.deserialize(TypeDeserializer.java:37)
    at org.eclipse.yasson.internal.deserializer.ValueExtractor.deserialize(ValueExtractor.java:47)
    at org.eclipse.yasson.internal.deserializer.ValueExtractor.deserialize(ValueExtractor.java:24)
    at org.eclipse.yasson.internal.deserializer.PositionChecker.deserialize(PositionChecker.java:85)
    */
}

@Test
void testValidUrl() {
    var jsonString = """
            {"myUrl":"https://example.com"}
            """;
    var result = jsonb.fromJson(jsonString, MyObject.class);
    assertNotNull(result.myUrl());
}

Expected behavior
There is no stack trace written in all cases.
A debug log statement might be created, if debug log is enabled.

System information:

• Yasson Version: 3.0.4

Additional context
Issue in org.eclipse.yasson.internal.deserializer.types.UrlDeserializer

[KyleAure]

I do not understand how this is a bug.

Your JSON included a value which needed to be mapped to a URL. When yasson attempted to do the mapping we found that the String did not represent a URL because it was malformed. Therefore, we threw an error.

This is required by the specification see: https://jakarta.ee/specifications/jsonb/3.0/jakarta-jsonb-spec-3.0#java-net-url-uri

Deserialization of a JSON value into java.net.URL or URI instance MUST follow the conversion process defined in the javadoc specification for the constructor of java.net.URL or URI with java.lang.String argument.

And it is required for us to throw an error, see: https://jakarta.ee/specifications/jsonb/3.0/jakarta-jsonb-spec-3.0#errors

Implementations SHOULD also report an error during a deserialization operation, if it is not possible to represent a JSON document value with the expected Java type.

The solution would be to modify your record to use a String instead of URL if you expect non-URL strings to be in that field.

public static record MyObject(String myUrl) { }

[KyleAure]

Oh I see what the issue is!

yasson/src/main/java/org/eclipse/yasson/internal/deserializer/types/UrlDeserializer.java

Lines 30 to 39 in 4151774

	@Override
	Object deserializeStringValue(String value, DeserializationContextImpl context, Type rType) {
	URL url = null;
	try {
	url = new URL(value);
	} catch (MalformedURLException e) {
	e.printStackTrace();
	}
	return url;
	}

Instead of throwing an error, we just print the error.
So instead of failing de-serialization, we just return null.

I do not agree with that behavior either.
I searched through the TCK and did not find a negative test for URL where it is rejected.
This will need to be something we look at for EE 12

[sschellh]

Thanks for looking into this.
I personally don't like that the stack trace is written, because this polutes the log files.