From 062f6d1c8d0116998306bf9ed7f97489cd6014ec Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 6 Oct 2022 06:07:35 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- wdl/rna-seq/scripts/align.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/wdl/rna-seq/scripts/align.py b/wdl/rna-seq/scripts/align.py index 83c71d2..89cb71a 100755 --- a/wdl/rna-seq/scripts/align.py +++ b/wdl/rna-seq/scripts/align.py @@ -249,7 +249,26 @@ def main(args): if merged_R2 and args.endedness == "paired": fastqs.append(merged_R2) with tarfile.open(args.index, "r:gz") as archive: - archive.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive) aligner = make_aligner( args.endedness, fastqs, args.ncpus, args.ramGB, args.indexdir )