From dd3ffc148ad7e975b3b22a8d1523c61dd53e14a7 Mon Sep 17 00:00:00 2001 From: Davis Vann Bennett Date: Wed, 3 Jun 2026 22:23:39 +0200 Subject: [PATCH 1/2] chore: remove tests for private tenuous zarr-python store methods --- .../test_store/test_icechunk_store.py | 48 ------------------- 1 file changed, 48 deletions(-) diff --git a/icechunk-python/tests/test_zarr/test_store/test_icechunk_store.py b/icechunk-python/tests/test_zarr/test_store/test_icechunk_store.py index 36945cef0..d63f00f28 100644 --- a/icechunk-python/tests/test_zarr/test_store/test_icechunk_store.py +++ b/icechunk-python/tests/test_zarr/test_store/test_icechunk_store.py @@ -544,51 +544,3 @@ async def test_getsize_raises(self, store: IcechunkStore) -> None: # TODO: This maybe should be a FileNotFoundError instead of an IcechunkError with pytest.raises(IcechunkError): await store.getsize("not-a-real-key") - - @pytest.mark.skipif( - zarr.__version__ < "3.1.6", reason="Store._get_bytes added in zarr 3.1.6" - ) - async def test_get_bytes(self, store: IcechunkStore) -> None: - # Override: icechunk validates metadata on zarr.json keys, - # so we must use valid zarr metadata instead of arbitrary bytes - data = DEFAULT_GROUP_METADATA - key = "zarr.json" - await self.set(store, key, self.buffer_cls.from_bytes(data)) - assert await store._get_bytes(key, prototype=default_buffer_prototype()) == data - with pytest.raises((FileNotFoundError, ValueError, IcechunkError)): - await store._get_bytes( - "nonexistent_key", prototype=default_buffer_prototype() - ) - - @pytest.mark.skipif( - zarr.__version__ < "3.1.6", reason="Store._get_bytes_sync added in zarr 3.1.6" - ) - def test_get_bytes_sync(self, store: IcechunkStore) -> None: - # Override: icechunk validates metadata on zarr.json keys - data = DEFAULT_GROUP_METADATA - key = "zarr.json" - sync(self.set(store, key, self.buffer_cls.from_bytes(data))) - assert store._get_bytes_sync(key, prototype=default_buffer_prototype()) == data - - @pytest.mark.skipif( - zarr.__version__ < "3.1.6", reason="Store._get_json added in zarr 3.1.6" - ) - async def test_get_json(self, store: IcechunkStore) -> None: - # Override: icechunk validates metadata on zarr.json keys, - # so we must use valid zarr metadata instead of arbitrary JSON - data = json.loads(DEFAULT_GROUP_METADATA) - data_bytes = DEFAULT_GROUP_METADATA - key = "zarr.json" - await self.set(store, key, self.buffer_cls.from_bytes(data_bytes)) - assert await store._get_json(key, prototype=default_buffer_prototype()) == data - - @pytest.mark.skipif( - zarr.__version__ < "3.1.6", reason="Store._get_json_sync added in zarr 3.1.6" - ) - def test_get_json_sync(self, store: IcechunkStore) -> None: - # Override: icechunk validates metadata on zarr.json keys - data = json.loads(DEFAULT_GROUP_METADATA) - data_bytes = DEFAULT_GROUP_METADATA - key = "zarr.json" - sync(self.set(store, key, self.buffer_cls.from_bytes(data_bytes))) - assert store._get_json_sync(key, prototype=default_buffer_prototype()) == data From 8c4061e7b13299236d85bd34760e5edb7d708851 Mon Sep 17 00:00:00 2001 From: Davis Vann Bennett Date: Wed, 3 Jun 2026 22:56:53 +0200 Subject: [PATCH 2/2] chore: lint --- .../tests/test_zarr/test_store/test_icechunk_store.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/icechunk-python/tests/test_zarr/test_store/test_icechunk_store.py b/icechunk-python/tests/test_zarr/test_store/test_icechunk_store.py index d63f00f28..189960dab 100644 --- a/icechunk-python/tests/test_zarr/test_store/test_icechunk_store.py +++ b/icechunk-python/tests/test_zarr/test_store/test_icechunk_store.py @@ -1,18 +1,16 @@ from __future__ import annotations -import json import pickle from pathlib import Path from typing import Any, TypeVar import pytest -import zarr from icechunk import IcechunkError, IcechunkStore, local_filesystem_storage from icechunk.repository import Repository from zarr.abc.store import OffsetByteRequest, RangeByteRequest, Store, SuffixByteRequest from zarr.core.buffer import Buffer, cpu, default_buffer_prototype -from zarr.core.sync import _collect_aiterator, collect_aiterator, sync +from zarr.core.sync import _collect_aiterator, collect_aiterator from zarr.testing.store import StoreTests from zarr.testing.utils import assert_bytes_equal