From a853d015b82b8c2ee20fab10a20a497695a11fe9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Dinis=20Ferreira?= Date: Sat, 30 May 2026 17:57:21 +0200 Subject: [PATCH] fix: null-safe fragment access in DefaultFragmentWithOverride.checkConfiguration defaultFragment and overrideFragment are documented as optionally null, and generate() and initialize() both access them null-safely (?.). checkConfiguration dereferenced them unconditionally, NPEing whenever either is null. Use ?. to match the rest of the class. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../ddk/xtext/generator/DefaultFragmentWithOverride.xtend | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/DefaultFragmentWithOverride.xtend b/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/DefaultFragmentWithOverride.xtend index e8d887e258..89a6e71a4c 100644 --- a/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/DefaultFragmentWithOverride.xtend +++ b/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/DefaultFragmentWithOverride.xtend @@ -46,8 +46,8 @@ class DefaultFragmentWithOverride extends AbstractXtextGeneratorFragment { } override checkConfiguration(Issues issues) { - overrideFragment.checkConfiguration(issues) - defaultFragment.checkConfiguration(issues) + overrideFragment?.checkConfiguration(issues) + defaultFragment?.checkConfiguration(issues) } }