From d072456a212481c607a0da58a12a418ba20a0584 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Dinis=20Ferreira?= <hello@joaof.eu>
Date: Sat, 30 May 2026 17:45:31 +0200
Subject: [PATCH] chore: enable the PMD UnnecessaryImport rule
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Re-enables the previously-excluded UnnecessaryImport rule. Blast radius is
zero: `mvn pmd:check` across the whole reactor reports 0 UnnecessaryImport
violations on current master. Generated code (src-gen, src-model, xtend-gen)
is already excluded from PMD via excludeRoots, so only hand-written src/ is
scanned. The "too many false positives after PMD 7" exclusion comment is
stale for the current codebase.

Catches unused imports in hand-written source going forward (nothing else in
CI does — checkstyle has no unused-import rule).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 ddk-configuration/pmd/ruleset.xml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ddk-configuration/pmd/ruleset.xml b/ddk-configuration/pmd/ruleset.xml
index 0032b26e3d..b9e34c7c74 100644
--- a/ddk-configuration/pmd/ruleset.xml
+++ b/ddk-configuration/pmd/ruleset.xml
@@ -120,7 +120,6 @@
     <exclude name="ShortVariable"/> <!--  not sensible -->
     <exclude name="TooManyStaticImports"/>
     <exclude name="UnnecessaryAnnotationValueElement"/>
-    <exclude name="UnnecessaryImport"/><!--Too many false positives after PMD 7 -->
     <exclude name="UnnecessaryModifier"/><!--Checkstyle-->
     <exclude name="UnnecessaryFullyQualifiedName"/>
     <exclude name="UnnecessaryLocalBeforeReturn"/>