From 092f3071bde7ec141388a2a2ef2267fae084ecf3 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 29 May 2026 14:01:33 +0000 Subject: [PATCH 1/2] chore(deps): bump pmd.version from 7.24.0 to 7.25.0 in /ddk-parent Bumps `pmd.version` from 7.24.0 to 7.25.0. Updates `net.sourceforge.pmd:pmd-core` from 7.24.0 to 7.25.0 - [Release notes](https://github.com/pmd/pmd/releases) - [Commits](https://github.com/pmd/pmd/compare/pmd_releases/7.24.0...pmd_releases/7.25.0) Updates `net.sourceforge.pmd:pmd-java` from 7.24.0 to 7.25.0 - [Release notes](https://github.com/pmd/pmd/releases) - [Commits](https://github.com/pmd/pmd/compare/pmd_releases/7.24.0...pmd_releases/7.25.0) --- updated-dependencies: - dependency-name: net.sourceforge.pmd:pmd-core dependency-version: 7.25.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: net.sourceforge.pmd:pmd-java dependency-version: 7.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- ddk-parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddk-parent/pom.xml b/ddk-parent/pom.xml index 491a7ab048..6ad1d91608 100644 --- a/ddk-parent/pom.xml +++ b/ddk-parent/pom.xml @@ -53,7 +53,7 @@ 4.9.8.3 4.9.8 3.28.0 - 7.24.0 + 7.25.0 5.0.3 2.43.0 From cf5fcb1670b523ab963767463eac36412896ff57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Dinis=20Ferreira?= Date: Fri, 29 May 2026 19:00:24 +0200 Subject: [PATCH 2/2] fix: adapt PMD ruleset to 7.25.0 rule rename + suppress OverridingThreadRun PMD 7.25.0 renamed JUnit5TestShouldBePackagePrivate to JUnitJupiterTestShouldBePackagePrivate. The category exclude referenced the old name, which silently stopped matching after the rename, so the rule reactivated and flagged every JUnit 5 test across the test bundles. Update the exclude to the new name to restore the intended suppression. 7.25.0 also fixed false negatives in OverridingThreadRun, which now correctly detects BuilderWatchdog overriding Thread.run(). BuilderWatchdog is intentionally a Thread subclass (named thread, start()/interrupt() lifecycle driven by MonitoredClusteringBuilderState), so suppress the rule at that single site rather than refactoring threading behaviour under a dependency bump. Verified with a full-reactor `mvn pmd:check`: BUILD SUCCESS. Co-Authored-By: Claude Opus 4.7 --- .../src/com/avaloq/tools/ddk/xtext/builder/BuilderWatchdog.java | 1 + ddk-configuration/pmd/ruleset.xml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/BuilderWatchdog.java b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/BuilderWatchdog.java index a263ce69cc..399587428e 100644 --- a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/BuilderWatchdog.java +++ b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/BuilderWatchdog.java @@ -29,6 +29,7 @@ * Watchdog that keeps track of sources processed during a build. When the builder fails to report progress for a period of time, a warning will be logged, * along with the stack traces for all threads of the running application. */ +@SuppressWarnings("PMD.OverridingThreadRun") // Intentionally a Thread subclass: named thread with start()/interrupt() lifecycle managed by MonitoredClusteringBuilderState. public class BuilderWatchdog extends Thread { private static final Logger LOGGER = LogManager.getLogger(BuilderWatchdog.class); diff --git a/ddk-configuration/pmd/ruleset.xml b/ddk-configuration/pmd/ruleset.xml index 0032b26e3d..fca513e06f 100644 --- a/ddk-configuration/pmd/ruleset.xml +++ b/ddk-configuration/pmd/ruleset.xml @@ -85,7 +85,7 @@ - +