diff --git a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/AbstractCheckTestCase.java b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/AbstractCheckTestCase.java index 877f97296a..63458ad54e 100644 --- a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/AbstractCheckTestCase.java +++ b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/AbstractCheckTestCase.java @@ -60,7 +60,7 @@ /** * An abstract test class for tests on Check models. Allows creating a project and adding files. */ -@SuppressWarnings({"PMD.SignatureDeclareThrowsException", "restriction"}) +@SuppressWarnings({"PMD.SignatureDeclareThrowsException", "restriction", "nls"}) public abstract class AbstractCheckTestCase extends TestCase { private static final int TWO_KILO_BYTES = 2048; protected static final Logger LOGGER = LogManager.getLogger(AbstractCheckTestCase.class); diff --git a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugAig1314.java b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugAig1314.java index 6aa9bd1f85..a1d4ea748b 100644 --- a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugAig1314.java +++ b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugAig1314.java @@ -41,6 +41,7 @@ */ @RunWith(XtextRunner.class) @InjectWith(CheckInjectorProvider.class) +@SuppressWarnings("nls") public class BugAig1314 { /** Constructor of super class is protected... */ diff --git a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugDsl27.java b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugDsl27.java index fc357d6b2d..c6ce548252 100644 --- a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugDsl27.java +++ b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugDsl27.java @@ -26,6 +26,7 @@ */ @InjectWith(CheckInjectorProvider.class) @RunWith(XtextRunner.class) +@SuppressWarnings("nls") public class BugDsl27 extends AbstractCheckGenerationTestCase { /** diff --git a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtilTest.java b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtilTest.java index af865e5af6..1e59ac3a23 100644 --- a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtilTest.java +++ b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtilTest.java @@ -28,6 +28,7 @@ @InjectWith(CheckUiInjectorProvider.class) @RunWith(XtextRunner.class) +@SuppressWarnings("nls") public class CheckJavaValidatorUtilTest extends TestCase { // assertion messages. diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/documentation/JavaDocCommentDocumentationProvider.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/documentation/JavaDocCommentDocumentationProvider.java index 03bc2e68ab..48934dc372 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/documentation/JavaDocCommentDocumentationProvider.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/documentation/JavaDocCommentDocumentationProvider.java @@ -25,6 +25,7 @@ /** * @author Christoph Kulla - Initial contribution and API */ +@SuppressWarnings("nls") public class JavaDocCommentDocumentationProvider implements IEObjectDocumentationProvider { // TODO refactor with MultilineCommentDocumentationProvider @@ -73,7 +74,7 @@ protected String getJavaDocComment(final INode node) { } if (node instanceof ILeafNode && node.getGrammarElement() instanceof TerminalRule && ruleName.equalsIgnoreCase(((TerminalRule) node.getGrammarElement()).getName())) { - String comment = ((ILeafNode) node).getText(); + String comment = node.getText(); if (comment.matches("(?s)" + startTag + ".*")) { return comment; } diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java index eb239cec12..f6c1c11ca6 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java @@ -45,6 +45,7 @@ /** * The Check compiler used for generating Java code from Check models. */ +@SuppressWarnings("nls") // CHECKSTYLE:CONSTANTS-OFF public class CheckCompiler extends XbaseCompiler { diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckGeneratorConstants.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckGeneratorConstants.java index 0b015c0932..b22c8eee0a 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckGeneratorConstants.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckGeneratorConstants.java @@ -13,6 +13,7 @@ /** * Generator constants. */ +@SuppressWarnings("nls") public final class CheckGeneratorConstants { public static final String CHECK_DOC_OUTPUT = "CHECK_DOC_OUTPUT"; diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckOutputConfigurationProvider.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckOutputConfigurationProvider.java index db10a5c898..5bf8f3dde4 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckOutputConfigurationProvider.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckOutputConfigurationProvider.java @@ -22,6 +22,7 @@ * * @see org.eclipse.xtext.generator.IFileSystemAccess */ +@SuppressWarnings("nls") public class CheckOutputConfigurationProvider extends OutputConfigurationProvider { public static final String DOCS_PATH = "docs/content"; diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckPropertiesGenerator.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckPropertiesGenerator.java index 0fb173cdd4..676e67d87f 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckPropertiesGenerator.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckPropertiesGenerator.java @@ -22,6 +22,7 @@ /** * Generates keys and values used by issue codes and check configurations. */ +@SuppressWarnings("nls") public final class CheckPropertiesGenerator { private CheckPropertiesGenerator() { diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/naming/CheckDeclarativeQualifiedNameProvider.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/naming/CheckDeclarativeQualifiedNameProvider.java index 24f5d17f93..97bdfd3014 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/naming/CheckDeclarativeQualifiedNameProvider.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/naming/CheckDeclarativeQualifiedNameProvider.java @@ -30,19 +30,19 @@ public class CheckDeclarativeQualifiedNameProvider extends XbaseQualifiedNamePro /** * Gets the qualified name for a {@link CheckCatalog Check Catalog}. - * + * * @param catalog * the check catalog * @return the fully qualified name */ QualifiedName qualifiedName(final CheckCatalog catalog) { - return converter.toQualifiedName(catalog.getPackageName() + "." + catalog.getName()); + return converter.toQualifiedName(catalog.getPackageName() + '.' + catalog.getName()); } /** * Creates a qualified name for a given Check instance. The first segment of the * qualified name corresponds to the parent catalog name. - * + * * @param check * the check * @return the qualified name @@ -50,7 +50,7 @@ QualifiedName qualifiedName(final CheckCatalog catalog) { QualifiedName qualifiedName(final Check check) { // name of check can be null while editing String name = check.getName(); - return qualifiedName(EcoreUtil2.getContainerOfType(check, CheckCatalog.class)).append(name != null ? name : "null"); + return qualifiedName(EcoreUtil2.getContainerOfType(check, CheckCatalog.class)).append(name != null ? name : "null"); //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CatalogFromExtensionPointScope.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CatalogFromExtensionPointScope.java index 305f5437d7..0087c8295e 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CatalogFromExtensionPointScope.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CatalogFromExtensionPointScope.java @@ -33,6 +33,7 @@ /** * Defines a scope scope for check catalogs located in the plugin registry. */ +@SuppressWarnings("nls") public class CatalogFromExtensionPointScope extends AbstractScope { private final IModelLocation locationData; diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CheckLinkingService.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CheckLinkingService.java index a533cb3e62..137c18bf52 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CheckLinkingService.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CheckLinkingService.java @@ -17,15 +17,16 @@ import org.eclipse.xtext.conversion.IValueConverterService; import org.eclipse.xtext.nodemodel.INode; -import com.avaloq.tools.ddk.xtext.linking.AbstractFastLinkingService; import com.avaloq.tools.ddk.check.check.CheckPackage; import com.avaloq.tools.ddk.check.services.CheckGrammarAccess; +import com.avaloq.tools.ddk.xtext.linking.AbstractFastLinkingService; import com.google.inject.Inject; /** * A linking service for the Check language. */ +@SuppressWarnings("nls") public class CheckLinkingService extends AbstractFastLinkingService { @Inject @@ -33,9 +34,6 @@ public class CheckLinkingService extends AbstractFastLinkingService { @Inject private CheckGrammarAccess grammarAccess; - /** - * {@inheritDoc} - */ @Override public List getLinkedObjects(final EObject context, final EReference ref, final INode node) { if (ref == CheckPackage.Literals.CHECK_CATALOG__GRAMMAR) { diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtil.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtil.java index d3d71d4477..d136dd1778 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtil.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtil.java @@ -26,6 +26,7 @@ * and the wizards. */ @Singleton +@SuppressWarnings("nls") public class CheckJavaValidatorUtil { /** Two dots in a row. */ diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/ClasspathBasedChecks.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/ClasspathBasedChecks.java index bdf33936bb..38d069fd2e 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/ClasspathBasedChecks.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/ClasspathBasedChecks.java @@ -31,6 +31,7 @@ * Largely inspired from org.eclipse.xtext.xtend2.validation.ClasspathBasedChecks. * TODO: This code should go in utility functions... */ +@SuppressWarnings("nls") public class ClasspathBasedChecks extends AbstractDeclarativeValidator { private static final String SLASH = "/"; @@ -44,7 +45,7 @@ public void register(final EValidatorRegistrar registrar) { /** * Verifies that a given catalog file has the same name as the name given in the model. * Also verifies that the given package exists and that the file is in that package. - * + * * @param catalog * a check catalog */ @@ -81,7 +82,7 @@ public void checkFileNamingConventions(final CheckCatalog catalog) { /** * Reports an invalid package error. - * + * * @param catalog * the catalog * @param givenPackageName diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/FormalParameterCheckBase.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/FormalParameterCheckBase.java index 521556fad9..6262c2dcb3 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/FormalParameterCheckBase.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/FormalParameterCheckBase.java @@ -34,7 +34,7 @@ public void register(final EValidatorRegistrar registrar) { /** * Validates that all XNumberLiterals in this expression, which occurs on the right-hand side of a formal parameter * declaration/definition, have indeed integral values. - * + * * @param value * to check * @param issueCode @@ -52,7 +52,7 @@ protected void checkRightHandSideHasOnlyIntegralNumbers(final XExpression value, try { Integer.decode(((XNumberLiteral) e).getValue()); } catch (NumberFormatException ex) { - error("Only integral values as numbers are allowed in check parameters", expr, null, issueCode); // TODO: NLS + error("Only integral values as numbers are allowed in check parameters", expr, null, issueCode); // TODO: NLS //$NON-NLS-1$ } } } diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/IssueCodes.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/IssueCodes.java index aa631cc3c6..4df374fed1 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/IssueCodes.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/IssueCodes.java @@ -13,6 +13,7 @@ /** * Issue codes used for the Check Java validator. */ +@SuppressWarnings("nls") public final class IssueCodes { private static final String ISSUE_CODE_PREFIX = "com.avaloq.tools.ddk.check.validation.IssueCodes."; diff --git a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/CheckContextTest.java b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/CheckContextTest.java index a63a7ea41e..6bb93ee4c3 100644 --- a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/CheckContextTest.java +++ b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/CheckContextTest.java @@ -20,6 +20,7 @@ /** * Provides some tests of the reflective {@link AbstractCheckContext} framework. */ +@SuppressWarnings("nls") public class CheckContextTest extends TestCase { public static final String ENABLED_ISSUE_CODE = "Enabled.Issue.Code"; diff --git a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/registry/CheckExtensionPointTests.java b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/registry/CheckExtensionPointTests.java index 8d01a80d39..892d66848e 100644 --- a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/registry/CheckExtensionPointTests.java +++ b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/registry/CheckExtensionPointTests.java @@ -27,6 +27,7 @@ /** * Provides some test cases for the Check extension point. */ +@SuppressWarnings("nls") public class CheckExtensionPointTests extends TestCase { private static final String DUMMY_EXTENSION_ID = "com.avaloq.tools.ddk.check.runtime.core.test"; diff --git a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/validation/CheckValidatorTest.java b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/validation/CheckValidatorTest.java index a91a3de534..ef03b79eef 100644 --- a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/validation/CheckValidatorTest.java +++ b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/validation/CheckValidatorTest.java @@ -23,6 +23,7 @@ /** * Performs some basic validation tests on the {@link AbstractCheckValidator}. */ +@SuppressWarnings("nls") public class CheckValidatorTest extends AbstractCheckValidator { /** * Represents the dummy language which is also registered in the plugin.xml. @@ -31,7 +32,7 @@ public class CheckValidatorTest extends AbstractCheckValidator { /** * Returns a dummy language ID. - * + * * @return the host language */ @Override @@ -41,7 +42,7 @@ protected String getHostLanguage() { /** * Tests that the dummy validator is found via the check validator extension point. - * + * * @see {@link com.avaloq.tools.ddk.check.extensionpoint.test.validation.DummyValidator} */ @Test diff --git a/com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/TestLanguageUiInjectorProvider.java b/com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/TestLanguageUiInjectorProvider.java index 2db5052664..5ccc7f0f05 100644 --- a/com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/TestLanguageUiInjectorProvider.java +++ b/com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/TestLanguageUiInjectorProvider.java @@ -11,6 +11,7 @@ public class TestLanguageUiInjectorProvider implements IInjectorProvider { @Override + @SuppressWarnings("nls") public Injector getInjector() { return com.avaloq.tools.ddk.check.ui.internal.TestLanguageActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.TestLanguage"); } diff --git a/com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/test/runtime/TestLanguageUiInjectorProvider.java b/com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/test/runtime/TestLanguageUiInjectorProvider.java index 1806da05fe..e13de96dea 100644 --- a/com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/test/runtime/TestLanguageUiInjectorProvider.java +++ b/com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/test/runtime/TestLanguageUiInjectorProvider.java @@ -12,7 +12,7 @@ public class TestLanguageUiInjectorProvider implements IInjectorProvider { @Override public Injector getInjector() { - return com.avaloq.tools.ddk.check.ui.internal.TestLanguageActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.TestLanguage"); + return com.avaloq.tools.ddk.check.ui.internal.TestLanguageActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.TestLanguage"); //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.check.test.runtime/src/com/avaloq/tools/ddk/check/validation/TestLanguageJavaValidator.java b/com.avaloq.tools.ddk.check.test.runtime/src/com/avaloq/tools/ddk/check/validation/TestLanguageJavaValidator.java index 6a3f124216..1797623b0c 100644 --- a/com.avaloq.tools.ddk.check.test.runtime/src/com/avaloq/tools/ddk/check/validation/TestLanguageJavaValidator.java +++ b/com.avaloq.tools.ddk.check.test.runtime/src/com/avaloq/tools/ddk/check/validation/TestLanguageJavaValidator.java @@ -21,6 +21,7 @@ /** * The Class TestLanguageJavaValidator. */ +@SuppressWarnings("nls") public class TestLanguageJavaValidator extends AbstractTestLanguageJavaValidator { @Check diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/CheckUiInjectorProvider.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/CheckUiInjectorProvider.java index 16fda6ea56..ceb8f59aa4 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/CheckUiInjectorProvider.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/CheckUiInjectorProvider.java @@ -15,7 +15,7 @@ public class CheckUiInjectorProvider implements IInjectorProvider { @Override public Injector getInjector() { - return com.avaloq.tools.ddk.check.ui.internal.CheckActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.Check"); + return com.avaloq.tools.ddk.check.ui.internal.CheckActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.Check"); //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckCatalogWizardTest.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckCatalogWizardTest.java index 06fef0015c..5f2a92d35a 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckCatalogWizardTest.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckCatalogWizardTest.java @@ -54,6 +54,7 @@ */ @InjectWith(CheckWizardUiTestInjectorProvider.class) @RunWith(XtextClassRunner.class) +@SuppressWarnings("nls") public class CheckCatalogWizardTest { /** This is the name of the catalog wizard. It's the name SWTBot uses to look up the wizard. */ diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckProjectWizardTest.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckProjectWizardTest.java index 5261a85cc2..e6c61201b0 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckProjectWizardTest.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckProjectWizardTest.java @@ -34,6 +34,7 @@ */ @InjectWith(CheckWizardUiTestInjectorProvider.class) @RunWith(XtextClassRunner.class) +@SuppressWarnings("nls") public class CheckProjectWizardTest { /** This is the name of the project wizard. It's the name SWTBot uses to look up the wizard. */ diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckContextsExtensionTest.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckContextsExtensionTest.java index e46b2b9f1d..c520123043 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckContextsExtensionTest.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckContextsExtensionTest.java @@ -18,9 +18,9 @@ import org.eclipse.pde.core.plugin.IPluginExtension; import org.eclipse.pde.core.plugin.IPluginModelBase; import org.eclipse.pde.internal.core.plugin.WorkspacePluginModel; +import org.eclipse.xtext.testing.InjectWith; import org.eclipse.xtext.testing.XtextRunner; import org.eclipse.xtext.testing.util.ParseHelper; -import org.eclipse.xtext.testing.InjectWith; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -39,7 +39,7 @@ /** * Tests CheckContextExtensionUtil. */ -@SuppressWarnings("restriction") +@SuppressWarnings({"restriction", "nls"}) @InjectWith(CheckWizardUiTestInjectorProvider.class) @RunWith(XtextRunner.class) public class CheckContextsExtensionTest extends TestCase { diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckMarkerHelpExtensionTest.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckMarkerHelpExtensionTest.java index cdf20f180b..502fabc2dd 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckMarkerHelpExtensionTest.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckMarkerHelpExtensionTest.java @@ -46,7 +46,7 @@ /** * Tests the MarkerHelpExtensionUtil class. */ -@SuppressWarnings({"restriction", "PMD.SignatureDeclareThrowsException"}) +@SuppressWarnings({"restriction", "PMD.SignatureDeclareThrowsException", "nls"}) @InjectWith(CheckWizardUiTestInjectorProvider.class) @RunWith(XtextRunner.class) public class CheckMarkerHelpExtensionTest { diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckTocExtensionTest.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckTocExtensionTest.java index 13fb54b31a..62108eeed2 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckTocExtensionTest.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckTocExtensionTest.java @@ -10,8 +10,6 @@ *******************************************************************************/ package com.avaloq.tools.ddk.check.ui.test.builder; -import junit.framework.TestCase; - import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.CoreException; @@ -35,11 +33,13 @@ import com.google.common.collect.Lists; import com.google.inject.Inject; +import junit.framework.TestCase; + /** * Tests the CheckTocExtensionUtil class. */ -@SuppressWarnings({"restriction", "PMD.SignatureDeclareThrowsException"}) +@SuppressWarnings({"restriction", "PMD.SignatureDeclareThrowsException", "nls"}) @InjectWith(CheckWizardUiTestInjectorProvider.class) @RunWith(XtextRunner.class) public class CheckTocExtensionTest extends TestCase { @@ -69,7 +69,7 @@ public void setUp() throws Exception { /** * Tests if the toc extension is correctly created. - * + * * @throws CoreException * the core exception */ @@ -84,7 +84,7 @@ public void testCreateExtension() throws CoreException { /** * Tests if isExtensionUpdateRequired returns true if only an erroneous extension exists for the check catalog. - * + * * @throws CoreException * the core exception */ @@ -98,7 +98,7 @@ public void testIsExtensionUpdateRequiredTrue() throws CoreException { /** * Creates an erroneous toc extension. - * + * * @return the plugin extension * @throws CoreException * the core exception @@ -116,7 +116,7 @@ private IPluginExtension createErroneousTocExtension() throws CoreException { /** * Tests if an update of a toc extension is correctly done. - * + * * @throws CoreException * the core exception */ @@ -130,7 +130,7 @@ public void testUpdateTocExtension() throws CoreException { /** * Tests if isExtensionUpdateRequires returns false if a correct extension already exists. - * + * * @throws CoreException * the core exception */ diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/contentassist/BugAig931Test.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/contentassist/BugAig931Test.java index 85dce9ec8b..f045ef73cd 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/contentassist/BugAig931Test.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/contentassist/BugAig931Test.java @@ -31,12 +31,12 @@ /** * Tests content assist in Check models. */ -@SuppressWarnings({"PMD.SignatureDeclareThrowsException", "PMD.AvoidFinalLocalVariable"}) +@SuppressWarnings({"PMD.SignatureDeclareThrowsException", "PMD.AvoidFinalLocalVariable", "nls"}) public class BugAig931Test extends AbstractCheckContentAssistBugTest implements IJavaProjectProvider { /** * Verifies that given completions exist. - * + * * @param completionProposals * the actual completion proposals * @param expected @@ -57,7 +57,7 @@ public String apply(final ICompletionProposal input) { /** * Tests bug https://jira.int.sys.net/browse/AIG-931. - * + * * @throws Exception * the exception */ diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/internal/CheckWizardUiTestInjectorProvider.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/internal/CheckWizardUiTestInjectorProvider.java index 7bd8653f70..afd244f7df 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/internal/CheckWizardUiTestInjectorProvider.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/internal/CheckWizardUiTestInjectorProvider.java @@ -22,6 +22,6 @@ public class CheckWizardUiTestInjectorProvider implements IInjectorProvider { @Override public Injector getInjector() { - return com.avaloq.tools.ddk.check.ui.internal.CheckActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.Check"); + return com.avaloq.tools.ddk.check.ui.internal.CheckActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.Check"); //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/util/CheckWizardTestUtil.java b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/util/CheckWizardTestUtil.java index e13c185389..aaf746eee6 100644 --- a/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/util/CheckWizardTestUtil.java +++ b/com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/util/CheckWizardTestUtil.java @@ -29,6 +29,7 @@ /** * Util class for the Check project and Check catalog wizard tests. */ +@SuppressWarnings("nls") public final class CheckWizardTestUtil { // Next button disabled diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckContextsGenerator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckContextsGenerator.java index 9aab654d47..e68a2ed1fb 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckContextsGenerator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckContextsGenerator.java @@ -31,13 +31,13 @@ import org.eclipse.xtext.resource.IResourceDescription.Delta; import org.eclipse.xtext.ui.resource.IStorage2UriMapper; -import com.avaloq.tools.ddk.xtext.ui.util.RuntimeProjectUtil; import com.avaloq.tools.ddk.check.check.Check; import com.avaloq.tools.ddk.check.check.CheckCatalog; import com.avaloq.tools.ddk.check.check.CheckPackage; import com.avaloq.tools.ddk.check.generator.CheckGeneratorNaming; import com.avaloq.tools.ddk.check.ui.builder.util.CheckContextsExtensionHelper; import com.avaloq.tools.ddk.check.ui.builder.util.CheckProjectHelper; +import com.avaloq.tools.ddk.xtext.ui.util.RuntimeProjectUtil; import com.google.common.collect.ComparisonChain; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; @@ -49,7 +49,7 @@ /** * The class responsible for the manipulation of contexts.xml file. */ -@SuppressWarnings("restriction") +@SuppressWarnings({"restriction", "nls"}) public class CheckContextsGenerator { @Inject diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckExtensionGenerator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckExtensionGenerator.java index 6781df3ef0..273cfea5d2 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckExtensionGenerator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckExtensionGenerator.java @@ -88,7 +88,7 @@ */ // CHECKSTYLE:OFF (abstraction coupling) -@SuppressWarnings({"restriction"}) +@SuppressWarnings({"restriction", "nls"}) class CheckExtensionGenerator { // CHECKSTYLE:ON private static final Logger LOGGER = LogManager.getLogger(CheckExtensionGenerator.class); diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckTocGenerator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckTocGenerator.java index ab14f9bf53..2eb6af9986 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckTocGenerator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckTocGenerator.java @@ -21,19 +21,19 @@ import org.eclipse.xtext.builder.IXtextBuilderParticipant.IBuildContext; import org.eclipse.xtext.ui.resource.IStorage2UriMapper; -import com.avaloq.tools.ddk.xtext.ui.util.RuntimeProjectUtil; import com.avaloq.tools.ddk.check.check.Category; import com.avaloq.tools.ddk.check.check.Check; import com.avaloq.tools.ddk.check.generator.CheckGeneratorNaming; import com.avaloq.tools.ddk.check.ui.builder.util.CheckProjectHelper; import com.avaloq.tools.ddk.check.ui.builder.util.CheckTocExtensionHelper; +import com.avaloq.tools.ddk.xtext.ui.util.RuntimeProjectUtil; import com.google.inject.Inject; /** * The class responsible for the manipulation of toc.xml file. */ -@SuppressWarnings("restriction") +@SuppressWarnings({"restriction", "nls"}) public class CheckTocGenerator { @Inject @@ -51,7 +51,7 @@ public class CheckTocGenerator { /** * Removes the topic from toc file. - * + * * @param uri * the uri * @throws CoreException @@ -69,7 +69,7 @@ public void removeTopicFromTocFile(final URI uri) throws CoreException { /** * Removes the topic from toc file. - * + * * @param model * the model containing the toc * @param reference @@ -90,7 +90,7 @@ private void removeTopicFromTocFile(final TocModel model, final String reference /** * Returns the reference to the html-page for the given URI. - * + * * @param uri * the uri * @return @@ -102,7 +102,7 @@ private String getFieldReference(final URI uri) { /** * Change toc.xml file if necessary. - * + * * @param uri * the uri * @param buildContext @@ -128,7 +128,7 @@ public void updateTocModel(final URI uri, final IBuildContext buildContext) thro /** * Adds the topic to toc model. - * + * * @param model * the model * @param label @@ -197,7 +197,7 @@ private void addTopicToToc(final TocModel model, final String label, final Strin /** * Updates the toc model with initial toc field label and anchor point. Saves and returns the model. - * + * * @param model * the model * @throws CoreException @@ -213,7 +213,7 @@ private void updateToc(final TocModel model) throws CoreException { /** * Loads toc model and sets toc.xml as underlying resource. - * + * * @param uri * the uri * @return the toc model diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java index ed8c2349cb..28ff2ac87d 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java @@ -30,6 +30,7 @@ /** * Abstract class for extension point utility classes. Defines operations required by the Check builder participant. */ +@SuppressWarnings("nls") public abstract class AbstractCheckExtensionHelper implements ICheckExtensionHelper { protected static final String LANGUAGE_ELEMENT_TAG = "language"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckContextsExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckContextsExtensionHelper.java index 5aed8a4025..17335bc881 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckContextsExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckContextsExtensionHelper.java @@ -26,6 +26,7 @@ /** * The extension point utility class for context sensitive help. Intended to be used by the Check builder participant. */ +@SuppressWarnings("nls") public class CheckContextsExtensionHelper extends AbstractCheckDocumentationExtensionHelper { public static final String FILE_ATTRIBUTE_TAG = "file"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java index 92df013a3f..3b8a1ac766 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java @@ -124,6 +124,7 @@ private ICheckExtensionHelper getExtensionHelper(final ExtensionType type) { * the type id * @return the extension ID for current Catalog or {@code null} */ + @SuppressWarnings("nls") private String getExtensionId(final QualifiedName catalogName, final ExtensionType typeId) { QualifiedName result = catalogName; switch (typeId) { diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckMarkerHelpExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckMarkerHelpExtensionHelper.java index 43ad5f3d7d..3741ca2f9d 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckMarkerHelpExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckMarkerHelpExtensionHelper.java @@ -49,6 +49,7 @@ /** * The extension point utility class for Check marker help. Intended to be used by the Check builder participant. */ +@SuppressWarnings("nls") public class CheckMarkerHelpExtensionHelper extends AbstractCheckDocumentationExtensionHelper { public static final String MARKERHELP_EXTENSION_POINT_ID = "org.eclipse.ui.ide.markerHelp"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckPreferencesExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckPreferencesExtensionHelper.java index 50fe66fdf0..2e90a54a73 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckPreferencesExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckPreferencesExtensionHelper.java @@ -26,6 +26,7 @@ /** * The extension point utility class for preference initializers. Intended to be used by the Check builder participant. */ +@SuppressWarnings("nls") public final class CheckPreferencesExtensionHelper extends AbstractCheckExtensionHelper implements ICheckExtensionHelper { public static final String GENERATE_PREFERENCES_EXTENSION_PREFERENCE = "generatePreferencesExtension"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckProjectHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckProjectHelper.java index e3ca179d87..59c5b0436b 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckProjectHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckProjectHelper.java @@ -48,6 +48,7 @@ * Class providing utility methods for projects. */ @Singleton +@SuppressWarnings("nls") public class CheckProjectHelper { private static final Logger LOGGER = LogManager.getLogger(CheckProjectHelper.class); diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckQuickfixExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckQuickfixExtensionHelper.java index caab9450d3..4ddec652eb 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckQuickfixExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckQuickfixExtensionHelper.java @@ -27,6 +27,7 @@ /** * The extension point utility class for Check quickfixes. Intended to be used by the Check builder participant. */ +@SuppressWarnings("nls") public final class CheckQuickfixExtensionHelper extends AbstractCheckExtensionHelper { public static final String QUICKFIX_EXTENSION_POINT_ID = "com.avaloq.tools.ddk.check.runtime.core.checkquickfix"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckTocExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckTocExtensionHelper.java index 10c0f80b73..dcbea421e2 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckTocExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckTocExtensionHelper.java @@ -26,6 +26,7 @@ /** * The extension point utility class for Eclipse help contribution. Intended to be used by the Check builder participant. */ +@SuppressWarnings("nls") public class CheckTocExtensionHelper extends AbstractCheckDocumentationExtensionHelper { public static final String TOC_FILE_NAME = "docs/toc.xml"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckValidatorExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckValidatorExtensionHelper.java index 72df20c0fc..f7a7607f4d 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckValidatorExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckValidatorExtensionHelper.java @@ -25,6 +25,7 @@ /** * The extension point utility class for Check validators. Intended to be used by the Check builder participant. */ +@SuppressWarnings("nls") public final class CheckValidatorExtensionHelper extends AbstractCheckExtensionHelper { public static final String GENERATE_VALIDATOR_EXTENSION_PREFERENCE = "generateValidatorExtension"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/contentassist/CheckProposalProvider.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/contentassist/CheckProposalProvider.java index 8ace09599f..b6ff755cd1 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/contentassist/CheckProposalProvider.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/contentassist/CheckProposalProvider.java @@ -44,6 +44,7 @@ /** * Configures a proposal provider for the Check editor. */ +@SuppressWarnings("nls") public class CheckProposalProvider extends AbstractCheckProposalProvider { // @Format-Off diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/highlighting/CheckAntlrTokenToAttributeIdMapper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/highlighting/CheckAntlrTokenToAttributeIdMapper.java index e9361bd8fc..11cfd04da3 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/highlighting/CheckAntlrTokenToAttributeIdMapper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/highlighting/CheckAntlrTokenToAttributeIdMapper.java @@ -17,6 +17,7 @@ /** * A Token Scanner that recognizes @SeverityRange tokens. */ +@SuppressWarnings("nls") public class CheckAntlrTokenToAttributeIdMapper extends DefaultAntlrTokenToAttributeIdMapper { // XbaseAntlrTokenToAttributeMapper is deprecated and empty anyway, so we may safely use the default mapper as super type here. diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/highlighting/CheckHighlightingConfiguration.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/highlighting/CheckHighlightingConfiguration.java index 8b7f4c95bc..6b8990b268 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/highlighting/CheckHighlightingConfiguration.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/highlighting/CheckHighlightingConfiguration.java @@ -20,6 +20,7 @@ * A HighlightingConfiguration for the Check language. Highlights the javadoc comments as * blue instead of green... */ +@SuppressWarnings("nls") public class CheckHighlightingConfiguration extends XbaseHighlightingConfiguration { public static final String JAVADOC_ID = "javadoc"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/hover/CheckHoverProvider.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/hover/CheckHoverProvider.java index fd0cc8f51b..b0048166e8 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/hover/CheckHoverProvider.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/hover/CheckHoverProvider.java @@ -26,6 +26,7 @@ */ // CHECKSTYLE:OFF +@SuppressWarnings("nls") public class CheckHoverProvider extends XbaseHoverProvider { @Inject diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckDescriptionLabelProvider.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckDescriptionLabelProvider.java index 9c4ca4992f..b021b4c1e5 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckDescriptionLabelProvider.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckDescriptionLabelProvider.java @@ -29,7 +29,7 @@ public class CheckDescriptionLabelProvider extends XbaseDescriptionLabelProvider @Override public String text(final IEObjectDescription element) { - return element.getName() + " - " + element.getEClass().getName(); + return element.getName() + " - " + element.getEClass().getName(); //$NON-NLS-1$ } @Override diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckImages.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckImages.java index 9374ab70e9..3cd6979f22 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckImages.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckImages.java @@ -25,7 +25,7 @@ /** * The Class CheckImages provides icons for check model elements. */ -@SuppressWarnings("restriction") +@SuppressWarnings({"restriction", "nls"}) public class CheckImages { private static final String RESOURCE_IMAGE = "editor.gif"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/outline/CheckOutlineTreeProvider.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/outline/CheckOutlineTreeProvider.java index 68ca060fae..9470579814 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/outline/CheckOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/outline/CheckOutlineTreeProvider.java @@ -43,7 +43,7 @@ protected void internalCreateChildren(final DocumentRootNode parentNode, final E } if (catalog.getImports() != null && !catalog.getImports().getImportDeclarations().isEmpty()) { - EStructuralFeatureNode importNode = getOutlineNodeFactory().createEStructuralFeatureNode(parentNode, catalog, CheckPackage.Literals.CHECK_CATALOG__IMPORTS, ImageDescriptor.createFromImage(checkImages.forImportContainer()), "Import declarations", false); + EStructuralFeatureNode importNode = getOutlineNodeFactory().createEStructuralFeatureNode(parentNode, catalog, CheckPackage.Literals.CHECK_CATALOG__IMPORTS, ImageDescriptor.createFromImage(checkImages.forImportContainer()), "Import declarations", false); //$NON-NLS-1$ for (final org.eclipse.xtext.xtype.XImportDeclaration imported : catalog.getImports().getImportDeclarations()) { createNode(importNode, imported); } diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/popup/actions/DeployJob.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/popup/actions/DeployJob.java index eef9804c0b..41b13c6dbd 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/popup/actions/DeployJob.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/popup/actions/DeployJob.java @@ -122,7 +122,7 @@ protected IStatus run(final IProgressMonitor monitor) { */ private void deployCheckBundle() throws DeployException { - File tempDir = createTempDirectory("check_catalog"); + File tempDir = createTempDirectory("check_catalog"); //$NON-NLS-1$ tempDir.mkdirs(); final File jar = generateJar(tempDir, new NullProgressMonitor()); @@ -227,14 +227,14 @@ public boolean visit(final IResource resource) throws CoreException { if (resource instanceof IProject) { return true; } - if (resource instanceof IFile && CheckCfgConstants.FILE_EXTENSION.equalsIgnoreCase(((IFile) resource).getFileExtension())) { + if (resource instanceof IFile && CheckCfgConstants.FILE_EXTENSION.equalsIgnoreCase(resource.getFileExtension())) { checkCfgFiles.add((IFile) resource); return false; } if (isProjectJarIgnoreResource(resource)) { return false; } - if (resource instanceof IFolder && "bin".equals(resource.getName())) { // NOPMD SimplifyBooleanReturns + if (resource instanceof IFolder && "bin".equals(resource.getName())) { // NOPMD SimplifyBooleanReturns //$NON-NLS-1$ return false; } return true; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/util/CheckResourceUtil.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/util/CheckResourceUtil.java index 443514f51b..7b853d7a2f 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/util/CheckResourceUtil.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/util/CheckResourceUtil.java @@ -14,8 +14,8 @@ import java.util.Map; import java.util.Set; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IFolder; import org.eclipse.emf.common.util.URI; @@ -84,7 +84,7 @@ public String getNameOfContainingPackage(final IXtextDocument xtextDocument) { IPackageFragment myFragment = javaProject.findPackageFragment(file.getParent().getFullPath()); return myFragment.getElementName(); } catch (JavaModelException e) { - LOGGER.error("Could not determine package for file of given document"); + LOGGER.error("Could not determine package for file of given document"); //$NON-NLS-1$ } } return null; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogCreator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogCreator.java index 614d014c54..e659b0fe22 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogCreator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogCreator.java @@ -30,6 +30,7 @@ /** * The Class CheckCatalogCreator creates a new Check catalog in an existing Check plugin project. */ +@SuppressWarnings("nls") public class CheckCatalogCreator extends WorkspaceModifyOperation implements ICheckCatalogCreator { /** The result. */ diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java index a95d770ee4..a2111decf2 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java @@ -67,6 +67,7 @@ public void generateDefaultQuickfixProvider(final IPath path, final CheckProject * @param projectInfo * the project info */ + @SuppressWarnings("nls") public void generateDocsDirectory(final IPath path, final CheckProjectInfo projectInfo) { fsa.setOutputPath(path.toOSString()); // IFileSystemAccess doesn't support creating empty directories, so: diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckProjectCreator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckProjectCreator.java index c20820d730..a07d178b78 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckProjectCreator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckProjectCreator.java @@ -32,6 +32,7 @@ /** * The Class creates a new check plugin project. */ +@SuppressWarnings("nls") public class CheckProjectCreator extends AbstractPluginProjectCreator { // extends CheckProjectCreator protected static final String SRC_ROOT = "src"; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckProjectInfo.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckProjectInfo.java index 51f6ebc022..87d7adaa91 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckProjectInfo.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckProjectInfo.java @@ -27,6 +27,7 @@ /** * Aggregates project information collected from UI. */ +@SuppressWarnings("nls") public class CheckProjectInfo extends DefaultProjectInfo { private String catalogName; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckCatalogWizardPage.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckCatalogWizardPage.java index 740e0be4d0..27f6fa18ee 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckCatalogWizardPage.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckCatalogWizardPage.java @@ -59,7 +59,7 @@ * new Check Catalog wizard}. */ // CHECKSTYLE:OFF (data coupling) -@SuppressWarnings("restriction") +@SuppressWarnings({"restriction", "nls"}) public class NewCheckCatalogWizardPage extends NewTypeWizardPage { // CHECKSTYLE:ON diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizardPage.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizardPage.java index a7dcee717e..ae13270179 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizardPage.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizardPage.java @@ -33,7 +33,7 @@ * Furthermore, the page allows setting the catalog name and a * new check file. */ -@SuppressWarnings("restriction") +@SuppressWarnings({"restriction", "nls"}) public class NewCheckProjectWizardPage extends NewTypeWizardPage { private static final int DEFAULT_COLUMN_NUMBER = 4; diff --git a/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidationTest.java b/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidationTest.java index 9098f1a1b4..2c771b7175 100644 --- a/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidationTest.java +++ b/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidationTest.java @@ -53,7 +53,7 @@ public class CheckCfgValidationTest extends TestCase { */ @Test public void testDisabledCheckIsNotConfigured() throws Exception { // NOPMD - CheckConfiguration model = parser.parse(modelUtil.basicModelWithDisabledTest() + " (val = 0)"); + CheckConfiguration model = parser.parse(modelUtil.basicModelWithDisabledTest() + " (val = 0)"); //$NON-NLS-1$ helper.assertWarning(model, CheckcfgPackage.Literals.CONFIGURED_CHECK, IssueCodes.DISABLED_CHECK_NOT_CONFIGURED); } diff --git a/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/test/checkcfg/TestPropertySpecificationWithExpectedValues.java b/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/test/checkcfg/TestPropertySpecificationWithExpectedValues.java index 579d4e1962..ef227cdc99 100644 --- a/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/test/checkcfg/TestPropertySpecificationWithExpectedValues.java +++ b/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/test/checkcfg/TestPropertySpecificationWithExpectedValues.java @@ -15,6 +15,7 @@ /** A test implementation of {@link ICheckCfgPropertySpecification} that specifies expected values. */ +@SuppressWarnings("nls") public final class TestPropertySpecificationWithExpectedValues implements ICheckCfgPropertySpecification { public static final TestPropertySpecificationWithExpectedValues INSTANCE = new TestPropertySpecificationWithExpectedValues(); diff --git a/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/test/checkcfg/TestPropertySpecificationWithOutExpectedValues.java b/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/test/checkcfg/TestPropertySpecificationWithOutExpectedValues.java index ba4b560974..0d492c1bfa 100644 --- a/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/test/checkcfg/TestPropertySpecificationWithOutExpectedValues.java +++ b/com.avaloq.tools.ddk.checkcfg.core.test/src/com/avaloq/tools/ddk/test/checkcfg/TestPropertySpecificationWithOutExpectedValues.java @@ -15,6 +15,7 @@ /** A test implementation of {@link ICheckCfgPropertySpecification} that specifies no expected values. */ +@SuppressWarnings("nls") public final class TestPropertySpecificationWithOutExpectedValues implements ICheckCfgPropertySpecification { public static final TestPropertySpecificationWithOutExpectedValues INSTANCE = new TestPropertySpecificationWithOutExpectedValues(); diff --git a/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/generator/CheckConfigurationPropertiesGenerator.java b/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/generator/CheckConfigurationPropertiesGenerator.java index f1036b98ed..9fd91adcb7 100644 --- a/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/generator/CheckConfigurationPropertiesGenerator.java +++ b/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/generator/CheckConfigurationPropertiesGenerator.java @@ -17,8 +17,8 @@ import java.util.stream.Collectors; import java.util.stream.StreamSupport; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.eclipse.emf.common.util.ECollections; import org.eclipse.emf.common.util.EList; import org.eclipse.emf.ecore.EObject; @@ -82,6 +82,7 @@ public Properties convertToProperties(final CheckConfiguration configuration) { * @param configuredCheck * the configured check */ + @SuppressWarnings("nls") private void generatePropertiesForConfiguredCheck(final Properties properties, final String language, final ConfiguredCheck configuredCheck) { if (configuredCheck.getCheck() == null || configuredCheck.getCheck().eIsProxy()) { LOG.warn("Did not configure check " + NodeModelUtils.getTokenText(NodeModelUtils.getNode(configuredCheck))); diff --git a/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidator.java b/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidator.java index d4d36dc96e..d589396e03 100644 --- a/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidator.java +++ b/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidator.java @@ -54,6 +54,7 @@ * See https://www.eclipse.org/Xtext/documentation/303_runtime_concepts.html#validation */ @ComposedChecks(validators = {ConfiguredParameterChecks.class}) +@SuppressWarnings("nls") public class CheckCfgValidator extends AbstractCheckCfgValidator { private static final Logger LOGGER = LogManager.getLogger(CheckCfgValidator.class); diff --git a/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/IssueCodes.java b/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/IssueCodes.java index 8219882c98..d10f56c1f1 100644 --- a/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/IssueCodes.java +++ b/com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/IssueCodes.java @@ -13,6 +13,7 @@ /** * Issue codes used for the Check Configuration Java validator. */ +@SuppressWarnings("nls") public final class IssueCodes { private static final String ISSUE_CODE_PREFIX = "com.avaloq.tools.ddk.checkcfg.validation.IssueCodes."; diff --git a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/contentassist/CheckCfgProposalProvider.java b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/contentassist/CheckCfgProposalProvider.java index be2e86974d..2f181320e1 100644 --- a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/contentassist/CheckCfgProposalProvider.java +++ b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/contentassist/CheckCfgProposalProvider.java @@ -56,7 +56,7 @@ public void completeConfiguredParameter_NewValue(final EObject model, final Assi if (validValues != null && validValues.length > 0) { String info = propertySpecification.getInfo(); for (String validValue : validValues) { - ICompletionProposal proposal = createCompletionProposal(String.format("\"%s\"", validValue), new StyledString(validValue), getImage(model), 0, context.getPrefix(), context); + ICompletionProposal proposal = createCompletionProposal(String.format("\"%s\"", validValue), new StyledString(validValue), getImage(model), 0, context.getPrefix(), context); //$NON-NLS-1$ if (proposal instanceof ConfigurableCompletionProposal) { ((ConfigurableCompletionProposal) proposal).setAdditionalProposalInfo(info); } diff --git a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/labeling/CheckCfgImages.java b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/labeling/CheckCfgImages.java index aa041b555e..28875cd318 100644 --- a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/labeling/CheckCfgImages.java +++ b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/labeling/CheckCfgImages.java @@ -20,6 +20,7 @@ /** * Provides icons for Check Configuration model elements. */ +@SuppressWarnings("nls") public class CheckCfgImages { private static final String RESOURCE_IMAGE = "editor.gif"; diff --git a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java index ccfaa3f8b4..b70ad926db 100644 --- a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java @@ -24,6 +24,7 @@ /** * Configures the Check Configuration default outline structure. */ +@SuppressWarnings("nls") public class CheckCfgOutlineTreeProvider extends DefaultOutlineTreeProvider { @Inject @@ -40,7 +41,7 @@ public class CheckCfgOutlineTreeProvider extends DefaultOutlineTreeProvider { *

* Uses configured highlighting configuration for unresolved values. *

- * + * * @param configuredCatalog * the configured catalog * @return a styled string @@ -66,7 +67,7 @@ protected Object _text(final ConfiguredCatalog configuredCatalog) { *

* Uses configured highlighting configuration for disabled and unresolved values. *

- * + * * @param configuredCheck * the configured check * @return a styled string @@ -92,7 +93,7 @@ protected Object _text(final ConfiguredCheck configuredCheck) { /** * Returns a "safe name" for a string, being either given string itself or a non-null value. Does not return {@code null}. - * + * * @param s * the string to be checked * @return the safe string @@ -103,7 +104,7 @@ protected String safeName(final String s) { /** * A configured check shall be displayed as a leaf node in the outline view. - * + * * @param modelElement * the model element * @return {@code true} diff --git a/com.avaloq.tools.ddk.sample.helloworld.ui.test/src/com/avaloq/tools/ddk/sample/helloworld/label/IssueLabelTest.xtend b/com.avaloq.tools.ddk.sample.helloworld.ui.test/src/com/avaloq/tools/ddk/sample/helloworld/label/IssueLabelTest.xtend index 52f52a928a..91555b6446 100644 --- a/com.avaloq.tools.ddk.sample.helloworld.ui.test/src/com/avaloq/tools/ddk/sample/helloworld/label/IssueLabelTest.xtend +++ b/com.avaloq.tools.ddk.sample.helloworld.ui.test/src/com/avaloq/tools/ddk/sample/helloworld/label/IssueLabelTest.xtend @@ -12,7 +12,7 @@ package com.avaloq.tools.ddk.sample.helloworld.label import com.google.inject.AbstractModule import com.google.inject.Guice -import org.junit.Test +import org.junit.Test import static org.junit.Assert.assertEquals import static org.junit.Assert.assertNotNull diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/AbstractSystemTest.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/AbstractSystemTest.java index cf2ab9a09d..5b441dbf9f 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/AbstractSystemTest.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/AbstractSystemTest.java @@ -27,7 +27,7 @@ /** * Abstract base class for system tests. */ -@SuppressWarnings("restriction") +@SuppressWarnings({"restriction", "nls"}) public abstract class AbstractSystemTest implements TestStepListener { // The particular suppress warnings annotation is needed because we WANT to have a unique logger for each of the subclasses @SuppressWarnings("PMD.LoggerIsNotStaticFinal") diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/BugTestAwareRule.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/BugTestAwareRule.java index fc61f2b065..d3f7ebba7f 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/BugTestAwareRule.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/BugTestAwareRule.java @@ -27,13 +27,13 @@ *

*

* Example for a bug test: - * + * * 

  * public class TestClass {
- * 
+ *
  *   @Rule
  *   public BugTestAwareRule rule = BugTestAwareRule.getInstance();
- * 
+ *
  *   @org.junit.Test
  *   @com.avaloq.tools.ddk.test.core.BugTest(value = "BUG-42", unresolved = true)
  *   public void testMethod() {
@@ -42,12 +42,12 @@
  * }
  *
*

- * + * * @see BugTest */ public final class BugTestAwareRule implements TestRule { - private static final String ERROR_TEST_MUST_FAIL = "The unresolved bug test must fail:"; + private static final String ERROR_TEST_MUST_FAIL = "The unresolved bug test must fail:"; //$NON-NLS-1$ /** The singleton instance, or {@code null} if not cached. */ private static BugTestAwareRule instance; private static final Object LOCK = new Object(); @@ -61,7 +61,7 @@ private BugTestAwareRule() { /** * Returns a shared singleton instance. - * + * * @return a shared instance, never {@code null} */ public static BugTestAwareRule getInstance() { diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/CompoundStep.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/CompoundStep.java index b82ee7384a..502f64c325 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/CompoundStep.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/CompoundStep.java @@ -13,8 +13,8 @@ import java.util.List; import java.util.ListIterator; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.eclipse.core.runtime.Assert; import com.google.common.collect.Lists; @@ -23,6 +23,7 @@ /** * Reusable class that represents a compound step. */ +@SuppressWarnings("nls") public class CompoundStep extends AbstractStep { private static final String ARGUMENT_THROWABLE = "throwable"; private static final String ARGUMENT_STEP = "step"; diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/IssueAwareRule.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/IssueAwareRule.java index 40413f0ce5..4ba3cf8c46 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/IssueAwareRule.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/IssueAwareRule.java @@ -27,13 +27,13 @@ *

*

* Example for a issue test: - * + * * 

  * public class TestClass {
- * 
+ *
  *   @Rule
  *   public IssueAwareRule rule = IssueAwareRule.getInstance();
- * 
+ *
  *   @org.junit.Test
  *   @com.avaloq.tools.ddk.test.core.Issue(value = "ISSUE-42", fixed = false)
  *   public void testMethod() {
@@ -42,12 +42,12 @@
  * }
  *
*

- * + * * @see Issue */ public final class IssueAwareRule implements TestRule { - private static final String ERROR_TEST_MUST_FAIL = "The issue test for a not fixed issue must fail:"; + private static final String ERROR_TEST_MUST_FAIL = "The issue test for a not fixed issue must fail:"; //$NON-NLS-1$ /** The singleton instance, or {@code null} if not cached. */ private static IssueAwareRule instance; private static Object lock = new Object(); @@ -61,7 +61,7 @@ private IssueAwareRule() { /** * Returns a shared singleton instance. - * + * * @return a shared instance, never {@code null} */ public static IssueAwareRule getInstance() { diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/LoggingRule.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/LoggingRule.java index f703e56b3a..b4a18dce7b 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/LoggingRule.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/LoggingRule.java @@ -10,8 +10,8 @@ *******************************************************************************/ package com.avaloq.tools.ddk.test.core; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.junit.rules.TestWatcher; import org.junit.runner.Description; @@ -19,6 +19,7 @@ /** * A test watcher that logs the start and end of each test, as well as its success or failure. */ +@SuppressWarnings("nls") public final class LoggingRule extends TestWatcher { private static final Logger LOGGER = LogManager.getLogger(LoggingRule.class); @@ -37,7 +38,7 @@ private LoggingRule() { /** * Returns a shared singleton instance. - * + * * @return a shared instance, never {@code null} */ public static LoggingRule getInstance() { @@ -51,7 +52,7 @@ public static LoggingRule getInstance() { /** * Returns the name of a test to be logged. - * + * * @param description * the description, must not be {@code null} * @return the description name, never {@code null} diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/MultipleTestProblems.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/MultipleTestProblems.java index 7785d85880..36e2423d4e 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/MultipleTestProblems.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/MultipleTestProblems.java @@ -22,6 +22,7 @@ /** * Contains a list of problems. */ +@SuppressWarnings("nls") public class MultipleTestProblems extends AssertionError { private static final long serialVersionUID = 1L; private final List problems = Lists.newArrayList(); diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/NullStep.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/NullStep.java index 7e9969be1d..4cc66f1450 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/NullStep.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/NullStep.java @@ -21,7 +21,7 @@ private NullStep() { @Override public String getDescription() { - return "Does nothing."; + return "Does nothing."; //$NON-NLS-1$ } @Override diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/StatementFactory.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/StatementFactory.java index a1405ae98f..3b9317093e 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/StatementFactory.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/StatementFactory.java @@ -32,7 +32,7 @@ private StatementFactory() { * If the {@code base} statement throws an {@link AssertionError}, the returned statement will catch it and succeed nevertheless. If the {@code base} * statement succeeds, the returned statement will throw an {@link AssertionError} with the custom error message {@code errorMessage}. *

- * + * * @param errorMessage * the error message for the new {@link AssertionError}, must not be {@code null} * @param base @@ -41,6 +41,7 @@ private StatementFactory() { * the description of the test that will be run, must not be {@code null} * @return the inverted statement, never {@code null} */ + @SuppressWarnings("nls") public static Statement createResultInvertingStatement(final String errorMessage, final Statement base, final Description description) { return new Statement() { @Override diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/StepResult.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/StepResult.java index 6d3bb54a81..78d66f1ec1 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/StepResult.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/StepResult.java @@ -62,6 +62,7 @@ public boolean isValueSet() { } @Override + @SuppressWarnings("nls") public String toString() { if (!isValueSet()) { return ""; diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/TestEntityAction.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/TestEntityAction.java index 5730732382..af37dc4e7d 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/TestEntityAction.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/TestEntityAction.java @@ -16,6 +16,7 @@ /** * Represents an action a test performs on a {@link ITestEntity}. */ +@SuppressWarnings("nls") public class TestEntityAction { // Argument names diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/TestPlan.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/TestPlan.java index 0d1427d31a..2a9133203e 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/TestPlan.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/TestPlan.java @@ -73,7 +73,7 @@ public static TestPlan create() { * @return the newly added {@link AbstractStep}, never {@code null} */ public T addSetupStep(final T setupStep) { - Assert.assertTrue("Must not add a setup step after adding a test step.", getCompoundTestStep().getSteps().isEmpty()); + Assert.assertTrue("Must not add a setup step after adding a test step.", getCompoundTestStep().getSteps().isEmpty()); //$NON-NLS-1$ getCompoundSetupStep().addStep(setupStep); return setupStep; } diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/data/TestData.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/data/TestData.java index 419e930337..a9c6ca5468 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/data/TestData.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/data/TestData.java @@ -13,6 +13,7 @@ /** * The Class TestData. */ +@SuppressWarnings("nls") public final class TestData { /** The Bot prefix. */ @@ -30,7 +31,7 @@ private TestData() { /** * Gets the system property indicated by the specified key. The method returns the * default value argument if the property is not found. - * + * * @param defaultValue * the default value * @param propertyKey diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/data/User.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/data/User.java index 6bf3034f1f..276776694b 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/data/User.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/data/User.java @@ -40,7 +40,7 @@ public String getPassword() { */ public String getFullUsername() { if (fullUsername != null) { - return fullUsername + " (" + username + ")"; + return fullUsername + " (" + username + ")"; //$NON-NLS-1$ //$NON-NLS-2$ } return fullUsername; } diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/DynamicSuite.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/DynamicSuite.java index ad963b3a0c..f8f99d69bb 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/DynamicSuite.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/DynamicSuite.java @@ -69,6 +69,7 @@ public DynamicSuite(final RunnerBuilder builder, final Class clazz, final Cla * @throws InitializationError * thrown when annotation is missing or class can not be found */ + @SuppressWarnings("nls") private static Class[] getSuiteClasses(final Class clazz) throws InitializationError { // get annotation SuiteClasses annotation = clazz.getAnnotation(SuiteClasses.class); diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/FilterRegistry.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/FilterRegistry.java index 13dac3daf1..08aadab90a 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/FilterRegistry.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/FilterRegistry.java @@ -33,6 +33,7 @@ * {@value #PROPERTY_METHOD_FILTERS}. *

*/ +@SuppressWarnings("nls") public final class FilterRegistry extends Filter { private static final String NEGATOR = "!"; private static final String FILTER_SEPARATOR = ","; diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/NameMethodFilter.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/NameMethodFilter.java index c894528232..269e74fe22 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/NameMethodFilter.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/NameMethodFilter.java @@ -22,6 +22,7 @@ * Note: The regular expression needs to be defined using the property {@value #PROPERTY_NAME_PREFIX}. *

*/ +@SuppressWarnings("nls") public class NameMethodFilter extends Filter { private static final String PROPERTY_NAME_PREFIX = "com.avaloq.test.namemethodfilter"; @@ -41,7 +42,7 @@ public String describe() { /** * Returns the qualified method name of the given {@link Description}. - * + * * @param description * the {@link Description} which must describe a test method, must not be {@code null} * @return the qualified method name of the given {@link Description} diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/NegatedFilter.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/NegatedFilter.java index 4ab2046474..4ca69f535b 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/NegatedFilter.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/NegatedFilter.java @@ -23,7 +23,7 @@ public class NegatedFilter extends Filter { /** * Creates a new instance of {@link NegatedFilter}. - * + * * @param filter * the filter to negate, must not be {@code null} */ @@ -39,6 +39,6 @@ public boolean shouldRun(final Description description) { @Override public String describe() { - return "!" + underlyingFilter.describe(); + return "!" + underlyingFilter.describe(); //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/SwtBotClassFilter.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/SwtBotClassFilter.java index 36a81380f3..8e5557c831 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/SwtBotClassFilter.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/SwtBotClassFilter.java @@ -30,7 +30,7 @@ public boolean shouldRun(final Description description) { final RunWith runWithAnnotation = description.getAnnotation(RunWith.class); return runWithAnnotation != null - && System.getProperty(SwtBotClassFilter.class.getCanonicalName() + ".runwithannotation").equals(runWithAnnotation.value().getName()); + && System.getProperty(SwtBotClassFilter.class.getCanonicalName() + ".runwithannotation").equals(runWithAnnotation.value().getName()); //$NON-NLS-1$ } @Override diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java index a8eb2d4878..d970192258 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java @@ -82,7 +82,7 @@ public static synchronized void mockRegistry() { */ public static void mockExecutableExtension(final IConfigurationElement mockedElement, final String attribute, final Object contribution) { if (!mockingDetails(mockedElement).isMock()) { - throw new IllegalArgumentException("The configuration element must be a mock."); + throw new IllegalArgumentException("The configuration element must be a mock."); //$NON-NLS-1$ } try { when(mockedElement.createExecutableExtension(attribute)).thenReturn(contribution); diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/CoreUtilTools.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/CoreUtilTools.java index 1635b29ad3..d057caa9d3 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/CoreUtilTools.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/CoreUtilTools.java @@ -21,6 +21,7 @@ /** * Test Helper Class CoreUtilTools. */ +@SuppressWarnings("nls") public final class CoreUtilTools { private static final String HOST_NAME; diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/JobChangeListener.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/JobChangeListener.java index 306baee5b0..69343719ce 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/JobChangeListener.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/JobChangeListener.java @@ -27,6 +27,7 @@ /** * A job manager for querying information about scheduled {@link org.eclipse.core.runtime.jobs.Job}s and their completion. */ +@SuppressWarnings("nls") public class JobChangeListener extends JobChangeAdapter { public static final String JOB_REFRESHING_WORKSPACE = "Refreshing workspace"; public static final String JOB_REFRESHING_CONTEXT = "Refreshing Context"; diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/JobMatcher.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/JobMatcher.java index bc23749ad3..7a2498318b 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/JobMatcher.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/JobMatcher.java @@ -55,6 +55,7 @@ *

* It doesn't really make sense to call both {@link #waitForExistingJobs()} and {@link #assertNewJobsFinished()} on a job matcher. */ +@SuppressWarnings("nls") public class JobMatcher extends JobChangeAdapter { public static final long DEFAULT_JOB_WAIT_TIMEOUT = TimeUnit.SECONDS.toMillis(30); diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/Reflect.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/Reflect.java index d6c5fcdc93..70f1162a66 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/Reflect.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/Reflect.java @@ -60,6 +60,7 @@ public static StackTraceElement getCaller() { * @return the caller */ // CHECKSTYLE:OFF + @SuppressWarnings("nls") public static StackTraceElement getCaller(final int offset) { if (offset < 0) { throw new IllegalArgumentException("Offset must be >= 0"); diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/SimpleProgressMonitor.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/SimpleProgressMonitor.java index a2ced2e21d..42e8508a97 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/SimpleProgressMonitor.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/SimpleProgressMonitor.java @@ -169,7 +169,7 @@ public void waitForTermination() { final long timeStarted = System.currentTimeMillis(); while (!isTerminated()) { long remainingWaitTime = TIMEOUT + timeStarted - System.currentTimeMillis(); - Assert.assertFalse("Progress monitor did not get done signal", remainingWaitTime <= 0); + Assert.assertFalse("Progress monitor did not get done signal", remainingWaitTime <= 0); //$NON-NLS-1$ try { this.wait(remainingWaitTime); } catch (InterruptedException e) /* CHECKSTYLE:OFF */ { diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/WorkspaceHelper.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/WorkspaceHelper.java index 9a1eb16ee5..60c287ee83 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/WorkspaceHelper.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/WorkspaceHelper.java @@ -82,7 +82,7 @@ public boolean isWorkspaceBuilt() { public boolean isWorkspaceReady() { boolean result = getJobChangeListener().hasNoJobs(JobChangeListener.JOB_LOAD_PLATFORM, JobChangeListener.JOB_UPDATING_PROJECTS, JobChangeListener.JOB_BACKGROUND_BUILD, JobChangeListener.JOB_REFRESHING_WORKSPACE, JobChangeListener.JOB_INITIALIZING_JAVA_TOOLING); result &= !getJobChangeListener().hasJob(JobChangeListener.JOB_REFRESHING_CONTEXT); - return result && !getJobChangeListener().jobExists("Refresh DBObject"); + return result && !getJobChangeListener().jobExists("Refresh DBObject"); //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/logging/ErrorLogListenerTest.java b/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/logging/ErrorLogListenerTest.java index 1ccb05bd8d..0ef9e394fd 100644 --- a/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/logging/ErrorLogListenerTest.java +++ b/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/logging/ErrorLogListenerTest.java @@ -53,6 +53,7 @@ public void tearDown() { * the exception that is thrown if the test job was interrupted */ @Test + @SuppressWarnings("nls") public void testIgnoringExceptionLocations() throws InterruptedException { assertFalse("NullPointerException must not have been logged.", errorLogListener.isExceptionLogged(NullPointerException.class)); errorLogListener.ignoreException(NullPointerException.class, "com.avaloq.tools.ddk.test.core.util.ErrorLogListenerTest"); diff --git a/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/DeChKeyboardLayoutTest.java b/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/DeChKeyboardLayoutTest.java index fd895d38e7..4832804ff9 100644 --- a/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/DeChKeyboardLayoutTest.java +++ b/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/DeChKeyboardLayoutTest.java @@ -22,6 +22,7 @@ /** * Checks if the DE_CH keyboard layout works correctly by typing special characters in a test Eclipse editor. */ +@SuppressWarnings("nls") public class DeChKeyboardLayoutTest { private static final String EXPECTED_RESULT = "¨üöä$,.-[]ö{},.-\\'^+\"*ç%&/()=?`¦@#°§¬|¢´~zyZY"; diff --git a/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/SwtBotRadioTest.java b/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/SwtBotRadioTest.java index 0d51f80dba..9a7257ede0 100644 --- a/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/SwtBotRadioTest.java +++ b/com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/swtbot/SwtBotRadioTest.java @@ -26,6 +26,7 @@ /** * Provides test for the SwtBotRadio. */ +@SuppressWarnings("nls") public class SwtBotRadioTest { @Rule diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/TestConfiguration.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/TestConfiguration.java index f38ba6747d..f1b18d7b66 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/TestConfiguration.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/TestConfiguration.java @@ -24,6 +24,7 @@ /** * Test Helper Class Test Configuration. */ +@SuppressWarnings("nls") public final class TestConfiguration { private TestConfiguration() { diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/junit/runners/TestRunRecording.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/junit/runners/TestRunRecording.java index b88a53cd7a..8f93cee8d2 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/junit/runners/TestRunRecording.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/junit/runners/TestRunRecording.java @@ -58,6 +58,7 @@ * Recording of a test run. */ // CHECKSTYLE:OFF +@SuppressWarnings("nls") public class TestRunRecording extends RunListener implements TestStepListener, MouseListener { private static final String NEW_LINE = "\r\n"; private static final String FILE_INFORMATION_SEPARATOR = "__"; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java index 17375e0547..9329c5f628 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java @@ -58,7 +58,7 @@ * Test Helper Class CoreSwtbotTools. */ // CHECKSTYLE:OFF -@SuppressWarnings("PMD.ExcessiveImports") +@SuppressWarnings({"PMD.ExcessiveImports", "nls"}) public final class CoreSwtbotTools { private static final String ARGUMENT_NODES = "nodes"; private static final String ARGUMENT_NODE = "node"; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWizardBot.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWizardBot.java index 058fc83743..34a024f55e 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWizardBot.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWizardBot.java @@ -16,8 +16,8 @@ import java.util.Arrays; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.osgi.util.NLS; import org.eclipse.swtbot.swt.finder.widgets.SWTBotCombo; @@ -28,6 +28,7 @@ /** * An SwtBot to manipulate a wizard. */ +@SuppressWarnings("nls") public class SwtWizardBot extends SwtWorkbenchBot { public static final int SWTBOT_TIMEOUT = 20000; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java index d66bc846b8..050bd0bd62 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java @@ -55,6 +55,7 @@ /** * Extended {@link SWTWorkbenchBot}. */ +@SuppressWarnings("nls") public class SwtWorkbenchBot extends SWTWorkbenchBot { private static final int DELAY_WIZARD_PAGE = 1000; private static final String TIMEOUT_MSG = "Timeout of {0} ms reached while waiting for Button {1} to become active"; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/IsContextMenuVisibleCondition.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/IsContextMenuVisibleCondition.java index 2bf555b160..9f2468f7c8 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/IsContextMenuVisibleCondition.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/IsContextMenuVisibleCondition.java @@ -45,7 +45,7 @@ public boolean test() { @Override public String getFailureMessage() { - StringBuilder msg = new StringBuilder("Error in "); + StringBuilder msg = new StringBuilder("Error in "); //$NON-NLS-1$ msg.append(getClass().getName()); return msg.toString(); } diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/WaitForTable.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/WaitForTable.java index a8fb33b45f..2d125b550a 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/WaitForTable.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/WaitForTable.java @@ -36,13 +36,13 @@ public class WaitForTable extends WaitForObjectCondition { */ public WaitForTable(final Table parent) { super(WidgetMatcherFactory.widgetOfType(TableItem.class)); - Assert.isNotNull(parent, "parent"); + Assert.isNotNull(parent, "parent"); //$NON-NLS-1$ this.parent = parent; } @Override public String getFailureMessage() { - return "Could not find table item matching: " + this.matcher; + return "Could not find table item matching: " + this.matcher; //$NON-NLS-1$ } @Override diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/WaitForTree.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/WaitForTree.java index 47748a4edf..3f7564ccde 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/WaitForTree.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/condition/WaitForTree.java @@ -36,13 +36,13 @@ public class WaitForTree extends WaitForObjectCondition { */ public WaitForTree(final Tree parent) { super(WidgetMatcherFactory.widgetOfType(TreeItem.class)); - Assert.isNotNull(parent, "parent"); + Assert.isNotNull(parent, "parent"); //$NON-NLS-1$ this.parent = parent; } @Override public String getFailureMessage() { - return "Could not find tree item matching: " + this.matcher; + return "Could not find tree item matching: " + this.matcher; //$NON-NLS-1$ } @Override diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/AnyWidgetMatcher.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/AnyWidgetMatcher.java index d4dd6452dc..f02ef8ba67 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/AnyWidgetMatcher.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/AnyWidgetMatcher.java @@ -27,7 +27,7 @@ public boolean matches(final Object item) { @Override public void describeTo(final Description description) { - description.appendText("any widget not null"); + description.appendText("any widget not null"); //$NON-NLS-1$ } /** diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/EditorRegExMatcher.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/EditorRegExMatcher.java index fd6a1b344d..c02787096d 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/EditorRegExMatcher.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/EditorRegExMatcher.java @@ -22,6 +22,7 @@ * A custom matcher that identifies an editor by applying a regular expression * on its name. */ +@SuppressWarnings("nls") public class EditorRegExMatcher extends BaseMatcher { /** The regular expression matcher for the editor's name. */ private final Matcher regExMatcher; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/ViewRegExMatcher.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/ViewRegExMatcher.java index c4fecb3fee..38daf53b03 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/ViewRegExMatcher.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/matcher/ViewRegExMatcher.java @@ -28,7 +28,7 @@ public class ViewRegExMatcher extends BaseMatcher { public ViewRegExMatcher(final String regex) { Pattern pattern = Pattern.compile(regex); - this.regExMatcher = pattern.matcher(""); + this.regExMatcher = pattern.matcher(""); //$NON-NLS-1$ } @Override @@ -45,7 +45,7 @@ public boolean matches(final Object item) { @Override public void describeTo(final Description description) { - description.appendText("a view with title matching regex"); + description.appendText("a view with title matching regex"); //$NON-NLS-1$ } /** diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/PreferenceUtil.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/PreferenceUtil.java index ea23e02bc5..670344038b 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/PreferenceUtil.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/PreferenceUtil.java @@ -19,6 +19,7 @@ /** * Provides utility methods to open the preference dialog. */ +@SuppressWarnings("nls") public final class PreferenceUtil { private static final String SHELL_PREFERENCES = "Preferences"; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/ShellUiTestUtil.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/ShellUiTestUtil.java index fa93b2a575..4110f6eefa 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/ShellUiTestUtil.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/ShellUiTestUtil.java @@ -54,7 +54,7 @@ public Boolean run() { @Override public void describeTo(final Description description) { - description.appendText("Shell for " + clazz.getName()); + description.appendText("Shell for " + clazz.getName()); //$NON-NLS-1$ } })); } diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotControlUtils.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotControlUtils.java index b047c6221c..f6cde77fa6 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotControlUtils.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotControlUtils.java @@ -21,6 +21,7 @@ /** * Test Helper Class SwtBotControlUtils. */ +@SuppressWarnings("nls") public final class SwtBotControlUtils { private static final int THREAD_SLEEP_TIME = 100; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotToolbarButtonUtil.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotToolbarButtonUtil.java index 9ae4c9134a..a3baf65a93 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotToolbarButtonUtil.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotToolbarButtonUtil.java @@ -29,7 +29,7 @@ public final class SwtBotToolbarButtonUtil { * @return {@code true} if the toolbar button is selected, {@code false} otherwise */ public static boolean isSelected(final SWTBotToolbarButton toolbarButton) { - Assert.isNotNull(toolbarButton, "toolbarButton"); + Assert.isNotNull(toolbarButton, "toolbarButton"); //$NON-NLS-1$ return UIThreadRunnable.syncExec(toolbarButton.display, new BoolResult() { @Override public Boolean run() { diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotUtil.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotUtil.java index d96617d536..2f44feb862 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotUtil.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotUtil.java @@ -25,6 +25,7 @@ public final class SwtBotUtil { /** * Initialize the bot's preferences. */ + @SuppressWarnings("nls") public static void initializeBotPreferences() { // NOTE: the keyboard layout must match the keyboard used for the OS. // The default keyboard layouts are: EN_US, MAC_EN_US, EN_GB, MAC_EN_GB, FR_FR, DE_DE. diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotViewUtil.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotViewUtil.java index 544c806bdd..976cabc7df 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotViewUtil.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotViewUtil.java @@ -18,6 +18,7 @@ /** * Utility class for {@link SWTBotView}. */ +@SuppressWarnings("nls") public final class SwtBotViewUtil { private static final int TIMEOUT_FOR_VIEW_TO_LOAD = 20000; private static final String LOADING_VIEW_MESSAGE = "Loading..."; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotWizardUtil.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotWizardUtil.java index e0e11cdf21..4b7410809a 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotWizardUtil.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotWizardUtil.java @@ -40,6 +40,7 @@ private SwtBotWizardUtil() { * @param folderName * the folder name */ + @SuppressWarnings("nls") public static void selectProjectFolder(final SwtWorkbenchBot bot, final String folderName) { SWTBotView packageExplorer = bot.viewByTitle("Project Explorer"); packageExplorer.show(); diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/TreeItemUiTestUtil.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/TreeItemUiTestUtil.java index 9b984fefb2..26e29428ff 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/TreeItemUiTestUtil.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/TreeItemUiTestUtil.java @@ -69,7 +69,7 @@ private static class WaitForTreeItem extends WaitForObjectCondition { @Override public String getFailureMessage() { - return "Could not find tree item matching: " + this.matcher; + return "Could not find tree item matching: " + this.matcher; //$NON-NLS-1$ } @Override diff --git a/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/formatting/ExportFormattingTest.java b/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/formatting/ExportFormattingTest.java index 1b96375372..f88ce7b667 100644 --- a/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/formatting/ExportFormattingTest.java +++ b/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/formatting/ExportFormattingTest.java @@ -18,6 +18,7 @@ /** * Tests formatting of Export source fragments. */ +@SuppressWarnings("nls") public class ExportFormattingTest extends AbstractFormattingTest { @Override diff --git a/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopingTest.java b/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopingTest.java index f8034d1f7d..c691ccb852 100644 --- a/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopingTest.java +++ b/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopingTest.java @@ -21,14 +21,15 @@ import com.avaloq.tools.ddk.xtext.export.export.ExportModel; import com.avaloq.tools.ddk.xtext.export.export.ExportPackage; +import com.avaloq.tools.ddk.xtext.scoping.IDomain.NullMapper; import com.avaloq.tools.ddk.xtext.test.export.util.ExportTestUtil; import com.avaloq.tools.ddk.xtext.test.scoping.AbstractScopingTest; -import com.avaloq.tools.ddk.xtext.scoping.IDomain.NullMapper; /** * Tests scoping of Code Tab Data Source */ +@SuppressWarnings("nls") public class ExportScopingTest extends AbstractScopingTest { public ExportScopingTest() { super(new NullMapper()); diff --git a/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/validation/ExportValidationTest.java b/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/validation/ExportValidationTest.java index c961919772..7d0dc1c518 100644 --- a/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/validation/ExportValidationTest.java +++ b/com.avaloq.tools.ddk.xtext.export.test/src/com/avaloq/tools/ddk/xtext/export/validation/ExportValidationTest.java @@ -19,6 +19,7 @@ /** * Tests validation of Export sources. */ +@SuppressWarnings("nls") public class ExportValidationTest extends AbstractValidationTest { @Override diff --git a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java index ea8c518876..a676a8a720 100644 --- a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java @@ -31,7 +31,7 @@ public class ExportOutlineTreeProvider extends DefaultOutlineTreeProvider { /** * Create the child nodes for a given export model: its interfaces and exports. - * + * * @param parentNode * the parent node * @param modelElement @@ -43,7 +43,7 @@ protected void _createChildren(final DocumentRootNode parentNode, final ExportMo Image importContainerImage = JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPCONT); if (!modelElement.getImports().isEmpty()) { - createEStructuralFeatureNode(parentNode, modelElement, ExportPackage.Literals.EXPORT_MODEL__IMPORTS, importContainerImage, "import declarations", false); + createEStructuralFeatureNode(parentNode, modelElement, ExportPackage.Literals.EXPORT_MODEL__IMPORTS, importContainerImage, "import declarations", false); //$NON-NLS-1$ } for (EObject content : modelElement.getInterfaces()) { createNode(parentNode, content); @@ -55,7 +55,7 @@ protected void _createChildren(final DocumentRootNode parentNode, final ExportMo /** * Specify Interface as leaf. - * + * * @param modelElement * the interface * @return true @@ -68,7 +68,7 @@ protected boolean _isLeaf(final Interface modelElement) { /** * Specify Export as leaf. - * + * * @param modelElement * the export * @return true diff --git a/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/validation/ExportValidator.java b/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/validation/ExportValidator.java index 298d4b1f7e..395841af8b 100644 --- a/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/validation/ExportValidator.java +++ b/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/validation/ExportValidator.java @@ -47,6 +47,7 @@ /** * Validations for the export language. */ +@SuppressWarnings("nls") public class ExportValidator extends AbstractExportValidator { /** diff --git a/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/Activator.java b/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/Activator.java index 118c62c61d..4903ca480a 100644 --- a/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/Activator.java +++ b/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/Activator.java @@ -20,7 +20,7 @@ */ public class Activator extends ExpressionActivator { - public static final String COM_AVALOQ_TOOLS_DDK_XTEXT_EXPRESSION_GENMODEL = "com.avaloq.tools.ddk.xtext.expression.GenModel"; + public static final String COM_AVALOQ_TOOLS_DDK_XTEXT_EXPRESSION_GENMODEL = "com.avaloq.tools.ddk.xtext.expression.GenModel"; //$NON-NLS-1$ @Override protected Module getRuntimeModule(final String grammar) { diff --git a/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/GenModelQualifiedNameProvider.java b/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/GenModelQualifiedNameProvider.java index d8170403d3..ce9030a459 100644 --- a/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/GenModelQualifiedNameProvider.java +++ b/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/GenModelQualifiedNameProvider.java @@ -45,7 +45,7 @@ public QualifiedName get() { } private String getCacheKey() { - return "fqn"; + return "fqn"; //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/GenModelRuntimeModule.java b/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/GenModelRuntimeModule.java index 8332cb5743..75d32842b2 100644 --- a/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/GenModelRuntimeModule.java +++ b/com.avaloq.tools.ddk.xtext.expression.ui/src/com/avaloq/tools/ddk/xtext/expression/ui/internal/GenModelRuntimeModule.java @@ -18,6 +18,7 @@ /** * Minimal Guice runtime module for GenModel support. */ +@SuppressWarnings("nls") public class GenModelRuntimeModule extends AbstractGenericResourceRuntimeModule { @Override diff --git a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java index 2cbd44c991..071b7df0e5 100644 --- a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java +++ b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java @@ -36,6 +36,7 @@ *

* Note that many of these methods are called from Xtend and Xpand and will thus not show up when doing a find references in Eclipse. */ +@SuppressWarnings("nls") public class CompilationContext { /** Class-wide logger. */ diff --git a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GenModelUtil2.java b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GenModelUtil2.java index f8fd46b9bc..7bbc4e2161 100644 --- a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GenModelUtil2.java +++ b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GenModelUtil2.java @@ -127,7 +127,7 @@ public static GenModel findGenModel(final EModelElement eModelElement, final Res // CHECKSTYLE:CHECK-OFF IllegalCatch } catch (RuntimeException e) { // CHECKSTYLE:CHECK-ON IllegalCatch - LOGGER.error(NLS.bind("Exception in findGenModel ({0})", eModelElement), e); + LOGGER.error(NLS.bind("Exception in findGenModel ({0})", eModelElement), e); //$NON-NLS-1$ } return null; diff --git a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GeneratorSupport.java b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GeneratorSupport.java index 5746ad3690..d23fedd31f 100644 --- a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GeneratorSupport.java +++ b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GeneratorSupport.java @@ -16,8 +16,8 @@ import java.net.URL; import java.net.URLClassLoader; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.resources.ResourcesPlugin; @@ -34,6 +34,7 @@ /** * Support methods for Expression DSL based generators. */ +@SuppressWarnings("nls") public class GeneratorSupport { /** Class-wide logger. */ diff --git a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GeneratorUtil.java b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GeneratorUtil.java index cc940580c5..5ccd0b5d9c 100644 --- a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GeneratorUtil.java +++ b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GeneratorUtil.java @@ -37,7 +37,7 @@ */ public class GeneratorUtil { - public static final String ISO_8859_1 = "ISO-8859-1"; + public static final String ISO_8859_1 = "ISO-8859-1"; //$NON-NLS-1$ /** * Hidden constructor. diff --git a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/Graph.java b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/Graph.java index 833e6671e8..295d3197d7 100644 --- a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/Graph.java +++ b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/Graph.java @@ -180,7 +180,7 @@ public List sort() { // Check to see if all edges are removed for (Node n : nodes.values()) { if (!n.inEdges.isEmpty()) { - throw new IllegalStateException("Cycle present, topological sort not possible: " + n.ref + " -> " + n.inEdges); + throw new IllegalStateException("Cycle present, topological sort not possible: " + n.ref + " -> " + n.inEdges); //$NON-NLS-1$ //$NON-NLS-2$ } } diff --git a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/builder/FormatBuilderParticipantTest.java b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/builder/FormatBuilderParticipantTest.java index ed47fca61d..179f866d41 100644 --- a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/builder/FormatBuilderParticipantTest.java +++ b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/builder/FormatBuilderParticipantTest.java @@ -24,9 +24,9 @@ import org.junit.Test; import org.mockito.ArgumentMatcher; +import com.avaloq.tools.ddk.xtext.format.ui.builder.FormatBuilderParticipant; import com.avaloq.tools.ddk.xtext.test.AbstractXtextTest; import com.avaloq.tools.ddk.xtext.test.AbstractXtextTestUtil; -import com.avaloq.tools.ddk.xtext.format.ui.builder.FormatBuilderParticipant; import com.google.common.collect.ImmutableList; import com.google.inject.Guice; import com.google.inject.Injector; @@ -35,6 +35,7 @@ /** * A test class for {@link FormatBuilderParticipant} and com.avaloq.tools.ddk.xtext.ui.builder.AbstractConditionalBuilderParticipant */ +@SuppressWarnings("nls") public class FormatBuilderParticipantTest extends AbstractXtextTest { private static final String TEST_PROJECT_NAME = "resource"; diff --git a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/formatting/FormatFormattingTest.java b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/formatting/FormatFormattingTest.java index 25882cca80..2f14dc5670 100644 --- a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/formatting/FormatFormattingTest.java +++ b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/formatting/FormatFormattingTest.java @@ -11,8 +11,8 @@ package com.avaloq.tools.ddk.xtext.format.formatting; import com.avaloq.tools.ddk.xtext.test.TestSource; -import com.avaloq.tools.ddk.xtext.test.formatting.AbstractFormattingTest; import com.avaloq.tools.ddk.xtext.test.format.util.FormatTestUtil; +import com.avaloq.tools.ddk.xtext.test.formatting.AbstractFormattingTest; public class FormatFormattingTest extends AbstractFormattingTest { @@ -25,7 +25,7 @@ protected FormatTestUtil getXtextTestUtil() { @Override protected String getResourceContent(final String sourceFileName) { // return content with line terminators as will be produced by formatter - return TestSource.normalizeLineSeparators(super.getResourceContent(sourceFileName), System.getProperty("line.separator")); + return TestSource.normalizeLineSeparators(super.getResourceContent(sourceFileName), System.getProperty("line.separator")); //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatScopingTest.java b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatScopingTest.java index 8762e63501..d236fee5bc 100644 --- a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatScopingTest.java +++ b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatScopingTest.java @@ -43,6 +43,7 @@ /** * Scoping tests for the Format DSL. */ +@SuppressWarnings("nls") public class FormatScopingTest extends AbstractScopingTest { private static final String C_FORMAT = "C.format"; diff --git a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/validation/FormatValidationTest.java b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/validation/FormatValidationTest.java index 1e3919b307..8fcc918abb 100644 --- a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/validation/FormatValidationTest.java +++ b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/format/validation/FormatValidationTest.java @@ -23,6 +23,7 @@ import com.google.common.collect.Lists; +@SuppressWarnings("nls") public class FormatValidationTest extends AbstractValidationTest { private static final String INT_EXP_RULE = "INT_EXP {}"; private static final String WILDCARD_RULE = "* {}"; diff --git a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/test/format/util/FormatTestUtil.java b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/test/format/util/FormatTestUtil.java index 289ccd3ec5..57cd3a75f0 100644 --- a/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/test/format/util/FormatTestUtil.java +++ b/com.avaloq.tools.ddk.xtext.format.test/src/com/avaloq/tools/ddk/xtext/test/format/util/FormatTestUtil.java @@ -17,15 +17,16 @@ import org.eclipse.emf.ecore.EObject; import org.eclipse.xtext.resource.XtextResourceSet; -import com.avaloq.tools.ddk.xtext.test.AbstractXtextTestUtil; -import com.avaloq.tools.ddk.xtext.test.ITestProjectManager; -import com.avaloq.tools.ddk.xtext.test.PluginTestProjectManager; import com.avaloq.tools.ddk.xtext.format.FormatConstants; import com.avaloq.tools.ddk.xtext.format.format.FormatConfiguration; import com.avaloq.tools.ddk.xtext.format.ui.internal.FormatActivator; +import com.avaloq.tools.ddk.xtext.test.AbstractXtextTestUtil; +import com.avaloq.tools.ddk.xtext.test.ITestProjectManager; +import com.avaloq.tools.ddk.xtext.test.PluginTestProjectManager; import com.google.inject.Injector; +@SuppressWarnings("nls") public final class FormatTestUtil extends AbstractXtextTestUtil { public static final String TEST_MODEL_NAME = "FormatterTestLanguage"; public static final String NEW_LINE = "\n"; @@ -43,7 +44,7 @@ private static final class InstanceHolder { private static final FormatTestUtil INSTANCE = new FormatTestUtil(); public static FormatTestUtil get() { - return INSTANCE; + return INSTANCE; } } diff --git a/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java b/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java index 5212f8c0c6..f6c796f659 100644 --- a/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java @@ -43,7 +43,7 @@ public FormatLabelProvider(final AdapterFactoryLabelProvider delegate) { * @return the string */ public String text(final WildcardRule element) { - return "*"; + return "*"; //$NON-NLS-1$ } /** diff --git a/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/quickfix/FormatQuickfixProvider.java b/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/quickfix/FormatQuickfixProvider.java index edac5f5482..e578c2adf1 100644 --- a/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/quickfix/FormatQuickfixProvider.java +++ b/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/quickfix/FormatQuickfixProvider.java @@ -28,6 +28,7 @@ /** * The quickfix provider. */ +@SuppressWarnings("nls") public class FormatQuickfixProvider extends DefaultQuickfixProvider { /** diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/formatting/FormatFormatter.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/formatting/FormatFormatter.java index 5ca9b0ec56..db1c21d752 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/formatting/FormatFormatter.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/formatting/FormatFormatter.java @@ -29,6 +29,7 @@ * on how and when to use it * Also see {@link org.eclipse.xtext.xtext.XtextFormattingTokenSerializer} as an example */ +@SuppressWarnings("nls") public class FormatFormatter extends AbstractDeclarativeFormatter { private static final int LINE_LENGTH = 120; diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/generator/FormatGeneratorUtil.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/generator/FormatGeneratorUtil.java index 90452b40ac..065a95572c 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/generator/FormatGeneratorUtil.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/generator/FormatGeneratorUtil.java @@ -40,6 +40,7 @@ /** * Various utility functions for the format generator. */ +@SuppressWarnings("nls") public final class FormatGeneratorUtil { /** diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/generator/FormatOutputConfigurationProvider.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/generator/FormatOutputConfigurationProvider.java index 49ca7023d5..b8839adbb3 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/generator/FormatOutputConfigurationProvider.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/generator/FormatOutputConfigurationProvider.java @@ -21,6 +21,7 @@ /** * Provides output configurations for the generation of formatters. */ +@SuppressWarnings("nls") public class FormatOutputConfigurationProvider extends OutputConfigurationProvider { @Override diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/naming/FormatQualifiedNameConverter.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/naming/FormatQualifiedNameConverter.java index 8df539a038..748c96355a 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/naming/FormatQualifiedNameConverter.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/naming/FormatQualifiedNameConverter.java @@ -21,6 +21,7 @@ /** * Extension of the default implementation of the qualified name converter. */ +@SuppressWarnings("nls") public class FormatQualifiedNameConverter extends IQualifiedNameConverter.DefaultImpl { private static final Pattern STRING_PATTERN = Pattern.compile("\".*\""); diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/naming/FormatScopeNameProvider.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/naming/FormatScopeNameProvider.java index b6ae8d8602..63a07033f6 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/naming/FormatScopeNameProvider.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/naming/FormatScopeNameProvider.java @@ -61,7 +61,7 @@ public String caseRuleCall(final RuleCall object) { @Override public String caseCompoundElement(final org.eclipse.xtext.CompoundElement object) { - return ""; + return ""; //$NON-NLS-1$ } }; diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/resource/FormatResource.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/resource/FormatResource.java index 53567d2d6f..947b2cc053 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/resource/FormatResource.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/resource/FormatResource.java @@ -12,8 +12,8 @@ import java.lang.reflect.Method; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.eclipse.emf.common.util.EList; import org.eclipse.emf.ecore.EObject; import org.eclipse.xtext.xbase.resource.BatchLinkableResource; @@ -27,7 +27,7 @@ *

* The implementation is a hack of sorts, but this will have to serve until a cleaner solution can be found. */ -@SuppressWarnings("restriction") +@SuppressWarnings({"restriction", "nls"}) public class FormatResource extends BatchLinkableResource { private static final Logger LOGGER = LogManager.getLogger(FormatResource.class); diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/resource/FormatResourceDescriptionStrategy.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/resource/FormatResourceDescriptionStrategy.java index 92cd639e01..466bacbbda 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/resource/FormatResourceDescriptionStrategy.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/resource/FormatResourceDescriptionStrategy.java @@ -36,6 +36,7 @@ * specifications. Therefore, besides a standard export, all the objects are exported under their fingerprints. Therefore when the content (text, value) of the * object changes this would cause a proper invalidations of the dependent formats. */ +@SuppressWarnings("nls") public class FormatResourceDescriptionStrategy extends DefaultResourceDescriptionStrategy { /** diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatLinkingService.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatLinkingService.java index ec20db09db..d2d16072aa 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatLinkingService.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatLinkingService.java @@ -34,6 +34,7 @@ /** * A linking service for the Format language. */ +@SuppressWarnings("nls") public class FormatLinkingService extends AbstractFastLinkingService { /** diff --git a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatScopeUtil.java b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatScopeUtil.java index 381c5038a8..b23040c5f2 100644 --- a/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatScopeUtil.java +++ b/com.avaloq.tools.ddk.xtext.format/src/com/avaloq/tools/ddk/xtext/format/scoping/FormatScopeUtil.java @@ -397,7 +397,7 @@ private URI findExtensionURI(final Resource context, final String extensionName) * @return short name of the format/grammar */ private String convertPathNameToShortName(final String extensionName) { - String[] str = extensionName.split("\\."); + String[] str = extensionName.split("\\."); //$NON-NLS-1$ return str[str.length - 1]; } } diff --git a/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CodeGenerationXTest.java b/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CodeGenerationXTest.java index 2d0e111353..00fa408b08 100644 --- a/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CodeGenerationXTest.java +++ b/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CodeGenerationXTest.java @@ -30,6 +30,7 @@ /** * Tests the code generation as implemented by CodeGenerationX wrapped by {@link CompilerX}. */ +@SuppressWarnings("nls") public class CodeGenerationXTest extends AbstractXtextTest { private CompilerX getCompiler() { diff --git a/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CompilationContextTest.java b/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CompilationContextTest.java index 321a9d684c..31a6b9d154 100644 --- a/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CompilationContextTest.java +++ b/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CompilationContextTest.java @@ -26,6 +26,7 @@ import com.avaloq.tools.ddk.xtext.expression.generator.CompilationContext; +@SuppressWarnings("nls") public class CompilationContextTest { @Test diff --git a/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/ExpressionsExtentionsTest.java b/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/ExpressionsExtentionsTest.java index c55344fafd..bc4be72506 100644 --- a/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/ExpressionsExtentionsTest.java +++ b/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/ExpressionsExtentionsTest.java @@ -22,6 +22,7 @@ import com.avaloq.tools.ddk.xtext.test.AbstractXtextTest; +@SuppressWarnings("nls") public class ExpressionsExtentionsTest extends AbstractXtextTest { @Override diff --git a/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/test/util/GraphTest.java b/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/test/util/GraphTest.java index a822ee5125..670e99d62a 100644 --- a/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/test/util/GraphTest.java +++ b/com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/test/util/GraphTest.java @@ -24,7 +24,7 @@ import com.google.common.collect.Multimap; -@SuppressWarnings("PMD.JUnitAssertionsShouldIncludeMessage") +@SuppressWarnings({"PMD.JUnitAssertionsShouldIncludeMessage", "nls"}) public class GraphTest { // CHECKSTYLE:CONSTANTS-OFF diff --git a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java index d374963894..2d2aafe016 100644 --- a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java @@ -31,7 +31,7 @@ public class ScopeOutlineTreeProvider extends DefaultOutlineTreeProvider { /** * Create the child nodes for a given native Context. We only show quick fixes. - * + * * @param parentNode * the parent node * @param modelElement @@ -43,7 +43,7 @@ protected void _createChildren(final DocumentRootNode parentNode, final ScopeMod Image importContainerImage = JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPCONT); if (!modelElement.getImports().isEmpty()) { - createEStructuralFeatureNode(parentNode, modelElement, ScopePackage.Literals.SCOPE_MODEL__IMPORTS, importContainerImage, "import declarations", false); + createEStructuralFeatureNode(parentNode, modelElement, ScopePackage.Literals.SCOPE_MODEL__IMPORTS, importContainerImage, "import declarations", false); //$NON-NLS-1$ } for (EObject content : modelElement.getScopes()) { @@ -53,7 +53,7 @@ protected void _createChildren(final DocumentRootNode parentNode, final ScopeMod /** * Specify Expression as leaf. - * + * * @param modelElement * the expression * @return true @@ -66,7 +66,7 @@ protected boolean _isLeaf(final Expression modelElement) { /** * Specify ScopeRule as leaf. - * + * * @param modelElement * the rule * @return true diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/ScopeUtil.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/ScopeUtil.java index b7318e0622..8fb2055331 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/ScopeUtil.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/ScopeUtil.java @@ -76,6 +76,7 @@ public static String getPackageName(final Import importedPackage) { * rule to calculate signature for * @return string signature */ + @SuppressWarnings("nls") public static String getSignature(final ScopeRule rule) { // NOPMD NPathComplexity // CHECKSTYLE:OFF MagicNumber StringBuffer result = new StringBuffer(60); diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/conversion/ScopeValueConverterService.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/conversion/ScopeValueConverterService.java index a0934952ee..7bdcb2f909 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/conversion/ScopeValueConverterService.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/conversion/ScopeValueConverterService.java @@ -35,13 +35,13 @@ public class ScopeValueConverterService extends ExpressionValueConverterService private static final class ExtensionIdValueConverter extends QualifiedNameValueConverter { @Override protected String getNamespaceDelimiter() { - return "::"; + return "::"; //$NON-NLS-1$ } } /** * Value converter for QualifiedID rule. - * + * * @return value converter */ @ValueConverter(rule = "QualifiedID") @@ -51,7 +51,7 @@ public IValueConverter convertQualifiedID() { /** * Value converter for DottedID rule. - * + * * @return value converter */ @ValueConverter(rule = "DottedID") diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/formatting/ScopeFormatter.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/formatting/ScopeFormatter.java index c719977782..29c6b8d67b 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/formatting/ScopeFormatter.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/formatting/ScopeFormatter.java @@ -28,6 +28,7 @@ * on how and when to use it * Also see {@link org.eclipse.xtext.xtext.XtextFormattingTokenSerializer} as an example */ +@SuppressWarnings("nls") public class ScopeFormatter extends AbstractDeclarativeFormatter { private static final int MAX_LINE_LENGTH = 140; diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/linking/ScopeLinkingService.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/linking/ScopeLinkingService.java index 35e1fb3d31..2b3c1e7508 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/linking/ScopeLinkingService.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/linking/ScopeLinkingService.java @@ -41,6 +41,7 @@ * Scope specific linking service to handle includes of other scope files. We don't use the scope provider for this as scope files * from anywhere can be included. */ +@SuppressWarnings("nls") public class ScopeLinkingService extends DefaultLinkingService { /** Class-wide logger. */ diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/naming/ScopeQualifiedNameConverter.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/naming/ScopeQualifiedNameConverter.java index 0682c255cf..46aa4c2412 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/naming/ScopeQualifiedNameConverter.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/naming/ScopeQualifiedNameConverter.java @@ -20,7 +20,7 @@ public class ScopeQualifiedNameConverter extends IQualifiedNameConverter.Default @Override public String getDelimiter() { - return "::"; + return "::"; //$NON-NLS-1$ } } diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/resource/ScopeResourceDescriptionStrategy.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/resource/ScopeResourceDescriptionStrategy.java index 873c4ebbaa..0e5fdac14f 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/resource/ScopeResourceDescriptionStrategy.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/resource/ScopeResourceDescriptionStrategy.java @@ -13,8 +13,8 @@ import java.util.Collections; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.eclipse.emf.ecore.EObject; import org.eclipse.emf.ecore.util.EcoreUtil; import org.eclipse.xtext.naming.QualifiedName; @@ -34,6 +34,7 @@ * referencing resources. The fingerprint also includes the hash of all included scopes, so that regeneration will be triggered if the included scope was * changed. */ +@SuppressWarnings("nls") public class ScopeResourceDescriptionStrategy extends DefaultResourceDescriptionStrategy { private static final Logger LOG = LogManager.getLogger(ScopeResourceDescriptionStrategy.class); diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java index d0b3c0a4d7..c90bb364b9 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java @@ -173,7 +173,7 @@ private IScope getIncludedScopes(final IScope parent, final ScopeModel context) @Override public QualifiedName apply(final EObject from) { ScopeDefinition scopeDef = (ScopeDefinition) from; - return QualifiedName.create(scopeDef.getName() != null ? scopeDef.getName() : ""); + return QualifiedName.create(scopeDef.getName() != null ? scopeDef.getName() : ""); //$NON-NLS-1$ } })); } diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractTest.java index cc8f7dfccc..9917d658cc 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractTest.java @@ -49,6 +49,7 @@ * All exceptions are wrapped and handed over to the JUnit framework. */ @RunWith(XtextClassRunner.class) +@SuppressWarnings("nls") public abstract class AbstractTest { /** diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractTestUtil.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractTestUtil.java index e1a2a1d0e6..a0f1bf4db9 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractTestUtil.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractTestUtil.java @@ -80,7 +80,7 @@ public Object getEditorJobFamily(final IEditorPart editor) { Object jobFamily = null; try { // Job family is represented by the edited source version - Method method = editorClass.getMethod("getSourceVersion", (Class[]) null); + Method method = editorClass.getMethod("getSourceVersion", (Class[]) null); //$NON-NLS-1$ jobFamily = method.invoke(editor, (Object[]) null); // CHECKSTYLE:OFF } catch (Exception e) { diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractUtilTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractUtilTest.java index 63e692a1a3..9a75c7f12d 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractUtilTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractUtilTest.java @@ -32,6 +32,7 @@ /** * A base class for util test classes, which prepares common required mocks. */ +@SuppressWarnings("nls") public abstract class AbstractUtilTest extends AbstractXtextTest { public static final String TEST_PROJECT_NAME = "TestProjectName"; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java index 9032a4011f..327f336c6a 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java @@ -42,6 +42,7 @@ /** * Abstract class that supports Xtend based test implementations to use markers in the test sources. */ +@SuppressWarnings("nls") public abstract class AbstractXtextMarkerBasedTest extends AbstractXtextTest { private static final String INVALID_TEST_CONFIGURATION = "Invalid test configuration. Missing org.eclipse.xtend.lib in MANIFEST.MF in this plugin?"; //$NON-NLS-1$ diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextTest.java index 624e8d64a8..cbd03bec60 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextTest.java @@ -52,7 +52,7 @@ protected XtextTestSource createTestSource(final String sourceFileName, final St */ @Override protected String getTestSourceFileName() { - return this.getTestSourceModelName() + "." + getXtextTestUtil().getFileExtension(); + return this.getTestSourceModelName() + '.' + getXtextTestUtil().getFileExtension(); } /** diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AcfContentAssistProcessorTestBuilder.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AcfContentAssistProcessorTestBuilder.java index 8415facde0..e1afd919f9 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AcfContentAssistProcessorTestBuilder.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AcfContentAssistProcessorTestBuilder.java @@ -48,7 +48,7 @@ * {@link ConfigurableCompletionProposal}s. * */ -@SuppressWarnings({"PMD.SignatureDeclareThrowsException"}) +@SuppressWarnings({"PMD.SignatureDeclareThrowsException", "nls"}) public class AcfContentAssistProcessorTestBuilder extends ContentAssistProcessorTestBuilder { private final ResourceLoadHelper loadHelper; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/IllegalJUnitAnnotation.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/IllegalJUnitAnnotation.java index 9883b48a22..5fb849ad79 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/IllegalJUnitAnnotation.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/IllegalJUnitAnnotation.java @@ -17,7 +17,7 @@ class IllegalJUnitAnnotation extends RuntimeException { private static final long serialVersionUID = 1L; IllegalJUnitAnnotation() { - super("Invalid annotation found. BeforeClass and AfterClass annotations are not permitted when using the AbstractXtextTest framework. Use the methods 'beforeAllTests' and 'afterAllTests' instead."); + super("Invalid annotation found. BeforeClass and AfterClass annotations are not permitted when using the AbstractXtextTest framework. Use the methods 'beforeAllTests' and 'afterAllTests' instead."); //$NON-NLS-1$ } IllegalJUnitAnnotation(final String message) { diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/TestSource.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/TestSource.java index f14180b0bb..8ed06c9cdd 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/TestSource.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/TestSource.java @@ -18,15 +18,16 @@ import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.emf.common.util.URI; +import org.eclipse.emf.common.util.WrappedException; import org.eclipse.xtext.util.StringInputStream; -import org.eclipse.emf.common.util.WrappedException; import com.google.common.io.Resources; /** * Container for all source relevant information. */ +@SuppressWarnings("nls") public class TestSource { private static final Pattern NL_PATTERN = Pattern.compile("\\r?\\n"); @@ -47,7 +48,7 @@ public TestSource(final String sourceFileName, final String content) { * Called by {@link ITestProjectManager#addSourceToProject(TestSource)} when this source was added. *

* TODO Implement a cleaner solution where IFile and URI are not stored by TestSource. - * + * * @param newFile * file associated with this test source * @param newUri @@ -60,7 +61,7 @@ public void accept(final IFile newFile, final URI newUri) { /** * Returns the sourceFileName. - * + * * @return the sourceFileName */ public String getSourceFileName() { @@ -69,7 +70,7 @@ public String getSourceFileName() { /** * Returns the iFile. - * + * * @return the iFile */ public IFile getiFile() { @@ -78,7 +79,7 @@ public IFile getiFile() { /** * Returns the Uri. - * + * * @return the Uri */ public URI getUri() { @@ -87,7 +88,7 @@ public URI getUri() { /** * Returns the content. - * + * * @return the content */ public String getContent() { @@ -96,7 +97,7 @@ public String getContent() { /** * Set the the source content to the new content given. - * + * * @param newContent * String with the new source content */ @@ -111,7 +112,7 @@ public void setContent(final String newContent) { /** * Loads the given source from the classpath and normalizes the line endings of the content. - * + * * @param clazz * context class * @param sourceFileName @@ -129,7 +130,7 @@ public static String getResourceContent(final Class clazz, final String sourc /** * Returns a string with line separators normalized to the given terminator. - * + * * @param str * string to normalize, must not be {@code null} * @param lineSeparator diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/XtextTestProjectManager.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/XtextTestProjectManager.java index 224f34562e..22c9007e01 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/XtextTestProjectManager.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/XtextTestProjectManager.java @@ -33,6 +33,7 @@ /** * Simple Test project manager for SDK tests. */ +@SuppressWarnings("nls") public class XtextTestProjectManager implements ITestProjectManager { protected static final String TEST_PROJECT_NAME = "TEST"; private final Map testSources = Maps.newHashMap(); @@ -148,7 +149,7 @@ public URI createTestSourceUri(final String encodedFileName) { * @return the {@link URI} for the given file name */ public URI createPlatformUri(final String encodedFileName) { - return URI.createPlatformResourceURI('/' + TEST_PROJECT_NAME + "/" + encodedFileName, true); + return URI.createPlatformResourceURI('/' + TEST_PROJECT_NAME + '/' + encodedFileName, true); } } diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/conversion/AbstractValueConverterServiceTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/conversion/AbstractValueConverterServiceTest.java index 1a877b1ea9..b7e6655b13 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/conversion/AbstractValueConverterServiceTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/conversion/AbstractValueConverterServiceTest.java @@ -35,6 +35,7 @@ /** * Base class for testing a language {@link IValueConverterService} implementation. */ +@SuppressWarnings("nls") public abstract class AbstractValueConverterServiceTest extends AbstractXtextTest { /** ID regular expression does not allow digits as first character. */ public static final String INVALID_ID_NUMBER = "1something"; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/formatting/AbstractFormattingTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/formatting/AbstractFormattingTest.java index 561c3aff58..7fa54de3e4 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/formatting/AbstractFormattingTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/formatting/AbstractFormattingTest.java @@ -27,6 +27,7 @@ /** * Base class for formatting tests. */ +@SuppressWarnings("nls") public abstract class AbstractFormattingTest extends AbstractXtextTest { private static final String CR_LF = "\r\n"; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/generator/AbstractGeneratorTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/generator/AbstractGeneratorTest.java index 9e36e07819..1877aebb2f 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/generator/AbstractGeneratorTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/generator/AbstractGeneratorTest.java @@ -60,7 +60,7 @@ /** * A base class for xtext generator tests. Allows creating a project and adding files. */ -@SuppressWarnings({"PMD.AbstractClassWithoutAbstractMethod", "restriction"}) +@SuppressWarnings({"PMD.AbstractClassWithoutAbstractMethod", "restriction", "nls"}) public abstract class AbstractGeneratorTest { private static final String MESSAGE_GENERATED_FILE_MUST_EXIST = "Generated file ''{0}'' must exist."; private static final String MESSAGE_GENERATED_CODE_MUST_BE_CORRECT = "Generated contents of ''{0}'' must be correct."; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/linking/AbstractLinkingTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/linking/AbstractLinkingTest.java index 14e5266204..cef5f35529 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/linking/AbstractLinkingTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/linking/AbstractLinkingTest.java @@ -23,11 +23,11 @@ */ @SuppressWarnings("PMD.AbstractClassWithoutAnyMethod") public abstract class AbstractLinkingTest extends AbstractXtextTest { - private static final String NOT_RESOLVED_MESSAGE = "Cross-reference has not been resolved."; + private static final String NOT_RESOLVED_MESSAGE = "Cross-reference has not been resolved."; //$NON-NLS-1$ /** * Asserts that the actualObject equals the expectedObject. - * + * * @param expectedObject * the expected object * @param actualObject diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/model/ModelUtil.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/model/ModelUtil.java index 38153b6509..8b09412466 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/model/ModelUtil.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/model/ModelUtil.java @@ -84,7 +84,7 @@ public Iterable getAllInstancesOf(final EObject context, // CHECKSTYLE:ON return Iterables.filter(getAllInstancesOf(context, type), input -> { if (input.eClass().getEStructuralFeature(feature.getFeatureID()) != feature) { - Assert.fail("Feature " + feature + " is not a feature of " + input.eClass()); + Assert.fail("Feature " + feature + " is not a feature of " + input.eClass()); //$NON-NLS-1$ //$NON-NLS-2$ } final Object valueOfFeature = input.eGet(feature); return valueOfFeature != null && valueOfFeature.equals(value); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/modelinference/AbstractModelInferrerTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/modelinference/AbstractModelInferrerTest.java index 4d4245bb64..b67327fd35 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/modelinference/AbstractModelInferrerTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/modelinference/AbstractModelInferrerTest.java @@ -93,7 +93,7 @@ protected void assertNoInference(final int tag) { */ protected void assertNoInference(final EObject sourceElement) { final Set inferredElements = getInferredElements(sourceElement); - assertTrue("Unexpected inferred elements found: " + inferredElements.toString(), inferredElements.isEmpty()); + assertTrue("Unexpected inferred elements found: " + inferredElements.toString(), inferredElements.isEmpty()); //$NON-NLS-1$ } /** diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractUiTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractUiTest.java index 43683ac964..e1c1a95f4e 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractUiTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractUiTest.java @@ -76,7 +76,7 @@ protected void initializeSWTBot() { */ @Override protected String getTestSourceFileName() { - return this.getTestSourceModelName() + "." + getFileExtension(); + return this.getTestSourceModelName() + '.' + getFileExtension(); } @Override diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractXtextEditorTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractXtextEditorTest.java index c0f4e81eb2..fb5d47e746 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractXtextEditorTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractXtextEditorTest.java @@ -32,6 +32,7 @@ /** * AbstractXtextEditorTest provides convenient setup and access functionality for tests that require an xtext editor. */ +@SuppressWarnings("nls") public abstract class AbstractXtextEditorTest extends AbstractXtextMarkerBasedTest { private static final String EDITOR_MUST_NOT_BE_DIRTY = "Editor must not be dirty - this indicates state carried over"; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractXtextUiTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractXtextUiTest.java index 5c5e92d2f5..6bd19b19b1 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractXtextUiTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AbstractXtextUiTest.java @@ -114,7 +114,7 @@ public boolean test() { @Override public String getFailureMessage() { - return "Editor must be initialized."; + return "Editor must be initialized."; //$NON-NLS-1$ } }, EDITOR_ENABLED_TIMEOUT); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AcfSwtBotEclipseEditor.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AcfSwtBotEclipseEditor.java index 016ade8f26..b3e483e3fe 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AcfSwtBotEclipseEditor.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/AcfSwtBotEclipseEditor.java @@ -58,7 +58,7 @@ public boolean test() { @Override public String getFailureMessage() { - return NLS.bind("The cursor should be on the position ({0}, {1}) and the editor should have focus.", line, column); + return NLS.bind("The cursor should be on the position ({0}, {1}) and the editor should have focus.", line, column); //$NON-NLS-1$ } }); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/contentassist/AbstractContentAssistUiTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/contentassist/AbstractContentAssistUiTest.java index 8e8086edeb..95d4e6fb46 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/contentassist/AbstractContentAssistUiTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/contentassist/AbstractContentAssistUiTest.java @@ -39,6 +39,7 @@ /** * Abstract class for content assist tests. */ +@SuppressWarnings("nls") public abstract class AbstractContentAssistUiTest extends AbstractXtextEditorTest { private static final String EDITOR_HAS_NO_VIEWER = "Editor has no viewer."; @@ -249,8 +250,8 @@ private CompletionProposalComputer createCompletionProposalComputer(final int of protected int getTotalOffsetForToken(final ICompositeNode parserNode, final String name) { int result = NO_OFFSET_FOUND; for (final INode n : parserNode.getChildren()) { - if (n instanceof ILeafNode && name.equals(((ILeafNode) n).getText())) { - result = ((ILeafNode) n).getTotalOffset(); + if (n instanceof ILeafNode && name.equals(n.getText())) { + result = n.getTotalOffset(); } else if (n instanceof ICompositeNode) { result = getTotalOffsetForToken((ICompositeNode) n, name); } diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/hover/AbstractHoverTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/hover/AbstractHoverTest.java index 27405f08c7..6e5703d433 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/hover/AbstractHoverTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/hover/AbstractHoverTest.java @@ -32,6 +32,7 @@ /** * Base class for hover tests. */ +@SuppressWarnings("nls") public abstract class AbstractHoverTest extends AbstractXtextTest { /** diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/hyperlinking/AbstractHyperlinkHelperTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/hyperlinking/AbstractHyperlinkHelperTest.java index d1821ecec7..bed12cbdd2 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/hyperlinking/AbstractHyperlinkHelperTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/hyperlinking/AbstractHyperlinkHelperTest.java @@ -39,6 +39,7 @@ /** * Base class for hyperlink helper tests. */ +@SuppressWarnings("nls") public abstract class AbstractHyperlinkHelperTest extends AbstractXtextEditorTest { private static final String OFFSET_MUST_BE_EQUAL = "Offset must be equal"; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/labeling/AbstractLabelingTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/labeling/AbstractLabelingTest.java index c1ced92448..e5b728d927 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/labeling/AbstractLabelingTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/labeling/AbstractLabelingTest.java @@ -34,6 +34,7 @@ /** * Test labels of a given input file which is read in during setUpLabelTest(). */ +@SuppressWarnings("nls") public abstract class AbstractLabelingTest extends AbstractXtextTest { /** * Returns a list of pairs with the expected {@link ENamedElement} and the corresponding label string. diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/occurrences/AbstractOccurrencesTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/occurrences/AbstractOccurrencesTest.java index 097bf90297..4fc61bf775 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/occurrences/AbstractOccurrencesTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/occurrences/AbstractOccurrencesTest.java @@ -179,7 +179,7 @@ public boolean test() { @Override public String getFailureMessage() { - return "Error waiting for occurrences"; + return "Error waiting for occurrences"; //$NON-NLS-1$ } }; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/outline/AbstractOutlineTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/outline/AbstractOutlineTest.java index b95f2a98a5..4aed592467 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/outline/AbstractOutlineTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/outline/AbstractOutlineTest.java @@ -39,6 +39,7 @@ /** * Test the outline structure of an input file. */ +@SuppressWarnings("nls") public abstract class AbstractOutlineTest extends AbstractXtextEditorTest { /** * Returns a list of the elements expected in the outline of the default test resource. diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/outline/AbstractOutlineViewTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/outline/AbstractOutlineViewTest.java index 8988450110..6d9e3ee9dc 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/outline/AbstractOutlineViewTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/outline/AbstractOutlineViewTest.java @@ -42,6 +42,7 @@ protected void expandIfNotExpanded(final SWTBotTreeItem treeItem) { * @return the {@link SWTBotView} representing the outline view * @throw WidgetNotFoundException if there is no active editor */ + @SuppressWarnings("nls") // CHECKSTYLE:CONSTANTS-OFF protected SWTBotView openOutlineViewOfActiveEditor() { getBot().menu("Window").menu("Show View").menu("Outline").click(); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/syntaxcoloring/AbstractSyntaxColoringTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/syntaxcoloring/AbstractSyntaxColoringTest.java index 9feb5529dd..9374361ffb 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/syntaxcoloring/AbstractSyntaxColoringTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/syntaxcoloring/AbstractSyntaxColoringTest.java @@ -38,7 +38,7 @@ * Base class for syntax coloring tests. */ public abstract class AbstractSyntaxColoringTest extends AbstractXtextEditorUiTest { - private static final String STYLE_ASSERTION_FAILURE_MESSAGE = "The text style at the offset %d must match the expected style."; + private static final String STYLE_ASSERTION_FAILURE_MESSAGE = "The text style at the offset %d must match the expected style."; //$NON-NLS-1$ /** The Constant LEAF_NOT_FOUND_VALUE is returned when a leaf node is not found. */ protected static final int LEAF_NOT_FOUND_VALUE = -1; diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/AbstractFormatterTest.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/AbstractFormatterTest.java index 39407153a2..92b4b34e3f 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/AbstractFormatterTest.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/AbstractFormatterTest.java @@ -28,6 +28,7 @@ * Base class for formatting tests. * The assertXyz methods are essentially copied from {@link com.avaloq.tools.ddk.xtext.test.formatting.AbstractAcfFormattingTest}. */ +@SuppressWarnings("nls") public abstract class AbstractFormatterTest extends AbstractXtextTest { /** diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/FormatterTest.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/FormatterTest.java index 473afeeb74..3a2013c06b 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/FormatterTest.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/FormatterTest.java @@ -27,6 +27,7 @@ * This class tests the Acs Formatter framework. The tests are basically a copy * of the Xtext Formatter tests. */ +@SuppressWarnings("nls") public class FormatterTest extends AbstractFormatterTest { @Override protected FormatterTestUtil getXtextTestUtil() { diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/FormatterTestConfig.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/FormatterTestConfig.java index c7fb8a1704..1b95887d63 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/FormatterTestConfig.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/formatter/FormatterTestConfig.java @@ -23,6 +23,7 @@ import com.google.inject.Inject; +@SuppressWarnings("nls") public class FormatterTestConfig extends AbstractExtendedFormatter { private final IIndentationInformation indentInfo = new IIndentationInformationWithDefaults() { diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProviderTest.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProviderTest.java index 80d605e0f4..0d57f63daf 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProviderTest.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProviderTest.java @@ -18,6 +18,7 @@ /** * Tests for {@code AbstractFragmentProvider}. */ +@SuppressWarnings("nls") public class AbstractFragmentProviderTest { private static final String[] SPECIAL_ESCAPE_CASES = new String[] {"\\", "\\\\", "\\\\\\", "\\#", "\\\\#", "\\\\\\#", "#", "##", "#\\"}; diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/ShortFragmentProviderTest.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/ShortFragmentProviderTest.java index b6fa899231..57c29d5818 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/ShortFragmentProviderTest.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/ShortFragmentProviderTest.java @@ -31,6 +31,7 @@ /** * Tests for {@code AbstractFragmentProvider}. */ +@SuppressWarnings("nls") public class ShortFragmentProviderTest extends AbstractTest { private static final String FRAGMENT_MUST_BE_EQUAL = "Fragment must be equal"; diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNamePatternTest.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNamePatternTest.java index 365a3b6d02..8a932cb484 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNamePatternTest.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNamePatternTest.java @@ -25,7 +25,7 @@ @RunWith(XtextClassRunner.class) -@SuppressWarnings("PMD.JUnitAssertionsShouldIncludeMessage") +@SuppressWarnings({"PMD.JUnitAssertionsShouldIncludeMessage", "nls"}) // CHECKSTYLE:CONSTANTS-OFF public class QualifiedNamePatternTest { diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/AbstractSelectorFragmentProviderTest.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/AbstractSelectorFragmentProviderTest.java index 1ac4353de4..ec4fb770d5 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/AbstractSelectorFragmentProviderTest.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/AbstractSelectorFragmentProviderTest.java @@ -21,8 +21,8 @@ import org.eclipse.xtext.Keyword; import org.eclipse.xtext.XtextPackage; import org.eclipse.xtext.XtextRuntimeModule; -import org.eclipse.xtext.testing.AbstractXtextTests; import org.eclipse.xtext.resource.IFragmentProvider; +import org.eclipse.xtext.testing.AbstractXtextTests; import org.eclipse.xtext.util.Modules2; import org.junit.Before; import org.junit.Test; @@ -34,7 +34,7 @@ * Tests for {@code AbstractSelectorFragmentProvider}. */ // CHECKSTYLE:OFF -@SuppressWarnings({"PMD.JUnitAssertionsShouldIncludeMessage", "deprecation", "removal"}) +@SuppressWarnings({"PMD.JUnitAssertionsShouldIncludeMessage", "deprecation", "removal", "nls"}) public class AbstractSelectorFragmentProviderTest extends AbstractXtextTests { // CHECKSTYLE:ON diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDeltaTest.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDeltaTest.java index d0a53e225f..1538a10465 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDeltaTest.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDeltaTest.java @@ -33,7 +33,7 @@ import com.google.common.collect.Lists; -@SuppressWarnings("PMD.JUnitAssertionsShouldIncludeMessage") +@SuppressWarnings({"PMD.JUnitAssertionsShouldIncludeMessage", "nls"}) public class ResourceDescriptionDeltaTest { @Test diff --git a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/util/RuntimeProjectUtilTest.java b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/util/RuntimeProjectUtilTest.java index 48a565d55c..7a4b158afd 100644 --- a/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/util/RuntimeProjectUtilTest.java +++ b/com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/util/RuntimeProjectUtilTest.java @@ -39,6 +39,7 @@ /** * A test class for {@link RuntimeProjectUtil} */ +@SuppressWarnings("nls") public class RuntimeProjectUtilTest extends AbstractUtilTest { private static final String WORKSPACE_PATH = ResourcesPlugin.getWorkspace().getRoot().getLocationURI().getPath(); diff --git a/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/outline/ValidOutlineTreeProvider.java b/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/outline/ValidOutlineTreeProvider.java index 66ddc41407..a85967c494 100644 --- a/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/outline/ValidOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/outline/ValidOutlineTreeProvider.java @@ -33,7 +33,7 @@ public class ValidOutlineTreeProvider extends DefaultOutlineTreeProvider { /** * Do not create Model nodes in the outline. When the valid model is processed it is not * added to the outline but its children are. - * + * * @param parentNode * the parent node, this should be the tree root * @param modelElement @@ -46,7 +46,7 @@ protected void _createChildren(final DocumentRootNode parentNode, final ValidMod Image importContainerImage = JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPCONT); if (!modelElement.getImports().isEmpty()) { - createEStructuralFeatureNode(parentNode, modelElement, ValidPackage.Literals.VALID_MODEL__IMPORTS, importContainerImage, "import declarations", false); + createEStructuralFeatureNode(parentNode, modelElement, ValidPackage.Literals.VALID_MODEL__IMPORTS, importContainerImage, "import declarations", false); //$NON-NLS-1$ } for (EObject content : modelElement.getCategories()) { createNode(parentNode, content); @@ -55,7 +55,7 @@ protected void _createChildren(final DocumentRootNode parentNode, final ValidMod /** * Create the child nodes for a given native Context. We only show quick fixes. - * + * * @param parentNode * the parent node * @param modelElement @@ -71,7 +71,7 @@ protected void _createChildren(final IOutlineNode parentNode, final NativeContex /** * Create the child nodes for a given native native rule: its contexts. - * + * * @param parentNode * the parent node * @param modelElement diff --git a/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/conversion/ValidValueConverterService.java b/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/conversion/ValidValueConverterService.java index 144d6184f8..8d07a90b6b 100644 --- a/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/conversion/ValidValueConverterService.java +++ b/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/conversion/ValidValueConverterService.java @@ -32,13 +32,13 @@ public class ValidValueConverterService extends DefaultTerminalConverters { private static final class ExtensionIdValueConverter extends QualifiedNameValueConverter { @Override protected String getNamespaceDelimiter() { - return "::"; + return "::"; //$NON-NLS-1$ } } /** * Value converter for Identifier rule. - * + * * @return value converter */ @ValueConverter(rule = "QualifiedID") diff --git a/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/naming/ValidQualifiedNameConverter.java b/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/naming/ValidQualifiedNameConverter.java index 9ea2d93212..a796617a92 100644 --- a/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/naming/ValidQualifiedNameConverter.java +++ b/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/naming/ValidQualifiedNameConverter.java @@ -20,7 +20,7 @@ public class ValidQualifiedNameConverter extends IQualifiedNameConverter.Default @Override public String getDelimiter() { - return "::"; + return "::"; //$NON-NLS-1$ } }